Message ID | 20240229195220.2673049-2-horatiu.vultur@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp642273dyb; Thu, 29 Feb 2024 11:53:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU0NNehrY5lqRw4/bkVBFfqi8BCMI1+RFX7BsqyarLJnED4fukKt0lM+GojXJ8ZmszebesBTP5MevWzHZWb8MIzNLXWww== X-Google-Smtp-Source: AGHT+IHZwUCMAl8/7zSaa2D9pPTaL3N+1XcLhN+u09NEqBlEUT00LyhEs/LCzSqKIo697uFZ9vJv X-Received: by 2002:a37:e20c:0:b0:787:ec14:877f with SMTP id g12-20020a37e20c000000b00787ec14877fmr3429050qki.34.1709236424784; Thu, 29 Feb 2024 11:53:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709236424; cv=pass; d=google.com; s=arc-20160816; b=z7ZTc6Pd3ShMpDMKpmewotIsMw57kZT47KUelJO9UJQIAd8MdbMKRqyBSaCSVhH6jz wkwJQPn1zu5MEAHb75PvTDkXlab9swCBNTgZq0liPL1qw9iEs2SkgZ8etQ+z0lS+MFUE oRxwLnwq4J9aOpeJ9H6t3qikoELko7nFtdN6ARQDsWEFmlakLTCLyo/VYXQaQCrxxAoB CDGVHJZlxEoEF0LisKSate69F9RPQob6+M3kanZgANeHbP5BB3AAGnzjAwJBFBV3OOd5 POEmuM2uYYse83NXt8jLKR8aG5llzxA0/NEuIAW0hi14cPZOWfUPrhv2TdAExb2C2EOL Wm4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Phc/414BY7fmUwpnuHXv9QOVMfsXjGtvVlOgbklvjto=; fh=FpR3mLPdqQBO82L2zYItx4P35UDSZWGyoRAIuPUC/TA=; b=GKXZ0EXGbhtMVBFFwPgSJzgXTK7YnsiSI9U6/YyWlWvC85SmIGno59j27YwTWI/LfU Kj+54tEOt9trd7muRs0GPRQMbNhCOj6D0epQQK6vy3mFLdCs8WmjGM2NnLSvIq+6YicL PowgjAJeplRryDUPsxZJfT4MMytF0DFXgICY1kas12yBt5HLX26I5mTL26FyyliWC1NQ 4eJ0TZ65wyKXUh9/bTRoexVvPP9v4U9hV0BAkHCFAf2z73VHqN8kEuzfecYYELKHGDZc OQwPWpfuMOfyod/3EykKgZ7ROw7cMZFiFleJCQ2kwSiFYzspsfhvB0p+yX7hZ1RnaeTF IGpw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=rOLcLMbC; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i4-20020ae9ee04000000b00787778ed49esi1915388qkg.745.2024.02.29.11.53.44 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 11:53:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=rOLcLMbC; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8FD0C1C2298E for <ouuuleilei@gmail.com>; Thu, 29 Feb 2024 19:53:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1BCD713F42C; Thu, 29 Feb 2024 19:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="rOLcLMbC" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D13C13C9F7; Thu, 29 Feb 2024 19:53:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709236388; cv=none; b=kTVzi4Xiqi75V3LnHIPnnPW7ytFY90q164Cguce8For0orvMKviVIjLlWBQT8Fpzc/lVJvtpYuCQ3PpXPpWhoY9Y3Z3cIpbNmw7mNiEQv3NITAi0TfAUSv/Ck67pxS/GUdZaz7sdPvdvpINQCsjUNT/aAQcCBPX+j5ySENIp7bU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709236388; c=relaxed/simple; bh=gmYPlJjIF0Hbvmzz48jcajCXOb7Cc/tg1xpCPkEClkE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fFhGzkAutTXYiavy/YQWPL03hgcl/vlEsHJQaa1iffpLagXplLBT2zRi539LeOtko8QwOErm9On2wS7myB+YA8rVxmdX8M+23ql+R0SYtMT5AERBLEWOu+EinRSQEfYmmDkOQPgJYWtpBCS/Wfgqs6c7iqRXtGe4Ju1i29ydrQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=rOLcLMbC; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1709236386; x=1740772386; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gmYPlJjIF0Hbvmzz48jcajCXOb7Cc/tg1xpCPkEClkE=; b=rOLcLMbCAyfFte8NE+e0TgGVNjNk7iKCeCHCTwPFHKdv1RnqUouBtNng OhbqooJYbFe76NY+o41rTtJomBeFcH3yDSVB/1SxbGUlEUdG7o+nD0M5p Qjduh5KFOvVCvIhhNI+rVrNraR6uo5/d3Wglxhs8Uepfa+VTaMOOEO2MB ZaIR63e1Aq3jv3eEss1fU9lQjXevVmfw0TXUBInFfBD2fHW57MRuk2hkh 0PVU3XTPSOs41FPJ8QMdZqwzVqPLYumTEKBiiED+L+eiGCHSNBr4oxKEV DEe2K+1dHEkTkjSWYHR80c3myutabCQBuVbT3Ifb1qd+/xpRlLFVwx8Zy Q==; X-CSE-ConnectionGUID: lxx6YzUCRQKZ1uyD65VsbA== X-CSE-MsgGUID: CRFUDg9/QKWC5e255Mix+g== X-IronPort-AV: E=Sophos;i="6.06,194,1705388400"; d="scan'208";a="184305290" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Feb 2024 12:53:05 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 12:52:40 -0700 Received: from DEN-DL-M31836.microsemi.net (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 12:52:38 -0700 From: Horatiu Vultur <horatiu.vultur@microchip.com> To: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>, <wojciech.drewek@intel.com> CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>, Horatiu Vultur <horatiu.vultur@microchip.com> Subject: [PATCH net-next v2 1/2] net: phy: micrel: lan8814 led errata Date: Thu, 29 Feb 2024 20:52:19 +0100 Message-ID: <20240229195220.2673049-2-horatiu.vultur@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240229195220.2673049-1-horatiu.vultur@microchip.com> References: <20240229195220.2673049-1-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792264293488474748 X-GMAIL-MSGID: 1792264293488474748 |
Series |
net: phy: micrel: lan8814 erratas
|
|
Commit Message
Horatiu Vultur
Feb. 29, 2024, 7:52 p.m. UTC
Lan8814 phy led behavior is not correct. It was noticed that the led
still remains ON when the cable is unplugged while there was traffic
passing at that time.
The fix consists in clearing bit 10 of register 0x38, in this way the
led behaviour is correct and gets OFF when there is no link.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/phy/micrel.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
Comments
On 29.02.2024 20:52, Horatiu Vultur wrote: > Lan8814 phy led behavior is not correct. It was noticed that the led > still remains ON when the cable is unplugged while there was traffic > passing at that time. > > The fix consists in clearing bit 10 of register 0x38, in this way the > led behaviour is correct and gets OFF when there is no link. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > --- Thank you! Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> > drivers/net/phy/micrel.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 9b69735819896..88cc03982bb78 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -114,6 +114,9 @@ > #define LAN8814_INTR_CTRL_REG_POLARITY BIT(1) > #define LAN8814_INTR_CTRL_REG_INTR_ENABLE BIT(0) > > +#define LAN8814_EEE_STATE 0x38 > +#define LAN8814_EEE_STATE_MASK2P5P BIT(10) > + > /* Represents 1ppm adjustment in 2^32 format with > * each nsec contains 4 clock cycles. > * The value is calculated as following: (1/1000000)/((2^-32)/4) > @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev) > return 0; > } > > +static void lan8814_clear_2psp_bit(struct phy_device *phydev) > +{ > + u16 val; > + > + /* It was noticed that when traffic is passing through the PHY and the > + * cable is removed then the LED was still one even though there is no > + * link > + */ > + val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE); > + val &= ~LAN8814_EEE_STATE_MASK2P5P; > + lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val); > +} > + > static int lan8814_probe(struct phy_device *phydev) > { > const struct kszphy_type *type = phydev->drv->driver_data; > @@ -3324,6 +3340,9 @@ static int lan8814_probe(struct phy_device *phydev) > > lan8814_ptp_init(phydev); > > + /* Errata workarounds */ > + lan8814_clear_2psp_bit(phydev); > + > return 0; > } >
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 9b69735819896..88cc03982bb78 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -114,6 +114,9 @@ #define LAN8814_INTR_CTRL_REG_POLARITY BIT(1) #define LAN8814_INTR_CTRL_REG_INTR_ENABLE BIT(0) +#define LAN8814_EEE_STATE 0x38 +#define LAN8814_EEE_STATE_MASK2P5P BIT(10) + /* Represents 1ppm adjustment in 2^32 format with * each nsec contains 4 clock cycles. * The value is calculated as following: (1/1000000)/((2^-32)/4) @@ -3288,6 +3291,19 @@ static int lan8814_release_coma_mode(struct phy_device *phydev) return 0; } +static void lan8814_clear_2psp_bit(struct phy_device *phydev) +{ + u16 val; + + /* It was noticed that when traffic is passing through the PHY and the + * cable is removed then the LED was still one even though there is no + * link + */ + val = lanphy_read_page_reg(phydev, 2, LAN8814_EEE_STATE); + val &= ~LAN8814_EEE_STATE_MASK2P5P; + lanphy_write_page_reg(phydev, 2, LAN8814_EEE_STATE, val); +} + static int lan8814_probe(struct phy_device *phydev) { const struct kszphy_type *type = phydev->drv->driver_data; @@ -3324,6 +3340,9 @@ static int lan8814_probe(struct phy_device *phydev) lan8814_ptp_init(phydev); + /* Errata workarounds */ + lan8814_clear_2psp_bit(phydev); + return 0; }