From patchwork Thu Feb 29 17:04:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 208433 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp543942dyb; Thu, 29 Feb 2024 09:08:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUNBL0mvkVatmz/RrEXnW1yPtR4cWdyWzo7RO+IlJNO9VSRH+56tzejgcfKheilfP9azEEOQUUS4LnjETCf0kZKr9PIiw== X-Google-Smtp-Source: AGHT+IEQrxBxMdrZuZNCuwkbY/aS7VUw4kjKphpx6w5OBZ9yNpkCu/hJSNIHnlu4+4KhFblkz3i+ X-Received: by 2002:a17:906:d793:b0:a44:4b9d:b2a4 with SMTP id pj19-20020a170906d79300b00a444b9db2a4mr1424620ejb.73.1709226506619; Thu, 29 Feb 2024 09:08:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709226506; cv=pass; d=google.com; s=arc-20160816; b=P/mRjlpCVSWEyIzJ2zhQFhiQe7xOnOSu9mfr+M/ilg43NJA2yzC0PD+28vL0DgkF48 YPvoixDPirSmwbROcWszmESSlyXpSeoO1znlFodN6oS6YesDNWTUssakbYjlpIrAbzdp va7jG6yDxx7OiEkrDqtSMltZlo9FUS+hdqqQ+61YzwfTJ+USqrPp07OMpdhtY5Z7tS/C P2yryZFXc+EZo/fkmP12Meok5HA1lOGx0grUGRfHCI8b/R4Oce4dNyy6aMG7XNV6L01R 5arQgqbeKUl+kiYjL46rHKJ7wODzljJhjj7ru/4/iQbpo52hhiCb9haU1lpX8DTB8OT4 QLmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=umXmCN0wcxBj+OX5iM/0dix7BhHHVWXFpQt8h8LpQuM=; fh=3jzMT9iEWuqDWHCdGefTSnxMfHFPLsgg/BK8Oudwy50=; b=YV1SLFijzm9wSwB/BAuD6DYDElIMil+w85DGnE9LMlNpjNlmrAExfRc0jV6cS3vInA Z2frNbcS6mjxcRhreDTZgdBAJRJD0QhEwgI5bS8QhvwuFSPsnGKzCzNY3H7ik4sl7cQU 6Y4kzgwr+Q4HHQjRkneFMEWdIEJ2adfLq+MKgbb7HUAOK4Ae+C/Ex/X/gndwaLZ9J2cJ fM010nWmTQ6fSBKg1WRpNZ4yQj+3GLISaMCKWWCh9E8+qt01tOUr8+YRFhWtkMUbwDNI 0aEMXFhORhNng5aHg7EonzCocnhZa50GkE67J09VVdMuyjGLr5ZT++S6drTvOZo004T0 b72A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-87144-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87144-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b11-20020a170906038b00b00a43195a854esi711446eja.45.2024.02.29.09.08.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 09:08:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87144-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-87144-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87144-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 41BF01F21B02 for ; Thu, 29 Feb 2024 17:08:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A743313C9FB; Thu, 29 Feb 2024 17:05:00 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602CC67E64; Thu, 29 Feb 2024 17:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709226299; cv=none; b=INX+YEEDEe3NY263G9kVG/YcrCJhjOJWx9fEG0bFZJlihIYIySds3to10RDCw3EgvlyA622JRobW/QJc0jtxT2JjDd8hUeOnwA+YKBJyLRPMPqvbO2qUexchyKualSHSckhggKUjl3M99rJFbUbIDT5MxDXenMpFJMh/cleUNLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709226299; c=relaxed/simple; bh=NG0jFr87ijT5BYSsGI9lSmaYhaA9rtZkHHR8E7Yobbg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aXg/QZRNaYPYoBlpmoltdQFpyGxK3/KoSbpltRjz78Ds+IeyQE9O40zThXJGDkv9wCIbO6/25xaYjdrILi05aACyAZ02wQe5H3fJ0xt/h8btCZb0zwtiR6YMZ9Q/XuhVu55fgKz4J10WJUO+mk3DAzvin9FOvdykiW4f9nusQnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-412c286be35so3081065e9.0; Thu, 29 Feb 2024 09:04:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709226296; x=1709831096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umXmCN0wcxBj+OX5iM/0dix7BhHHVWXFpQt8h8LpQuM=; b=DvwtbSf8fmDZZmViiYwaCM0iwuKUutEOwY4Z+NHSrV9Xnppu0erIhmgZzs1UO12CcU 7pJYqbnkutDtR46WA+GbRgCJhQXEpXzGktTuNSUwbupR79/PaJwwV9xOpD3o4ZVqRJbh gpr51Blr6Fw1O79V6m0CcUaO33yhWbYbIXm7PmAuoq3k0bIaTiN7OFBz60TRirQdBxXq 9/1kAInPTvSL/YKd6dkMgyKm3MdcrteFa93Md9UDlDWkuOPIsfDYtuFd4uXf4VcgmPTK Vp839w1riF0doSjao2xfZK6O0Maczp+NJGtx13cago6ngWtK8NfB5LKog5ymka1wlVmQ sPvg== X-Forwarded-Encrypted: i=1; AJvYcCWELUtkIfAnT/PbzMtVtUkVVj3RD/YvnW433oN2CS+jcOQCe1IqVsxVdVBs/LYH8t/yGN74PfSaUFYMIeGDw5i7Y5Z0jbINqxvKkUnU X-Gm-Message-State: AOJu0YxsqpxA+6c8E3uIp3dlBSqt/J0j4Cn2jvi4ilGhNtBdkneSvt6c 4Spv3aIhBVdt2B/k6CWhsPBluvJVgdr664Phg16jG3PNA9DOB7r5 X-Received: by 2002:a05:600c:1e86:b0:412:beb8:841e with SMTP id be6-20020a05600c1e8600b00412beb8841emr1928346wmb.13.1709226295504; Thu, 29 Feb 2024 09:04:55 -0800 (PST) Received: from localhost (fwdproxy-lla-009.fbsv.net. [2a03:2880:30ff:9::face:b00c]) by smtp.gmail.com with ESMTPSA id g8-20020a05600c310800b00412b0ef22basm2654717wmo.10.2024.02.29.09.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 09:04:54 -0800 (PST) From: Breno Leitao To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, dsahern@kernel.org Subject: [PATCH net-next 2/2] net: bareudp: Remove generic .ndo_get_stats64 Date: Thu, 29 Feb 2024 09:04:24 -0800 Message-ID: <20240229170425.3895238-2-leitao@debian.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229170425.3895238-1-leitao@debian.org> References: <20240229170425.3895238-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792253893380116097 X-GMAIL-MSGID: 1792253893380116097 Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao Reviewed-by: Simon Horman --- drivers/net/bareudp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 27408f0b93d6..339db6e4a1d5 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -523,7 +523,6 @@ static const struct net_device_ops bareudp_netdev_ops = { .ndo_open = bareudp_open, .ndo_stop = bareudp_stop, .ndo_start_xmit = bareudp_xmit, - .ndo_get_stats64 = dev_get_tstats64, .ndo_fill_metadata_dst = bareudp_fill_metadata_dst, };