From patchwork Thu Feb 29 14:38:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 208395 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp441376dyb; Thu, 29 Feb 2024 06:39:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW5+oDIUcuUQubMR59cD55la31SrGB69NtARRNShUuUTijT9syZm4lYr+TipQpn032NBgynbRp4SerbmRGiG1SCSeM/vQ== X-Google-Smtp-Source: AGHT+IGUBQdwcWr3688f1AAWUu0nsY2Epn05n0t/FC/z8Qd+2X42bN5iBtPzwKRFLPAOA1MrFXp6 X-Received: by 2002:a92:c60c:0:b0:365:16cd:66 with SMTP id p12-20020a92c60c000000b0036516cd0066mr2257725ilm.31.1709217549216; Thu, 29 Feb 2024 06:39:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709217549; cv=pass; d=google.com; s=arc-20160816; b=DtUU97ou9P4vXPHU6cZ+nrSye+5UpavVUc20Fb2AO5cvga6xBnt2JkOFTBMiCp3Q4d +cPNN8347xGdwxWfi9YB0d5PX6iic2Knm783MD87wlMLekW4mmdiQnEE/sOo5UQRGXaJ iTe+eiEDUwBJN6uKyOugWabsZTm812svtK3lFzk0Kzhl+sQI3mhz0P307KbnTx/HzEWE 7yxpvd0kocVVPDNyAlgCp1Ri3qnI15Jt8zzx6cYRSEpK2v6hir92M31bseSYf8IjdXnl XW2sLIImEmWVQiH8OKVDf3+eJljkVWa9WOmsztkXD0EebSim9bmM8myFbBSz1eLQKY4s hBmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=G9lGgMINniLkVRtWEB94JfaSXiVXzJ3zBDgcsYBjX2Q=; fh=X1/oBJvTGJUQ0YtRp03u+3tPfRw/dXXALWynfOSlfQQ=; b=A6+SCRXOx4CiXIIhqRUupLa/KbYqfOCqOyWBsxB0BjhNtEq14Tm6wWQJz67jtG1y2x UswiqQEGsBarbvd86vi0WphqYlw8RnuoP3bpcCKctb0xlrYvQsS28QEP3BvgNooO/VCZ /sDuj2WZWDg0Lqip49lCYnzOOTdOG0nEFwqtkEGTkp9erln7opVhHrb2yMzHi4hnNzBo lhQ1hivbEpDwGhiQ3XUr+Zl+jRz66k/ftGyYEPd8p4bCo7xUe8ZshQbgmAyd0YCPCtBN sq2wjUQj4LvCw//HOfuxQPySDdq5T9faZTklQTaealgOP3DmPJk7j/lFAdm6UAxmYh4P WfiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kkKCgvoV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-86851-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86851-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r12-20020a632b0c000000b005d8e3490d49si1486701pgr.407.2024.02.29.06.39.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 06:39:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86851-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kkKCgvoV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-86851-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86851-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 04F47286415 for ; Thu, 29 Feb 2024 14:39:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1E2F137778; Thu, 29 Feb 2024 14:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kkKCgvoV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243E747F79 for ; Thu, 29 Feb 2024 14:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709217525; cv=none; b=o/ZKMoR4fviiTSkfku9mEjgh0Xxp49TYwsa8XnCk3eRs04pjhLwxqZyIK42+r2Wxdlddhh6tOi6DhHgo8kbHHiSySmyuAdhgEvdPmjCl7Ca6y3af14mzLQPdyS/VJJ6uFIVRkrSWBTTqui/kqnqvjoTrm1n8OFqkQ5UppVp1B0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709217525; c=relaxed/simple; bh=Moqfr6mUAj0cy5t4bUR4kuQxOZ7ekFifn6MgoPalCOQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bR2kzycxfHWvTBMUVGIPiUdTUS6AmhxHP0mdSoeOSg5N8w6Xbonw7q+F4T0/NlwEbx0y1h6rKNCTxQgfHJQPvON9x+RJEzut3zSXelE33wAkmRvawxeCL6SamfAisFlE2VInbNRuLb6q74qXOyE/iBzgQS55tWGwDTM+S3REs7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kkKCgvoV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65E45C43390; Thu, 29 Feb 2024 14:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709217524; bh=Moqfr6mUAj0cy5t4bUR4kuQxOZ7ekFifn6MgoPalCOQ=; h=From:To:Cc:Subject:Date:From; b=kkKCgvoVVMA6OC7WTQWRwingG9cDIc5Gx9viakKIL+5b/b7E6ocZVMm7GrUM2E2AP UPsoGOrjLKZLlZAGoN1nWoGySPsMKQ8XnrRTE6IJc3eWMRHb6svfJQXtP3XQB/KYad q+4H+RJ5pc+EXc0CmEZfW/+sVIJroamt4w37xL66pJSGghkjVo9LnvrsZ8IwuAxUcT AvQGSkNvam6AwRKZYu9G69b/d3kQ8breBo5/uAWW6Twa7i9WPqcIkwfTWAZXU1k2Uh MBlds/t2e+IQgCmZ2v4FCAsRgstYb/EV/CQsp/OFsLVq8MAvc396ZXwr0g6GMyWQTJ iDqRia1gZRLYw== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] f2fs: support .shutdown in f2fs_sops Date: Thu, 29 Feb 2024 22:38:38 +0800 Message-Id: <20240229143838.45149-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792244500502119488 X-GMAIL-MSGID: 1792244500502119488 Support .shutdown callback in f2fs_sops, then, it can be called to shut down the file system when underlying block device is marked dead. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/file.c | 70 ++++++++++++++++++++++++++++++------------------- fs/f2fs/super.c | 6 +++++ 3 files changed, 51 insertions(+), 27 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 85eb9a8a5ed3..80789255bf68 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3506,6 +3506,8 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr); int f2fs_truncate_hole(struct inode *inode, pgoff_t pg_start, pgoff_t pg_end); void f2fs_truncate_data_blocks_range(struct dnode_of_data *dn, int count); +int f2fs_do_shutdown(struct f2fs_sb_info *sbi, unsigned int flag, + bool readonly); int f2fs_precache_extents(struct inode *inode); int f2fs_fileattr_get(struct dentry *dentry, struct fileattr *fa); int f2fs_fileattr_set(struct mnt_idmap *idmap, diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4ca6c693b33a..d223175b3d5c 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2226,34 +2226,13 @@ static int f2fs_ioc_abort_atomic_write(struct file *filp) return ret; } -static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) +int f2fs_do_shutdown(struct f2fs_sb_info *sbi, unsigned int flag, + bool readonly) { - struct inode *inode = file_inode(filp); - struct f2fs_sb_info *sbi = F2FS_I_SB(inode); struct super_block *sb = sbi->sb; - __u32 in; int ret = 0; - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; - - if (get_user(in, (__u32 __user *)arg)) - return -EFAULT; - - if (in != F2FS_GOING_DOWN_FULLSYNC) { - ret = mnt_want_write_file(filp); - if (ret) { - if (ret == -EROFS) { - ret = 0; - f2fs_stop_checkpoint(sbi, false, - STOP_CP_REASON_SHUTDOWN); - trace_f2fs_shutdown(sbi, in, ret); - } - return ret; - } - } - - switch (in) { + switch (flag) { case F2FS_GOING_DOWN_FULLSYNC: ret = bdev_freeze(sb->s_bdev); if (ret) @@ -2292,6 +2271,9 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) goto out; } + if (readonly) + goto out; + f2fs_stop_gc_thread(sbi); f2fs_stop_discard_thread(sbi); @@ -2300,10 +2282,44 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) f2fs_update_time(sbi, REQ_TIME); out: - if (in != F2FS_GOING_DOWN_FULLSYNC) - mnt_drop_write_file(filp); - trace_f2fs_shutdown(sbi, in, ret); + trace_f2fs_shutdown(sbi, flag, ret); + + return ret; +} + +static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) +{ + struct inode *inode = file_inode(filp); + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); + __u32 in; + int ret; + bool need_drop = false, readonly = false; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + if (get_user(in, (__u32 __user *)arg)) + return -EFAULT; + + if (in != F2FS_GOING_DOWN_FULLSYNC) { + ret = mnt_want_write_file(filp); + if (ret) { + if (ret != -EROFS) + return ret; + + /* fallback to nosync shutdown for readonly fs */ + in = F2FS_GOING_DOWN_NOSYNC; + readonly = true; + } else { + need_drop = true; + } + } + + ret = f2fs_do_shutdown(sbi, in, readonly); + + if (need_drop) + mnt_drop_write_file(filp); return ret; } diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 78a76583a4aa..0676c2dcbbf7 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2547,6 +2547,11 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) return err; } +static void f2fs_shutdown(struct super_block *sb) +{ + f2fs_do_shutdown(F2FS_SB(sb), F2FS_GOING_DOWN_NOSYNC, false); +} + #ifdef CONFIG_QUOTA static bool f2fs_need_recovery(struct f2fs_sb_info *sbi) { @@ -3146,6 +3151,7 @@ static const struct super_operations f2fs_sops = { .unfreeze_fs = f2fs_unfreeze, .statfs = f2fs_statfs, .remount_fs = f2fs_remount, + .shutdown = f2fs_shutdown, }; #ifdef CONFIG_FS_ENCRYPTION