From patchwork Thu Feb 29 13:31:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Shumilin X-Patchwork-Id: 208363 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp394811dyb; Thu, 29 Feb 2024 05:32:23 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV5LtYHzJB3vOP8fmj5c4KUNYhGOyD5Fa8Hqup43YRBdoGKFTOi6BdV3bvAmwlZ9jfJqQpdenlMI7EM1UQ6rMinnejdFA== X-Google-Smtp-Source: AGHT+IEWLRi6/Dnm/WeDqzNWEksnGJVQ0nvOEXuA118uKZSQA0JVzgNHRDKcyNhi9Sy1Z3RcNeHF X-Received: by 2002:a05:622a:48e:b0:42e:4222:3011 with SMTP id p14-20020a05622a048e00b0042e42223011mr1847846qtx.68.1709213543651; Thu, 29 Feb 2024 05:32:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709213543; cv=pass; d=google.com; s=arc-20160816; b=fZ1UpqO15UrZyrUxH37JH4j9vxjLKsGgp3uQLgZZXNJI7SuGkGVNeCWOnMRHWRl3r2 Oa+oRr/Mnk6FiQVy70tpyTebDWfzrBZedqshKpu4Moa4+er+ceCExAJWM2e3OxR6eClP 5obP+JS1l4XGiC4evt3nmACfFQVxmOd7rwmGA/gZOPP6aGLj0dzeH0NOSGlTldlRM/Dt cX/PCEK1q8wRplQvqesAXJ/YVSVax+j83S0zKooUSxQMiziMmXkP22qIkUg5EP0ZTf6k vdhWV+fskjveBlIBFpoacGmMYE5Wlm3mHMHrWslVG8cmkHccbKuz8GmDKChiWdxXzRS7 a/bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=xujii2ttH+o4Ia7D4u1Pbs4ibfJMBSgrvLrdxpBm3yQ=; fh=oQJGH/IHCaJn53CstiIf+jFWy9CHTPxHdDD9m9OChaI=; b=wxIyedYAx2E5fbR80faLLVwqViHJUT6bhpBIS7rmWzgxFXSkdhXTsr1tuFg/RWXGUm M1fL1aNrmIQo49iPa6wgQ99V7AqpWTknCpscOHaFXgGj0KEs1UmBdN9/nRArJvVAcZgw ESew+6gQFaa3kBHrubUsFkHWfJc2CHGRP2bi8h3rfd1+J7S12HtDFVOqp+Z2HWYkm108 1wAmyKGXLsvscNPT/T945wYBTN0JvQdeNk+CeIb8uNCZm4ZfmUBVIjEbjLHfnwzLhLWR sUmqq2eol3rfOhK83x5j9jLc3hVWbQeyArybZPlD5i+WTD3Y7prmXeH6OTxPL13gFfQV Bqtw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b=gAq84hzQ; arc=pass (i=1 spf=pass spfdomain=nppct.ru dkim=pass dkdomain=nppct.ru); spf=pass (google.com: domain of linux-kernel+bounces-86755-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86755-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h1-20020ac846c1000000b0042e8a1322b9si1318340qto.180.2024.02.29.05.32.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:32:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86755-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b=gAq84hzQ; arc=pass (i=1 spf=pass spfdomain=nppct.ru dkim=pass dkdomain=nppct.ru); spf=pass (google.com: domain of linux-kernel+bounces-86755-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86755-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6C7B21C2083D for ; Thu, 29 Feb 2024 13:32:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4A7B12EBD1; Thu, 29 Feb 2024 13:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nppct.ru header.i=@nppct.ru header.b="gAq84hzQ" Received: from mail.nppct.ru (mail.nppct.ru [195.133.245.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 785D97E575 for ; Thu, 29 Feb 2024 13:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.133.245.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213511; cv=none; b=IQ5dUvdpQDHtUu5Eu/C02rIOBY/nyVqq8HaQBgaNIUEMWCLp/VhheZC0hO78/rXDDa99/imXBPJ3gY29Kv0IOVWdFEqzOfbZMBpjAnF/RfybPBhGD0v9EU2irI2HTM+SkgVGHXJkpWXjWvZ9HNubt9BuLpEQT5nABX04XS8c7bo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213511; c=relaxed/simple; bh=K0TTl2ZaTlnEakj4bva9CgVtiIRlTw5OCcRhupVi7a8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Sga839Ml0WR57XcP1mQSKullEnV3QSdx1kqieQjr6iHM7o1IVwNINJNp10agLyt130xPx+kIcLv87/XnRd/rKjR0MsS9f3APueBNPWBCZFw7ILpRXwjNnoirL/zXunBGGxTD/iRuuALqAIwhs69pgaVULtQFYZyO7/R1J3vUcZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nppct.ru; spf=pass smtp.mailfrom=nppct.ru; dkim=pass (1024-bit key) header.d=nppct.ru header.i=@nppct.ru header.b=gAq84hzQ; arc=none smtp.client-ip=195.133.245.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nppct.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nppct.ru Received: from mail.nppct.ru (localhost [127.0.0.1]) by mail.nppct.ru (Postfix) with ESMTP id 90F631C0E63 for ; Thu, 29 Feb 2024 16:31:33 +0300 (MSK) Authentication-Results: mail.nppct.ru (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nppct.ru DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nppct.ru; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:to:from:from; s=dkim; t=1709213488; x= 1710077489; bh=K0TTl2ZaTlnEakj4bva9CgVtiIRlTw5OCcRhupVi7a8=; b=g Aq84hzQAREDhHz4LQM8fQm/1sIB9ZS03D9rEZkt5VimEaIuc9dm6sBy+SgV/Gqfv ucrmRkG7CJiTj5DnRGQqerq2WecLpDrEBXUoDzQUifQry1HbRl8GbjDhfZ5tselB F2qqBBuRhJuK19rUeI6vDeMfwdF7lwiopX0Kn4VMLA= X-Virus-Scanned: Debian amavisd-new at mail.nppct.ru Received: from mail.nppct.ru ([127.0.0.1]) by mail.nppct.ru (mail.nppct.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RYBfhFXJ6kXm for ; Thu, 29 Feb 2024 16:31:28 +0300 (MSK) Received: from localhost.localdomain (mail.dev-ai-melanoma.ru [185.130.227.204]) by mail.nppct.ru (Postfix) with ESMTPSA id D0A6B1C0E58; Thu, 29 Feb 2024 16:31:26 +0300 (MSK) From: Andrey Shumilin To: Juergen Gross Cc: Andrey Shumilin , Stefano Stabellini , Oleksandr Tyshchenko , linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, khoroshilov@ispras.ru, ykarpov@ispras.ru, vmerzlyakov@ispras.ru, vefanov@ispras.ru Subject: [PATCH 4/4] gntdev: Unchecked finction result Date: Thu, 29 Feb 2024 16:31:19 +0300 Message-Id: <20240229133119.638432-1-shum.sdl@nppct.ru> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792240300513480248 X-GMAIL-MSGID: 1792240300513480248 The dma_coerce_mask_and_coherent function may refuse to apply a mask due to incorrectly passed parameters. But since this function returns the error -EIO, this is an abnormal situation and the error must be written to the log. Signed-off-by: Andrey Shumilin Found by Linux Verification Center (linuxtesting.org) with SVACE. --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 61faea1f0663..8a448dbbca86 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -597,7 +597,8 @@ static int gntdev_open(struct inode *inode, struct file *flip) flip->private_data = priv; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC priv->dma_dev = gntdev_miscdev.this_device; - dma_coerce_mask_and_coherent(priv->dma_dev, DMA_BIT_MASK(64)); + if (dma_coerce_mask_and_coherent(priv->dma_dev, DMA_BIT_MASK(64)) == -EIO) + printk(KERN_INFO "The mask was applied unsuccessfully"); #endif pr_debug("priv %p\n", priv);