diff mbox series

arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor

Message ID 20240229012828.438020-1-swboyd@chromium.org
State New
Headers
Series arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor |

Commit Message

Stephen Boyd Feb. 29, 2024, 1:28 a.m. UTC 
  We don't use this pmic pinctrl node on any Trogdor devices. The
AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
anything in the devicetrees that include this file. Disable this device
node in the DTS so that we don't waste time or memory on this device.

Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
 1 file changed, 1 insertion(+)


base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d

Comments

Doug Anderson Feb. 29, 2024, 1:45 a.m. UTC | #1 
Hi,

On Wed, Feb 28, 2024 at 5:28 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Konrad Dybcio Feb. 29, 2024, 11:53 a.m. UTC | #2 
On 2/29/24 02:28, Stephen Boyd wrote:
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
> 
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---

If you don't use this pmic, perhaps the pins should be explicitly
"parked" instead?

Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 46aaeba28604..774c0647ea19 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -1164,6 +1164,7 @@  &pm6150_gpios {
 };
 
 &pm6150l_gpios {
+	status = "disabled"; /* No GPIOs are consumed or configured */
 	gpio-line-names = "AP_SUSPEND",
 			  "",
 			  "",