From patchwork Thu Feb 29 00:15:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 208088 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp88655dyb; Wed, 28 Feb 2024 16:18:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWvnWtieumcQ2jyuw0MtKSzh3e+dd66V/Ky2r0Et25ahfIIW6ebyKMIIRJtdBFJi7trW2bl1z1AkpW7oOhz2aL8qakd5g== X-Google-Smtp-Source: AGHT+IE6qfJ3KWfIxXRx3aWkVysHAV4KgUTYvrAIUgREHUexMPlK9NsJtemDiL1tbOv1mvTcehux X-Received: by 2002:a05:6359:411d:b0:17b:581c:430e with SMTP id kh29-20020a056359411d00b0017b581c430emr947402rwc.3.1709165894608; Wed, 28 Feb 2024 16:18:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709165894; cv=pass; d=google.com; s=arc-20160816; b=ODPxGlX16wEggv8EQC7sMMolP0HHGAubpjHYJqCR96Q2xSyCQlA1P0ntM6ZcxuQStv YiDDd/kMdR7A4AeG4c8fvL074ueMGhid7WwUDRBELRRQdsxNpDaumiEnIYfQasUMckol uS74HgpFjxz8BGtgzRAaDdApUNr3mvAMSsAFemYW55WQA2rQAwWj4jEJ3Q6igQ1vOH7s O4sYKG44prtiw2d+NsRBRXOk/QGfI9P21n63/sbuMR1G5D6Ua9/vOkuoliySs1nbZdmY JC0/zzQJ6K4TDOQOnkrOqaBX0vsB2vTzALquI5CwJ2zNoZTPJI4Y/LMXDCd3pjtURQ9t 4jxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:references:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:in-reply-to:date :dkim-signature; bh=nnw8j+u3lnjVu4UTXXzRJGFzX9SHr9I3FGbOrJjWHHs=; fh=nxVd516kcYr08l/K0rb/FzFxbrjClW+hX0JaeUyrHik=; b=W0IfuNh3w9eGKGf2jfVdKdJZ8klpObTBrICVCi2lAmtLRkZZyylbROlecfbBAuUtym Bo2NHwGFcpKo5TxUv86dg+yhyfyoBpysFCGufXgFOC+oadKNMJzL7PcmMaTEcUmTO9eW 4rCYcCMy7kI3WvFAHdMqzytzZPQsu/kZ8BlsT46mPFtzWaEFJm093CWnszvgsDvIBBro U1tVmRzC+iI22U63NcTTJSr5geLrGdgXHKIMXc0kEKm3iBlOLushWTijI7VPcJj6iTzp /qYNPqwp71bYmD45hWhFV5O9/pYmO93iN9ESJeh7NRm3OganyuVSiZ6J2tobVNqWY2vC lnhw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=CDZEwEQ+; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-85886-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85886-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id iu2-20020ad45cc2000000b0068feee484b5si258939qvb.174.2024.02.28.16.18.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 16:18:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85886-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=CDZEwEQ+; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-85886-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85886-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 632F31C216E9 for ; Thu, 29 Feb 2024 00:18:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2FA415E9C; Thu, 29 Feb 2024 00:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CDZEwEQ+" Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983977FE for ; Thu, 29 Feb 2024 00:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709165766; cv=none; b=iidDeylaOSfyxGOPUTaRThX1Xh1CqRGmCEIw0by6/K8GAY3d8sRfIu/rLoA12ay0bKHPK9sXb3XaGBPCUQxlQXkmVZTlYFIuhluAqwP/zau7MNjCDbhYJVJBkff87KQM6Oe7zcshDb0xKlth4KbGxo+WlUIVqRSo4jUr5LgLKKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709165766; c=relaxed/simple; bh=xBfxlNT0aaXEMy2J3656vmd02rMeN9x8F3Ypxz5k1Kk=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=jiMuIAo1uTxBUFujuVC/pTLc1TcIZR2gZ6vC4aUlxytBbstF9iRxJouqzQdDr2q96Fvod4BFP2BxBmXPI1+BEPomAGxOJ2OpgX3O3xQ+0priExJYLPRoUNrrtg4EoBE/kOTWtoRgkLb6V/9Oz3oV4pNUe8nOLvEdZ+uSjITT75s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CDZEwEQ+; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5efe82b835fso8215177b3.0 for ; Wed, 28 Feb 2024 16:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709165763; x=1709770563; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=nnw8j+u3lnjVu4UTXXzRJGFzX9SHr9I3FGbOrJjWHHs=; b=CDZEwEQ+/8KUHGuAg4i2NUa4TgorEzTxb0mPPbXV+zfjmXufeEkMvzhS4mwTg8D8M2 0qsveyes9xpOdxR/q+pbMJKl7xfCNFb4YSo12OnwKLl+1/+2FuDkxvz483rAMUPbp83q j3EgSUEKL5SaItl5mJCvoaJpxiCz9Eu47N7a2S/4FrPWiTlR9MlfWSyzcqUDC8NNPWqV 5Zh3DZ/+Mc6wGSq/TrOGzm20I+NpDMjqNLigQBXKGrdIcpRM1AZ30on/VajmTOmbK2xU fVfdi1Hx3qu1N5L8m6mJ8uOya6faknyEQNsHaw9cX8AcdjLQF2ESN3q/gl0fP+3JkYer b3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709165763; x=1709770563; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nnw8j+u3lnjVu4UTXXzRJGFzX9SHr9I3FGbOrJjWHHs=; b=OUIfotaXXwbprMk6BD4T4jo870n9NLJWbO6MhSuxzbOGW/aNAaRUlDmDYuLOBo4h8h hq5Xm8G58a+UiNtfxqUGvMRoQ4JHhvrzswRzITt+uxcS3f6eY89c/CC/AnY8T7RRL7tN 8hQWDopZIn1ZVpJxhVouy+EtBoaLkmM4W7niQB1yOeVsHCdMOdfCg4VrD53nS6DycC2L HDWE+otOvJnILYwC+MAgkcgDyBAtQwFml6kZln8AKjdtfKNI8R3dVU521moRjN+IMFcD BdH/kBFWIGSjaJwuAVX/xRcJIF5alge5sGB0saSp96de3hvFlzA7kCAZFh83azKK68Id 2brg== X-Forwarded-Encrypted: i=1; AJvYcCXPZeyhDwIpIpNhl+OdDgX4ScQX7mCKTonCbfuMcSsqkpG2R3NZTcTF49dCAd5rwL1XmDEnlyRvi1s55EtUiQL+6cU82UXbiBslsZQX X-Gm-Message-State: AOJu0YxY/eYfTrg4tG0KfCzQMm0ZuWg2a46Pbjpe+E4IHRYjRpGHzno7 a91mOmWfnRHGJOZbgJAUyjzzS8IqgObkTA3VCbB7LtuPoZpqFjB7lANyWmKZUL+H4wFhdahmVhJ LY1QSPA== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:77dc:144c:334e:e2dd]) (user=irogers job=sendgmr) by 2002:a05:6902:18c3:b0:dcd:875:4c40 with SMTP id ck3-20020a05690218c300b00dcd08754c40mr209662ybb.10.1709165763612; Wed, 28 Feb 2024 16:16:03 -0800 (PST) Date: Wed, 28 Feb 2024 16:15:33 -0800 In-Reply-To: <20240229001537.4158049-1-irogers@google.com> Message-Id: <20240229001537.4158049-10-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240229001537.4158049-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Subject: [PATCH v1 09/13] perf jevents: Add uncore l3 metric group for AMD From: Ian Rogers To: Sandipan Das , Ravi Bangoria , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , John Garry , Kan Liang , Jing Zhang , Thomas Richter , James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792190336885335567 X-GMAIL-MSGID: 1792190336885335567 Metrics use the amd_l3 PMU for access/miss/hit information. Signed-off-by: Ian Rogers --- tools/perf/pmu-events/amd_metrics.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/amd_metrics.py index be10acb40762..f4a4ece551ef 100755 --- a/tools/perf/pmu-events/amd_metrics.py +++ b/tools/perf/pmu-events/amd_metrics.py @@ -467,6 +467,23 @@ def Rapl() -> MetricGroup: return MetricGroup("cpu_power", metrics, description="Processor socket power consumption estimates") +def UncoreL3(): + acc = Event("l3_lookup_state.all_coherent_accesses_to_l3", + "l3_lookup_state.all_l3_req_typs") + miss = Event("l3_lookup_state.l3_miss", + "l3_comb_clstr_state.request_miss") + acc = max(acc, miss) + hits = acc - miss + + return MetricGroup("l3", [ + Metric("l3_accesses", "L3 victim cache accesses", + d_ratio(acc, interval_sec), "accesses/sec"), + Metric("l3_hits", "L3 victim cache hit rate", d_ratio(hits, acc), "100%"), + Metric("l3_miss", "L3 victim cache miss rate", d_ratio(miss, acc), + "100%"), + ], description="L3 cache breakdown per CCX") + + all_metrics = MetricGroup("", [ AmdBr(), AmdDtlb(), @@ -476,6 +493,7 @@ all_metrics = MetricGroup("", [ AmdUpc(), Idle(), Rapl(), + UncoreL3(), ]) if args.metricgroups: