diff mbox series

[1/3] ARM: dts: microchip: sama5d2: Move pinfunc.h headers

Message ID 20240229-pio4-pinctrl-yaml-v1-1-c4d8279c083f@microchip.com
State New
Headers
Series convert Atmel's PIO4 bindings to json-schema |

Commit Message

Balakrishnan Sambath Feb. 29, 2024, 11:39 a.m. UTC 
  Move sama5d2-pinfunc.h into include/dt-bindings/pinctrl so that we can
include it in yaml dt-binding examples.

Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
---
 arch/arm/boot/dts/microchip/at91-kizbox3_common.dtsi                    | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi                     | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi                   | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts                 | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts                        | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts                     | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts                   | 2 +-
 .../dts/microchip => include/dt-bindings/pinctrl}/sama5d2-pinfunc.h     | 0
 8 files changed, 7 insertions(+), 7 deletions(-)

Comments

Krzysztof Kozlowski Feb. 29, 2024, 5:43 p.m. UTC | #1 
On 29/02/2024 12:39, Balakrishnan Sambath wrote:
> Move sama5d2-pinfunc.h into include/dt-bindings/pinctrl so that we can
> include it in yaml dt-binding examples.

That is not a the reason to make something a binding. Please provide
rationale why this is supposed to be binding. Because it does not look
like at all and it is kind of contradictory to what we recently were
doing - moving from bindings to DTS.
> 

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/microchip/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/microchip/at91-kizbox3_common.dtsi
index 465664628419..30a0119d260e 100644
--- a/arch/arm/boot/dts/microchip/at91-kizbox3_common.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-kizbox3_common.dtsi
@@ -11,7 +11,7 @@ 
  */
 /dts-v1/;
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
 #include <dt-bindings/pinctrl/at91.h>
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
index 95ecb7d040a8..6c8f658ec51c 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
@@ -7,7 +7,7 @@ 
  *                2017 Claudiu Beznea <claudiu.beznea@microchip.com>
  */
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/gpio/gpio.h>
 
 / {
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
index 4617805c7748..6b8e688bb98a 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
@@ -8,7 +8,7 @@ 
  * Author: Eugen Hristev <eugen.hristev@microcihp.com>
  */
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
 #include <dt-bindings/pinctrl/at91.h>
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
index 6b02b7bcfd49..944cc68784a4 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
@@ -9,7 +9,7 @@ 
  */
 /dts-v1/;
 #include "sama5d29.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
index 999adeca6f33..62d331db8dd5 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
@@ -10,7 +10,7 @@ 
  */
 /dts-v1/;
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
index 200b20515ab1..28df6bc7b28f 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
@@ -8,7 +8,7 @@ 
  */
 /dts-v1/;
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
index 6680031387e8..60adaae39c83 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
@@ -7,7 +7,7 @@ 
  */
 /dts-v1/;
 #include "sama5d2.dtsi"
-#include "sama5d2-pinfunc.h"
+#include <dt-bindings/pinctrl/sama5d2-pinfunc.h>
 #include <dt-bindings/mfd/atmel-flexcom.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
diff --git a/arch/arm/boot/dts/microchip/sama5d2-pinfunc.h b/include/dt-bindings/pinctrl/sama5d2-pinfunc.h
similarity index 100%
rename from arch/arm/boot/dts/microchip/sama5d2-pinfunc.h
rename to include/dt-bindings/pinctrl/sama5d2-pinfunc.h