diff mbox series

[2/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdosys

Message ID 20240229-gce-client-reg-add-missing-mt8192-95-v1-2-b12c233a8a33@collabora.com
State New
Headers
Series arm64: dts: mediatek: Add missing gce-client-reg properties to mt8192 and mt8195 |

Commit Message

Nícolas F. R. A. Prado Feb. 29, 2024, 7:44 p.m. UTC 
  Add the missing mediatek,gce-client-reg property to the vppsys and
vdosys nodes to allow them to use the GCE. This prevents the "can't
parse gce-client-reg property" error from being printed and should
result in better performance.

Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

AngeloGioacchino Del Regno March 1, 2024, 8:50 a.m. UTC | #1 
Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
> Add the missing mediatek,gce-client-reg property to the vppsys and
> vdosys nodes to allow them to use the GCE. This prevents the "can't
> parse gce-client-reg property" error from being printed and should
> result in better performance.
> 
> Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Can you please squash patches 2,3,4 in a single one?

It doesn't make a lot of sense to have them separated in this case, only
generates commit noise for no practical reason imo.

arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex

Thanks,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ea6dc220e1cc..f2912e1a0e49 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -2028,6 +2028,7 @@ vppsys0: syscon@14000000 {
>   			compatible = "mediatek,mt8195-vppsys0", "syscon";
>   			reg = <0 0x14000000 0 0x1000>;
>   			#clock-cells = <1>;
> +			mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0 0x1000>;
>   		};
>   
>   		dma-controller@14001000 {
> @@ -2251,6 +2252,7 @@ vppsys1: syscon@14f00000 {
>   			compatible = "mediatek,mt8195-vppsys1", "syscon";
>   			reg = <0 0x14f00000 0 0x1000>;
>   			#clock-cells = <1>;
> +			mediatek,gce-client-reg = <&gce1 SUBSYS_14f0XXXX 0 0x1000>;
>   		};
>   
>   		mutex@14f01000 {
> @@ -3080,6 +3082,7 @@ vdosys0: syscon@1c01a000 {
>   			reg = <0 0x1c01a000 0 0x1000>;
>   			mboxes = <&gce0 0 CMDQ_THR_PRIO_4>;
>   			#clock-cells = <1>;
> +			mediatek,gce-client-reg = <&gce0 SUBSYS_1c01XXXX 0xa000 0x1000>;
>   		};
>   
>   
>
Nícolas F. R. A. Prado March 1, 2024, 2:39 p.m. UTC | #2 
On Fri, Mar 01, 2024 at 09:50:31AM +0100, AngeloGioacchino Del Regno wrote:
> Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
> > Add the missing mediatek,gce-client-reg property to the vppsys and
> > vdosys nodes to allow them to use the GCE. This prevents the "can't
> > parse gce-client-reg property" error from being printed and should
> > result in better performance.
> > 
> > Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
> > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> Can you please squash patches 2,3,4 in a single one?
> 
> It doesn't make a lot of sense to have them separated in this case, only
> generates commit noise for no practical reason imo.
> 
> arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex

I split them like this so that each has its own fixes tag and can all be easily
backported (as mentioned in the cover letter). That said, the commits fixed in 2
and 3 both landed in v6.1-rc1, so they could be squashed and still easily
backported. But the commit fixed in patch 4 only landed in v6.4-rc1, so if we
squash them all together, the first two won't be backported to v6.1.

Let me know how you want to proceed.

Thanks,
Nícolas
AngeloGioacchino Del Regno March 4, 2024, 10:16 a.m. UTC | #3 
Il 01/03/24 15:39, Nícolas F. R. A. Prado ha scritto:
> On Fri, Mar 01, 2024 at 09:50:31AM +0100, AngeloGioacchino Del Regno wrote:
>> Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
>>> Add the missing mediatek,gce-client-reg property to the vppsys and
>>> vdosys nodes to allow them to use the GCE. This prevents the "can't
>>> parse gce-client-reg property" error from being printed and should
>>> result in better performance.
>>>
>>> Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
>>> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>
>> Can you please squash patches 2,3,4 in a single one?
>>
>> It doesn't make a lot of sense to have them separated in this case, only
>> generates commit noise for no practical reason imo.
>>
>> arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex
> 
> I split them like this so that each has its own fixes tag and can all be easily
> backported (as mentioned in the cover letter). That said, the commits fixed in 2
> and 3 both landed in v6.1-rc1, so they could be squashed and still easily
> backported. But the commit fixed in patch 4 only landed in v6.4-rc1, so if we
> squash them all together, the first two won't be backported to v6.1.
> 
> Let me know how you want to proceed.
> 

Oh, I'm sorry I didn't notice that. Ignore my previous comment then, I'll take
those for the next fixes round as-is.

Cheers,
Angelo
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ea6dc220e1cc..f2912e1a0e49 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -2028,6 +2028,7 @@  vppsys0: syscon@14000000 {
 			compatible = "mediatek,mt8195-vppsys0", "syscon";
 			reg = <0 0x14000000 0 0x1000>;
 			#clock-cells = <1>;
+			mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0 0x1000>;
 		};
 
 		dma-controller@14001000 {
@@ -2251,6 +2252,7 @@  vppsys1: syscon@14f00000 {
 			compatible = "mediatek,mt8195-vppsys1", "syscon";
 			reg = <0 0x14f00000 0 0x1000>;
 			#clock-cells = <1>;
+			mediatek,gce-client-reg = <&gce1 SUBSYS_14f0XXXX 0 0x1000>;
 		};
 
 		mutex@14f01000 {
@@ -3080,6 +3082,7 @@  vdosys0: syscon@1c01a000 {
 			reg = <0 0x1c01a000 0 0x1000>;
 			mboxes = <&gce0 0 CMDQ_THR_PRIO_4>;
 			#clock-cells = <1>;
+			mediatek,gce-client-reg = <&gce0 SUBSYS_1c01XXXX 0xa000 0x1000>;
 		};