From patchwork Fri Mar 1 00:12:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208576 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762841dyb; Thu, 29 Feb 2024 16:14:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWvRdp92ePoGFb3bIqAI/DVhi8tiY/Q/nbrDD1F67knux7HJJKDAHYSfgCzoIKkqLM5DSpLfIlN6BxHVXYWorPt8Bt36A== X-Google-Smtp-Source: AGHT+IHDFhgC8RhXwbcEXBOJ/B/oIM+NTKjSxHmVkPjI2+pClsEqFqIFPqq8SDR/+Efr9Ka139l6 X-Received: by 2002:a05:6402:3410:b0:566:ab94:5b83 with SMTP id k16-20020a056402341000b00566ab945b83mr147031edc.23.1709252078423; Thu, 29 Feb 2024 16:14:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252078; cv=pass; d=google.com; s=arc-20160816; b=ME9R0cSy75TC1mg49VshxUJYTThzP5i3jKithqqYmIbdN/4PDHjzI7ixWFVlIMYUVk 6SE4+aMex//MaN2o3CNzAVzs80HUyKDE+e2a3bOqNG+ZUqZuLGj7dQFPd/qLklSSTk5b zaG6xthkfGJmU2ZnF8kCN0tyTGNUJIQPEFuvPL+qS5WsnZNJFusVNAZxHPjr5B2covcg r5RA39kg1lQlp4e5nEr6aaIfu3JK5+/eDNH/zamgeAkFCczk5cwhiVeHaaYUJFqDgBLG AQ8RdU0CSBVoTKwd7V37P6JttnyiXOvoVaZL/75yh4fInvWXGt9+ql5ierFbV5LUnpqo RgyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=+nyFIACTroaWiL3ll8MpLSR1PaoGhCAVsYaEIJjfOg8=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=vHlg7Fc/GCbS2nftShxUuYwf5YDY8Bz1Mzi5bZYhbyv+q2baxnpF1lpMBPGdVLCgSp 0dNwBr1vyt0bPzcp+WBlVSJXg91/9Wd+EY1gKIfWL4+sMF7fs4RMLhOMlQ1afP1gjm33 B++4fj7rZAr3Wd4WufkYSvbo6zWyGU+hX9jYylaAMHC6oHArQeiVUYQCrLg4Qixk68WF Fd7x5Gsmee7owOmsNYLkIOsDrPvrKI3u1dkitGdD3cvE2OIEm8LombxWoTmFbVQgZmY3 dhGNAjUxp3IymTl/GUfN0eoCbNBuPuNxX8jtcEc6RA9czpvzCYAhZYq+vA2VuJRMaw89 BRiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bELh1cTn; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c14-20020aa7c74e000000b0056635572f42si946590eds.588.2024.02.29.16.14.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:14:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bELh1cTn; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 115541F23354 for ; Fri, 1 Mar 2024 00:14:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C1798830; Fri, 1 Mar 2024 00:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bELh1cTn" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3721364 for ; Fri, 1 Mar 2024 00:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251988; cv=none; b=E+HazQQPaMN/SAzZ6isWvX2QdFpk1/CV/UeMtxsCCS+GIV1fW469jsrI3bGecvQa42aFrlnY+Uv/3L7FcrzGyH+v4KsI6uDpO6rp1ni8TBuhqb2P0pkkOXyV7345Bu2Q5lHfsUqtP5qkoIeQotByNONqCH+gCxqZzXk7X/jREvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251988; c=relaxed/simple; bh=plA+/Ds0xvFbb6U3u3M8ilxs/x7ZgpNx1PsraFtKLNM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pe9B5wD+WmvR1FWp/T9PQKtym8X5wqrcQaM1j+LtqikpxpDBYHCadWNolXTw83ZwXEoEgZql56ICxCU96DGTFh3R+DxJ2psWmvKz270UM6aZwvU5VwOcrKPV7wPtzZrQmJxy5noPP76ZrSgnHaEAN1YedT302oVQQD72fzZ4H84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bELh1cTn; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251985; bh=plA+/Ds0xvFbb6U3u3M8ilxs/x7ZgpNx1PsraFtKLNM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bELh1cTnraZfxf8dHy6VCIwRcfxJwFIbKP+rfx9P36tSUl6jdNOa8bfxW+fFHoI4b AXNq+sfqg0CLcRG+1hGv5RyiLTZHEVHEazsZCCTKDuRpgY8mAKwnnFVaJzhdjEfQU7 9PQx302JO3t6shSX/7rjg9Y0noLFaMcqw9rFHg+/EU52m22oKJ2viqQMMTt5NrxTIF 7xForobxy/oTLhbLNT6/Aqb6wMU4kupeYJDyNl1sCc/BZqVv6uJVPV67C2fk+jsko0 itosv+yHr3qgdhs2GtRG1BCw39+AU390RBMuRZLP7EM/+r4gIqsAWRhlq1PGovcjnJ VMl6h2DznZkUQ== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DEA4037820EE; Fri, 1 Mar 2024 00:13:00 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:15 -0500 Subject: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280707034610860 X-GMAIL-MSGID: 1792280707034610860 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Abhinav Kumar Reviewed-by: Laurent Pinchart Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c index b73448cf349d..d447db912a61 100644 --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); of_node_put(dsi1); - if (!dsi1_host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!dsi1_host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); /* register the second DSI device */ dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info);