From patchwork Fri Mar 1 00:12:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208574 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762637dyb; Thu, 29 Feb 2024 16:14:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVGqicUr+GLt7L6/btbf5jpf2ZcaPHG9BbEL2nuHAt2ygZHN1Yv13trqDmqomfH8SOlWN8UTogNtbqo4vbs42yqMLPvNQ== X-Google-Smtp-Source: AGHT+IGVHEnYOfGj4kOV6/BaXBa1Pe3eZXbcSB0qbH29EHV0gzk831qSXuxkVdlypWmy5ni1+J45 X-Received: by 2002:a05:6358:7f05:b0:176:91bb:9600 with SMTP id p5-20020a0563587f0500b0017691bb9600mr41509rwn.3.1709252051060; Thu, 29 Feb 2024 16:14:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252051; cv=pass; d=google.com; s=arc-20160816; b=hike6iHlblEmvDAVSEU+4MB+pYUTMXt9JnQmXskDxZEexodyCjLOkcxIcPCmhmVxuc k7dRirtAuOywrT592n5+z0fJIKVjTs5GX5IIZ4DzVsG70hvE0C9V10wdsb37p4UHY+d2 2O1rhNHUGe0Zq/r9zGUuSSqTuxy8wNTyLARojlEHRICIPG687SieoJ/gaunGIstV8vev doXI6gYVCaGlnL4dEFupUNeslrRjVaIrjliN5emlk42RpmzqtvKp2dSIE1tlfJZj5/6p 9MAYmqIz4qQkAqzt/NEmg2gBRz6tfmQ3T8BS6voS5iML/NsHkrfCqfdfNO3DoTOAKX39 S4xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=OX+EPEkG7V3k8xRDhb2v1k9gcHtjNILHstzSKQIxrfg=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=b742SawnDetq8i+MXJG8y33beKByM0obMNo+bK6M/3kkppgMlQ/6aQz/l60+fgeJ6Z 2/W/K3Lej8yfTwUNvibkr5NZoivOIiyUflT9sV4YqJV/0hghIFYfxtRFykFIIch0Hwsk 2/hHR2KpMbygWFDSymrInXapklA6FXRLN6uoE9qvNqtzufE4Io2Zqu3LcOE1uhBpPjt7 Z/wj9BBeN94Ky3vlH3QbDANFPdTt6Eyatglw6fLDQcADEQGgqvG+Q+NP30OFX/r2Ef+u vxjTRfHAoP3gukAxJCAPGKdZG3tI0JD3z4rZDOMKHpwXw6Gn6fUJVCREp2PlG5ei7Z+G O7Ng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sqzDMqcq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id fv6-20020a056214240600b00690197c48e2si2568772qvb.236.2024.02.29.16.14.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:14:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sqzDMqcq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D15281C21236 for ; Fri, 1 Mar 2024 00:14:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 074EB63DD; Fri, 1 Mar 2024 00:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="sqzDMqcq" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83D817E for ; Fri, 1 Mar 2024 00:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251979; cv=none; b=JHKYJvknHdLr5lZJpNufUygi+RzQ3jrxVzfA1j6HBHA3j/Kbkj0BR8kV+bg8RPbvS3woR67gjQMfK0yRk+ZTBqiJTlh328kQAHuNf/5zidZZohxxMX6SOSrU77sWtWtuXUT4Nc6LqZnun2Q8/Akzfx4o5/2e+CubHpcoFIK5Em8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251979; c=relaxed/simple; bh=+CKVPsOP7VaA2gwBWrP4ZLU4toVT2KatRN6rysdk1vs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rTpEv62EyJzl2oJIgKCvOVD0GWK36sEPRXMFjy/+N/bNM95Hj+ETTQg1omF/f/8oQq/y01s6ICKL17l2lniZ15blQ8Bgn39zR5WaB1OYcOUeOhhW5A6LUQi5m/B2R0b7aYfR5B3PoYH436nHN0pwTMzNNo8mQV2p2YrBV23MnDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=sqzDMqcq; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251975; bh=+CKVPsOP7VaA2gwBWrP4ZLU4toVT2KatRN6rysdk1vs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sqzDMqcqvD5UoN64HHW3ZFjlCUvz3hvCdeFOV7qiY/TA6mxT6jFofmQOe+9wpnpC2 qSQmKmDrFaMnCq6HWcGMoKcZWWl+nZGmELERlI2jXHRBgMt0ZdsHVRYglcwhIqciV5 pIaHj/AMt9oBdFNsItzChDdshlRhwaUznS4xcx+xi2rO76sNGk6i8QBhWTryMyfckY /sF9/hRXyJmHNkxzyFcOL4HshTOenSegh/A5CrV40SiV0auGJRBtxq0oY/tY5zIOJL Se+bbt7fSzbcSJToyRyC7BXxbvCB/8V2wYaSPs+vGR2dDISGzAhi5xh+qPvM/Ku/LQ BrhfJcPqdEteQ== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 5987537820D8; Fri, 1 Mar 2024 00:12:50 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:13 -0500 Subject: [PATCH v2 7/9] drm/bridge: dpc3433: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-7-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280679069752711 X-GMAIL-MSGID: 1792280679069752711 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Also move the "failed to attach" error message so that it's only printed when the devm_mipi_dsi_attach() call fails. Fixes: 6352cd451ddb ("drm: bridge: Add TI DLPC3433 DSI to DMD bridge") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c index ca3348109bcd..6b559e071301 100644 --- a/drivers/gpu/drm/bridge/ti-dlpc3433.c +++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c @@ -319,12 +319,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) .channel = 0, .node = NULL, }; + int ret; host = of_find_mipi_dsi_host_by_node(dlpc->host_node); - if (!host) { - DRM_DEV_ERROR(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dlpc->dsi = mipi_dsi_device_register_full(host, &info); if (IS_ERR(dlpc->dsi)) { @@ -336,7 +335,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) dlpc->dsi->format = MIPI_DSI_FMT_RGB565; dlpc->dsi->lanes = dlpc->dsi_lanes; - return devm_mipi_dsi_attach(dev, dlpc->dsi); + ret = devm_mipi_dsi_attach(dev, dlpc->dsi); + if (ret) + DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); + + return ret; } static int dlpc3433_probe(struct i2c_client *client) @@ -367,10 +370,8 @@ static int dlpc3433_probe(struct i2c_client *client) drm_bridge_add(&dlpc->bridge); ret = dlpc_host_attach(dlpc); - if (ret) { - DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); + if (ret) goto err_remove_bridge; - } return 0;