From patchwork Fri Mar 1 00:12:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762527dyb; Thu, 29 Feb 2024 16:13:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXlVArxCSBeYcZYJoK5sJQonPJ558FQXKbatuGrqR6WYIROViQUSTvx5aJtRhIPa/sT5c+WOuYCHAvxkDkcLjS4U5PJHw== X-Google-Smtp-Source: AGHT+IECeebNlqTOTPaxKubyFd+/O+dGw69s31h20eKjLmJom46JNES+JMkenohC6ny8DBsaG0cp X-Received: by 2002:a05:6102:3907:b0:472:7448:e0d6 with SMTP id e7-20020a056102390700b004727448e0d6mr4705279vsu.5.1709252037934; Thu, 29 Feb 2024 16:13:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252037; cv=pass; d=google.com; s=arc-20160816; b=iVT/5V67CqKoKSs0bo49GCDy2ZbJxcMC6k4i90S9DMs+qB9Dduc7Uo2D9scQFBEUGV RK0ptE+dlfkapEp1xHWMGTSlCBU4qa1q2G+pYGJDXEJ95M22NbURsxPOMoRvhhH9L+fN tSamVHjccuv6NP7kvVCsFa4SqGfFUmTcB3scaVd5KWrsnU9oxTZR1EiXm1xigBpHknjq k7TIuj622Kx54KGYY9ThqyGpIpfl1oGO+iWwkGO2cnSYzpPaHE//FB7rkWWhxDaXz0ek tdvj7R8xFwZHf/HTdRluVWJJmLZEWKs7+dirweBdBKmIZqqYnh+Yc8hI7Cpy203CaK7e Te3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=+lH1Z9tr6pJoBJRmRqGieCtYKJd+EPWt2KYFlbc+blI=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=FdM5CzsDu8lCAdx02evrevXtbA8WR/MWaUP/5M9D/vX+J+1P8D5q4OBgBdsT1C3GZd 5/F1vEtP3XG8nC6/KYG6w0HHas+zpPTGBfO/7dZir3Ebr4MYB8D+ZPg7nH1vDjclXlAm moIMH+2+FJS3MUj/94ubz+eLJSjQmq/08QiUcHDEB893OFZj9Rv3a6+z3TnyCpD2dQVJ A8anierFlquDCyP1osDMmiQwH82Pcror9rTAXkNU35k2kOJlrsd1KOyvemaHSCjg7HyP jfzu9qVKmsSbR7XdVDHW5v+9dFc4TmvI1eALoWpUkC1p8u6E8rGP2sWzlTfhf4w4niF5 M59Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=U5WNUS2Y; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w17-20020ac857d1000000b0042e5ea3ce75si2682110qta.378.2024.02.29.16.13.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=U5WNUS2Y; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 92DFA1C21151 for ; Fri, 1 Mar 2024 00:13:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81CC54A2E; Fri, 1 Mar 2024 00:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="U5WNUS2Y" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620254A20 for ; Fri, 1 Mar 2024 00:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251972; cv=none; b=IS6IAaxyizhB+9ZvTEQe531nDI7H3agOBIABoqBtu061iMBIjSWlTKKJqU+k5S1f6SntKaP75yoDyB1zB6rF+5xfBOInAM6hkpiMPREJ4NQza4jwrfyLVKFB9uAhZwEizzab1C1nWWiaw+0Wf3HfVraqnkgFSCSqu2v6rxRdihY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251972; c=relaxed/simple; bh=x6U7HBr2+APn5ZpeLNHOIRw/a7yOuDvPI1HGkDefAI0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JTySUHP/yviT1/sTxVsKIFhnOrhKnhID2z9m8H/g2udHE3e0X2yKcbdiGINoumSC2vO2fXPYcc/4ioxIyHomQb7H8N039ii9nDulXf1gKKRgPJv66FB5HlqAobFMzyKRnvGh8UktLyeY4Duw6BF0TCPSM7iM2IOoDN76qozMVQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=U5WNUS2Y; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251970; bh=x6U7HBr2+APn5ZpeLNHOIRw/a7yOuDvPI1HGkDefAI0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=U5WNUS2YRX2M9Wm9IoWrVZ9o3oKmM9fqRzZeP0ZusgHofuUBWc5bPR92cN0XGwmQa 4Q6qDeRML0MCbRFxg/De9Cqf14L73Un6+fokUNKcPQi5YZfQvziUHwyds+ZQSI1bpo WtPkOKmL4d4CU7WUXN9A1Buz7yG4SaVEAotkZgTBtCVUbNAK+w191RJpbZsiVM+9ca TyEhsr3xRMYGNWkbK+1yQk2EKjCtJqqHCzMbilHW9/HiEPBS0aq23OtuW4NN9J1q6E QbN/bzaOQv17U+DNmzWWOgnW74ciL1YZ6s/KMPHGQ2i3HIBORWIXqPZE0oGgUAUuJM twcOyHfO9wmuw== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 09E8D378000E; Fri, 1 Mar 2024 00:12:44 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:12 -0500 Subject: [PATCH v2 6/9] drm/bridge: tc358775: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-6-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280664731810019 X-GMAIL-MSGID: 1792280664731810019 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/tc358775.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 90a89d70d832..fea4f00a20f8 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -610,10 +610,8 @@ static int tc_attach_host(struct tc_data *tc) }; host = of_find_mipi_dsi_host_by_node(tc->host_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) {