Message ID | 20240229-anx7625-defer-log-no-dsi-host-v2-2-00506941049a@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762134dyb; Thu, 29 Feb 2024 16:13:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCULNoNNzf41YTOsVIutJ4iQznOscP3V8foWeeZCsN+Kj5FtTpTqmKI7OpOPNoLZtaPNdsMOv/Hk7DxwlogR4Mk90L57Gg== X-Google-Smtp-Source: AGHT+IFxtQ/5BDyHqIQF8+B9wdqSHMHixLhQYfGWYoQggjIRpFq9P+9/eU9cZR5a/fZJ1AgDmaZi X-Received: by 2002:a05:6a21:3408:b0:1a1:864:65bc with SMTP id yn8-20020a056a21340800b001a1086465bcmr4943520pzb.23.1709251985122; Thu, 29 Feb 2024 16:13:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709251985; cv=pass; d=google.com; s=arc-20160816; b=b6FXlu+LLQ5ywKT2XA01370nxlqQz4QDxhOLkXg+giTHNMa2G+1OHl8V0ZiG/gEmzJ 9fLqZS1O0d0bVKrcOQZBiEMpquub04V88YjFLL4CrBiqWq6wUJ8uv7CJBd/EjFir9+Ex sL7TmWFJe3eIw1KUOLK+Fz9prRGcaLFBvTIKUxbMV73e3J4rhcr4A5lF0347OkHAlyU4 X8rszHzgmTyW76BJmQsZBmAbIFV82y2KLj2GmNioU22ucmWrqLLSR/fzNKVPDVrYoQua 4paAzIO6fhedKNxXlE2Dwp/lVFFpASaeVm1tEdvdTk4STEQpd1xRCGnKa+5syWbsPK5w P2iQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=zmfQvIHA4tHKGsRvlhQ4r1otCVltUoomSwpbJvllBj0=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=ZyvuwWVd3duKEffWlMazYV9HzHI0JXpqp5SG8W/Lvsj+WgsQaY/EMBgSQko3jwR74L mjfcWQM6dQLH1iPfoO4CVhXcLDfRYDbqtfK71SCwZhkwPrcdcU9ZI2ofg+UVITNtzTiM 7SgVe+jzX3+b6OiXr6EJzb50gYCZLIEa6Y3xwGSeq70HnHxFemU80aZSrvwhPTgSu+eM 9cTYJK/WdGXkQdOz3VN/UWA9usiJbm8DmDW2CuHOwcJw8WPzOEvxXaW+YAHKt7wG8SX1 rcp9RKmj841h+++YG1A/aJh/myl819ynCDx9h2xYC+zqMufrczf260bpcgGK0nIpt850 fwgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EJPD0bSu; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h6-20020a655186000000b005dc4b84b38asi2356295pgq.72.2024.02.29.16.13.05 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EJPD0bSu; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E691D282759 for <ouuuleilei@gmail.com>; Fri, 1 Mar 2024 00:13:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A3CB82566; Fri, 1 Mar 2024 00:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="EJPD0bSu" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853B21FB9 for <linux-kernel@vger.kernel.org>; Fri, 1 Mar 2024 00:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251951; cv=none; b=DTH6Reln5l5TOU1aYojA9MaYxd/yyYwTT+ldnPaMLXnQSJDTgKjhr3HKuoNAW01Nu1N+kONO79xHIGIrvct/INPHv/OmoxPjsLVQ4oiDtFiBoEpqg11QKCOq+SBkzifixjpnKU7lNuq8B3MxHbCdNh2ODPMNR2o4LgPVbSYqsO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251951; c=relaxed/simple; bh=gnT6fVbzwGxli2Y/mzqkTnDg8570zOrbc+nwHaRR3vk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M91olaCSW+ApQ6ntMZZa0ayq56jEhzqYz/EawagjfjkyQPDoVYC8WffySPe0hf9Q5/BOwBNBZOmdBTZG1MrvUajpzkLPKi0SAmuZ3Yv6qVKaZYwo9Wl8EVieTr9Zmtuom6IaghQ1y/o8icx5rZy0O0hv+tAzoOxyKuNma3HA9QM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=EJPD0bSu; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251947; bh=gnT6fVbzwGxli2Y/mzqkTnDg8570zOrbc+nwHaRR3vk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EJPD0bSuCixJT6fY8/gLwi/Fr+UYpNod4uZfw2eAXxkQkbdiJ9XVQvnlzO0gTomxk IgF8iDGPhmZsvqLVaamRP9kf84r/VZtfn1qPnAL0v9GgB0HmH+9K1JVcAynmED7xMh ySOj2EmBuIuQcvBmCbti4lh1EAGne009cw+QwqORex2vndvoXh5l6UWYQ0tRNTK6ck j5PNRasF89dtlTJrOgE+L7h1A/y5i0U5D3dAOtwZ8d4dahWTp4NkGNxZCqNRV1juGc CUELRpn3PUqYiiuHClJxJgO1SdE2FOhUc8Xz3Ri5TZvFDeNPqH8RcjTFg3cQ17wF3a FFeExNDQ7bzfA== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 0007737820EC; Fri, 1 Mar 2024 00:12:21 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> Date: Thu, 29 Feb 2024 19:12:08 -0500 Subject: [PATCH v2 2/9] drm/bridge: icn6211: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-2-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, owen <qwt9588@gmail.com>, Jagan Teki <jagan@amarulasolutions.com>, Marek Vasut <marex@denx.de>, Adrien Grassein <adrien.grassein@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Sam Ravnborg <sam@ravnborg.org>, Bjorn Andersson <andersson@kernel.org>, Vinod Koul <vkoul@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Vinay Simha BN <simhavcs@gmail.com>, Christopher Vollo <chris@renewoutreach.org>, Jessica Zhang <quic_jesszhan@quicinc.com>, Marijn Suijten <marijn.suijten@somainline.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280609774238790 X-GMAIL-MSGID: 1792280609774238790 |
Series |
drm: Switch from dev_err to dev_err_probe for missing DSI host error path
|
|
Commit Message
NĂcolas F. R. A. Prado
March 1, 2024, 12:12 a.m. UTC
Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.
Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support")
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: NĂcolas F. R. A. Prado <nfraprado@collabora.com>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 82d23e4df09e..ff3284b6b1a3 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -563,10 +563,8 @@ static int chipone_dsi_host_attach(struct chipone *icn) host = of_find_mipi_dsi_host_by_node(host_node); of_node_put(host_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dsi = mipi_dsi_device_register_full(host, &info); if (IS_ERR(dsi)) {