Message ID | 20240229-anx7625-defer-log-no-dsi-host-v2-1-00506941049a@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762038dyb; Thu, 29 Feb 2024 16:12:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV9dlv1M0iipoQO96fTWwD6Z7KvQgV+eqi0/do7lO8O9bMQ6YV3tMo7QI9IGKwBHWhVao8vSqzZkZBbfl6D1NGAWgjabw== X-Google-Smtp-Source: AGHT+IHpm2T+hh8J8YV8+/HBm/b1wqIczt1QHqP8OLWLv0KNBkDLkVMe0u2IBKu71kezG80eww2k X-Received: by 2002:a05:6e02:2148:b0:365:1fa4:1b41 with SMTP id d8-20020a056e02214800b003651fa41b41mr314464ilv.15.1709251976840; Thu, 29 Feb 2024 16:12:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709251976; cv=pass; d=google.com; s=arc-20160816; b=T3S6rh0W/HhdPQMYMwKWr4Qn89hYfgQIVBEXndBtJ2EH+qCn5SZ6XpC2gwxoPKWAYE ueq5MYkeDWKhJz75hutBCfrJVCaDXdd/WmlV7s9MGjjbHdsdmKAQRhmuBY+LmlycuFB0 rKdHb03qlgcvuTfSE0QcH2FpnbFaPrdLs8NcClwfRKX4GwPTKpc+hMJtjaMMFL9f5u4H 8nRyMvlnfJ93xws7UcqBETC+/+3B4JsvZqaqWfP2FDIKVaWZppkmzcKv/9pYyXa1kLP7 wUgTwjQUZcmV2kcA1miy5JLAe8CTUE1x2IfcTIpwRx8jVgEuPgqfm24V8coj2CxSOZj1 SLeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=pbSR6z7X7zwoXvEIFGqDTz5WDrvCCQcbPKp/I7kPm2Y=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=Ej/DjzZLNw4DrtTzF4VHk+GF1j2UhpeIYb4gzvjy5SIrgMp+f7BxfyDrhYaeODKoNX bRmKfJq6AXPfLPjLNBNoCwGqsSiWU1Vhmpx/uxpj+iN9GQMeRUQWtL15YFMF5gHqiNnB G3nP2rc71yXhYnopYL0ExdHqBlpC1DzWK37wPNCbpNv27IGqMn5GfooSLZ/jWVnbdeyN p9/K4Xxk4cIC+/K3UA5u/EWh8SNjwbZX2uqM1ePfy5rZe1x82c/snyRx8TqwWcZsnAqk LEgxx2VQbjS6lH+k93OM54YV55p5MSceQ05YJ+ZqyaSgTDPzeMwpIlCQ3AoC8x3x/Hya UC/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e8JXK2GO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c1-20020a63da01000000b005dbe2220330si2435111pgh.171.2024.02.29.16.12.56 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:12:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e8JXK2GO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 382ACB20ECE for <ouuuleilei@gmail.com>; Fri, 1 Mar 2024 00:12:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F7C117D2; Fri, 1 Mar 2024 00:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="e8JXK2GO" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFA417E for <linux-kernel@vger.kernel.org>; Fri, 1 Mar 2024 00:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251944; cv=none; b=m1G1d5fFmFha8LqwSq+0rnWqtqxMFbiCyXp+oCWxiZ2HAb22qjmX2jxVmZqSM6UzNfTzEh9y4i8E6e7+vswCG2HSjFNZvWWRVhYq0tEH04ZSHmzKojhLVV5UYDaM1+TLAVGAHQS4dkuDJkwrh67TjrYb5So9iO0ZLlZx1xvWLjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251944; c=relaxed/simple; bh=iUKjpcxm8TFpwUzlmp7yRUbrK5h61wBPcr0xFrIbQOE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XuhXsH3Hv+9CuGTa0Qn0f+Cas05pQJEGjOUmcnGWuel3r2k7jHSwCc/agOeovKhQwVLP1Qyu4qhTn22rnpYzSfk6yHkZlxgVGS5TlOuW7cOn34YgVvc3shwfJtq6Ty+P/6ZVF8JkJR7C9gwz6UEe6cZ8yS5g2LYd31fXjdPp+hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=e8JXK2GO; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251941; bh=iUKjpcxm8TFpwUzlmp7yRUbrK5h61wBPcr0xFrIbQOE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=e8JXK2GOsswG8I8J52YRL7iPEzLNsC5XsWsDNXpEVTibaB1WMH1dL8YIf7J9QsSSk NnyQRDQ4DyPxjUTIYaKL8rFl++rl880Sz+WAj9FPgeNqG9K0HJudCCHcy3K6TaZe0G Djwp2AWiUZcXVMe0BSlk20atDAYYMsjFE78WNuExOBNqKnYsBgByOOMu1+eIIq8SRf qa982cgqHWfMo3Xp2Ng1DUZkrQtPjATv5/RLnzS5whCqUVXYzQluP4DEkgApLOBslS uON8t7ObVdJYg+AIe1+G1gc1/nASEr5j3d48YeHOM3l7opZx1tAcoMsGcgYdQB4jFR A82h3nhp8QT1g== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B813E37820D8; Fri, 1 Mar 2024 00:12:15 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> Date: Thu, 29 Feb 2024 19:12:07 -0500 Subject: [PATCH v2 1/9] drm/bridge: anx7625: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-1-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, owen <qwt9588@gmail.com>, Jagan Teki <jagan@amarulasolutions.com>, Marek Vasut <marex@denx.de>, Adrien Grassein <adrien.grassein@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Sam Ravnborg <sam@ravnborg.org>, Bjorn Andersson <andersson@kernel.org>, Vinod Koul <vkoul@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Vinay Simha BN <simhavcs@gmail.com>, Christopher Vollo <chris@renewoutreach.org>, Jessica Zhang <quic_jesszhan@quicinc.com>, Marijn Suijten <marijn.suijten@somainline.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280601140427510 X-GMAIL-MSGID: 1792280601140427510 |
Series |
drm: Switch from dev_err to dev_err_probe for missing DSI host error path
|
|
Commit Message
NĂcolas F. R. A. Prado
March 1, 2024, 12:12 a.m. UTC
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found") Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: NĂcolas F. R. A. Prado <nfraprado@collabora.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 29d91493b101..4ee5614a2623 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -2076,10 +2076,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx) }; host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); - if (!host) { - DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) {