From patchwork Thu Feb 29 20:58:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 208522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp683016dyb; Thu, 29 Feb 2024 13:10:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU3Obj46S0mVHwWqnyM8ela5Xf7BHMglt555qmVJ9j98KjB7B3gjTX5EIDOW+al7+hfpYTLH299h3umS7DN80TQKc1Kcg== X-Google-Smtp-Source: AGHT+IFm7kcJGHmYe9f3qKf7otcjpRCBWKyQVHGGZyrpAL36eO/zZONdouAJT4ccAFbM+9Q0OJ+z X-Received: by 2002:a17:903:4c1:b0:1db:729a:e2a0 with SMTP id jm1-20020a17090304c100b001db729ae2a0mr3134218plb.47.1709241023838; Thu, 29 Feb 2024 13:10:23 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id sd16-20020a17090b515000b00299d1159bfesi2213591pjb.185.2024.02.29.13.10.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:10:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87548-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=Ne4H88wq; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-87548-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87548-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 949C828E9BC for ; Thu, 29 Feb 2024 21:10:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79509157ACD; Thu, 29 Feb 2024 20:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Ne4H88wq" Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2040.outbound.protection.outlook.com [40.107.7.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81FF156961; Thu, 29 Feb 2024 20:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.7.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709240345; cv=fail; b=h+4ouaGnafWFdQVFKFswxatOpwMKlpR7lqj7hrw1g146UhRuxN3opJKcQMiyrFeOFamjQjWgXJZXPNKah8peEXlpNH87VEnRnwcCWyhea/3EkYiGTrCJd+Lhs6F26ab5/OVG4dvU6xsbA5kM1KSF94i24qOqvV3mvH7fMn9Mvwg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709240345; c=relaxed/simple; bh=Cba1I8lPfT7XGGJBLhHLImkgVygTholVVk8WsvGvZuQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kUapWTDxxaYjomNzGdi5oCYSkVQHNE1VyXidEA/rs5Xcqz0g5sG8CgYUQWBK1oNW65Pebu+9zG1A1LlknFxj/w5Ma+Au+W1dMgZz2pYClRWTV/e24fvRDFOzpeoXzH6KmPkWWAKTgFgHB46DpQL+b+hkc7luLmq3CT/2CEiXu58= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=Ne4H88wq; arc=fail smtp.client-ip=40.107.7.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JNt5GWHW6EkvonoxRSeAa7uQwlE226Cow3djnuL8tzqCNdohj2kVT05vTAAIkL6xNq+Yb8h5358pCiNp+wBLDyv2EqXniVp3iEMIBPoJv6+WnIAuLEaJEdSuUPg7qylEB2+rFQuVCALxk0C72YAdcV6nvMvug9DAFXH9BjCU7yHGwfRDPGUn82X40nSlxSTWmzk5qzbcYFhbXj9AVCtwp3tlmuTzQ/kGQ2dBnD0Bkej5t5SlFWQfFKPyCMIJtcdqKaatvt9VqjJR/vkpJJJgIthFMGIXFqIXqXvuX4JwZJQIvxz+Ysl0NuMu1uJNPP5s5hv3/EDcMK3vpLLPyoIFAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLs/58IIUeveyfmtV9PhDz6tUG0OWzPy+/o3nZ1cyIY=; b=UBFb2nG92MjHAO1PDhy25voNbUWnO6xhtnYn/xXJ7tnaComSK+vyqj4/hvtTruepvhM4XTeaKylt7r55Eq5Rto65nCVpcuqB0BnF5nmbVyiHyZWQdxMRw7oXWtmked1+ZN6vd7Khxib7DSqIz0gueFpAYwbBpU8mh75X6lRMSHM8I5oT4hNEcUdCMozbYKyPI3iXbpXvGD4cw3rS/N/WfqhKRXDNhvqHU7u3Rn9WNXMdy/1fYtujzQNQEA070MsNKkLj31z7D02E4237kpznU6pcDDOvlW8KbPO2G3shTMgRTYt2AnuEsBIT+nK3zqfVsoPF8sVd/uYuGhadKW3/wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLs/58IIUeveyfmtV9PhDz6tUG0OWzPy+/o3nZ1cyIY=; b=Ne4H88wq+HHzAaLsUgMy4hPY12leRmrxVoR/EtPkFlVD1EbmbL1+XrNMgLQupkB/eEit9QZy/GmpK+Kac43vVAjnhRWoL+TUVPgcUJnXtf9bxymf4+LgmmHaK/gzeDj4Y93PTNU/sLlNfottIeywCkuhcMiFWaiBh6MixHWKOtU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8750.eurprd04.prod.outlook.com (2603:10a6:102:20c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.40; Thu, 29 Feb 2024 20:59:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9af4:87e:d74:94aa]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9af4:87e:d74:94aa%7]) with mapi id 15.20.7316.035; Thu, 29 Feb 2024 20:59:01 +0000 From: Frank Li Date: Thu, 29 Feb 2024 15:58:08 -0500 Subject: [PATCH v2 2/5] dmaengine: fsl-edma: add safety check for 'srcid' Message-Id: <20240229-8ulp_edma-v2-2-9d12f883c8f7@nxp.com> References: <20240229-8ulp_edma-v2-0-9d12f883c8f7@nxp.com> In-Reply-To: <20240229-8ulp_edma-v2-0-9d12f883c8f7@nxp.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-c87ef X-Developer-Signature: v=1; a=ed25519-sha256; t=1709240333; l=901; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=Cba1I8lPfT7XGGJBLhHLImkgVygTholVVk8WsvGvZuQ=; b=eaadin1fbdghmp6xGn/H3m1Pugw5hEkckIlpOSy42uL+blK41aoNXo+cWWtmHWxtxeeVdCNrY P9wDkD0PQNnAJZnQW7NCsmOskSg68yEPwBJkvTJT8EDCiMY+Aa5Fi22 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0060.namprd13.prod.outlook.com (2603:10b6:a03:2c2::35) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8750:EE_ X-MS-Office365-Filtering-Correlation-Id: 4df85db8-1c80-4b96-b826-08dc396941ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 82KbRJX19YCs/sQ2tgOTy1b8mIiGLlHxCsctJ0VBKuxAuSVB167twS5l+fffPavd/SSchbb5wooLfvevnxpyp4RSyPDnjnHyj59/KKL1g8chXD256WDwsIJaMX5G5pLNJFpLQds2EMaUcLB8sRJDDipfEfIi7F1YC77WzC24FSokZziMD+76Wo4tcMNYlr7QcjCXDfM7pV6sMFXsXhX7tY16uX7Gn4asDfOXtJWr17r06MoN5qZXb3qBLLf6jhCF1mdzIsAG0JBY7gpop6mO6WZ0X8QID+8Dr2n5dwGUBHwpW5w71qF0JN5NB5TOYuBroTfq+feTqrzVBz+UR0+E4bLwtFoynP0IW6gesUcuwt7MpK3XLPwp2ryfle+vM1u2XznYJp2uYuyXsOzrNKxf4i7W3J4kjRYBSu+RCt1Q5o8z2+wa1dFHrXGIGpCToPS4IB06sJsKVuUST3WWKfK6WLP52ggX+RspDuILgkDIjZ/TLw26VmlaHELuxPvZeAiTppi2ZINi36dXugbW+17+dLtByYcfT/0sCZDTCq9Q9IRyjgD2CkegrTvTKuB5rktr/YkWE0vDG5qbW9fFfQnyhGMs+dhr82lP2dX2psHIvapvb2Fp6Kfj0OVMOX8mnLEGDZYpKA7KGOSFXLMNUW9Uo9K2AkOCUyXeLobPJA/Hn0ZCYvTrdcmLHS2yrSHfETsLYCtkXY9//NQ6illH1atoyP6uThRcOWVoumLOxXTHxd4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?jOkvYHk42z2ZGIbBwxK20FftOFFl?= =?utf-8?q?5b/BEgfODIoEnyK3oauto5zRH2fFk6tFXLCmP59WaOp6E0lPDSt1i9IwMomcXK/op?= =?utf-8?q?y9tRJ6joDkhbybfbu6HKvHKQYqfSRsLmquShg+oIdm3+tBpbOHNfq7WlBO3Wm9lUT?= =?utf-8?q?OwzTSfwjfo5F3pDKE7FYeHgqutw51ottGcWq6Ua76aLwjVuMjUSFbNDAK+fjnTjwn?= =?utf-8?q?arhkVp9WySrReRMLbMAtckvECAh5Y5jWTBLWQjqreUTEg1wRoo3Cq98Fa3ytmXnNW?= =?utf-8?q?4mSMGVodD/0FPBzD2exZHezYPx+FsU2JYxOtrgG0bGyUQr2FxGITGkoM5NsC6FkIJ?= =?utf-8?q?YIcHmyAPU8EZ+5lq3x4xzEHaQBnTfc4YF6F/D4ROb9PBQq7NV9ZjqHWRIJXEUR3Ho?= =?utf-8?q?fnGXVBUns+U3MbZQEvj3zCyul/Womh0UZO4Ydj2pzo77SNpfes8WgNIRs9e2IydXA?= =?utf-8?q?nRuXzvhVtoEX6hW8sDv2Ib81EK4mUdkVuHzgKDpmbaNvTwIvUImm0gDSixy0NnJaM?= =?utf-8?q?oEXz43wj6twdLUM/A5TIOLhqHGsVk8lBj5ebjwHnL4HQprpFYdtSz3TEPADFujyeD?= =?utf-8?q?mUdKD4Lwe8yRqyxONJEUHi4ngnnCH5ue39+Mxsltvhne14plLFLzkESzD4s7z9/A6?= =?utf-8?q?5Y93Hd0qbl6snuTjCBplquO4wzFtMdkzqM55W4o1evsToajVjTPGPz0cTccRrAJrT?= =?utf-8?q?dGdk8K2U2oXovAxDdwsJG0MfrrNkEp04dhfb+0Gt4vopeVMHE33c0phbAayYAL+4/?= =?utf-8?q?whmUbeXhrirZ5S+K8PHU/rNS0Lxje2WjHe+OpTchVi8oB0BDoG+sTOD6i075I6NME?= =?utf-8?q?bIsn9KTWzlVzCofg6xxOJsoIiDHegNeY5KkxFV8qFceMMSf3HMTyC9QnxZYgka0Ot?= =?utf-8?q?jIWBDVtuHDEFlUYK0mgit+02Bojo1DkfWxJYTXvz8BoOtFuORFpzkrJ2OTJiC2WCs?= =?utf-8?q?DtBWhee2ZQkpmmMZg8uHYRTUyrhKKMkuzWT0wmOg7W1iZo1uvDG0b7hA1JCPT83rp?= =?utf-8?q?auPfIoLndJARGDQwBaOXvnl11LQ5oGvzPXvkP1LraJ02PVoTzgIhURFXmeLj/rYTn?= =?utf-8?q?yn0//iHSnNbP2mRzC+YUcBQKJrzO6nNQIN46RCZBe41InIVBkbEalB/nPOu1BIYcr?= =?utf-8?q?6nLNO+mGytQDLr69IpDyM6t3yUjAs6XEeN7PGuIu8JGeewU4LVuToz9F7ZmwQZYMs?= =?utf-8?q?OVTXkF7UHGCcsy1YtUnEfeCbvKwVA6jNqq7a+6cu0CJtIQBtR6OfeidY+g4nK65PE?= =?utf-8?q?GzDblfsdwxASjEk6pGA/N9r/wSkUubN2P0xxEYh8psNFa7MrtP66Zspsfo0MM/d6z?= =?utf-8?q?LUTZecfh5U4w2UxRYytDHWmi9Xpa82JSWsGsSeSlzyrTxhxYeG7/fvC0gcwM3YPiu?= =?utf-8?q?Yf22bCgGbfvV7+c4zEkpyVKIyPuDLOJ9PDjfrm6y0tDQSydikloT3BFo0Sxtr40Fl?= =?utf-8?q?OSPs63DzQ9ifgxjUD0PMbfv+Qr17ndjnFOPA7LXiou9pcOnYozqf9IAdIsuV+3lAW?= =?utf-8?q?wAnhOEY4bNxU?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4df85db8-1c80-4b96-b826-08dc396941ae X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 20:59:01.6821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MyxlTfKv5aOYjwi7nPdb7T8cHq6mK1AJbbYr1nRnEl7uBAJUNz7pJnXY2sGgpVFkA+FUGEqevRJlqAaq+HpNuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8750 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792269115458811915 X-GMAIL-MSGID: 1792269115458811915 Ensure that 'srcid' is a non-zero value to avoid dtb passing invalid 'srcid' to the driver. Signed-off-by: Frank Li --- drivers/dma/fsl-edma-main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index 0a6e0c4040274..2148a7f1ae843 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -115,6 +115,13 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec, chan->device->privatecnt++; fsl_chan = to_fsl_edma_chan(chan); fsl_chan->srcid = dma_spec->args[1]; + + if (!fsl_chan->srcid) { + dev_err(&fsl_chan->pdev->dev, "Invalidate srcid %d\n", + fsl_chan->srcid); + return NULL; + } + fsl_edma_chan_mux(fsl_chan, fsl_chan->srcid, true); mutex_unlock(&fsl_edma->fsl_edma_mutex);