[1/1] dt-bindings: interrupt-controller: fsl,intmux: add power-domains

Message ID 20240228213808.632603-1-Frank.Li@nxp.com
State New
Headers
Series [1/1] dt-bindings: interrupt-controller: fsl,intmux: add power-domains |

Commit Message

Frank Li Feb. 28, 2024, 9:38 p.m. UTC
  Allow power-domains property for fsl,intmux node.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/interrupt-controller/fsl,intmux.yaml    | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Krzysztof Kozlowski Feb. 29, 2024, 8:33 a.m. UTC | #1
On 28/02/2024 22:38, Frank Li wrote:
> Allow power-domains property for fsl,intmux node.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/interrupt-controller/fsl,intmux.yaml    | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> index 985bfa4f6fda1..d73d9a6c50a69 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> @@ -37,6 +37,8 @@ properties:
>    clock-names:
>      const: ipg
>  
> +  power-domains: true

You need maxItems

Best regards,
Krzysztof
  
Krzysztof Kozlowski Feb. 29, 2024, 9:50 a.m. UTC | #2
On 29/02/2024 09:33, Krzysztof Kozlowski wrote:
> On 28/02/2024 22:38, Frank Li wrote:
>> Allow power-domains property for fsl,intmux node.
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>  .../devicetree/bindings/interrupt-controller/fsl,intmux.yaml    | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
>> index 985bfa4f6fda1..d73d9a6c50a69 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
>> @@ -37,6 +37,8 @@ properties:
>>    clock-names:
>>      const: ipg
>>  
>> +  power-domains: true
> 
> You need maxItems
> 

And explain why. Most of your commits lack that basic information.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
index 985bfa4f6fda1..d73d9a6c50a69 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
@@ -37,6 +37,8 @@  properties:
   clock-names:
     const: ipg
 
+  power-domains: true
+
 required:
   - compatible
   - reg