From patchwork Wed Feb 28 08:32:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 207702 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3210147dyb; Wed, 28 Feb 2024 00:34:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVZsfsQnmuFN1bv80Xzicb+yVmHuNl3TlXm1JOpfP6OKxE1CoTjekLamUBkPGHRKd1kz6Uf89ojmMjpJXOnP0CCHWryzA== X-Google-Smtp-Source: AGHT+IFkr8Rz404PtCFeIclN7MY/tn6AXuTfV6B4dLoDHLslRxB+VN5ujyPZlJbYL3SJ8UjExHKr X-Received: by 2002:a05:620a:3990:b0:787:f1c4:fc69 with SMTP id ro16-20020a05620a399000b00787f1c4fc69mr943453qkn.9.1709109292990; Wed, 28 Feb 2024 00:34:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709109292; cv=pass; d=google.com; s=arc-20160816; b=h53AuHuqTaluNPtZ+80I7s8gAA/GWJod8R5T0Aax8LAdO8Br6dBCWYK+7NN66ej5ys biWZIQbp/yQEE0zxMIZ/0zNB1PHuXFCdZohBs8kVgnboGRuz9jYdDOwtspRYH0ZC+WPD 1AbIdobQ+SjjKC9OBtLlONGQWXBt0UaeP0VillZqzJd/1JS3ZIl7la+eNfB7JUHmnduv ZXR3FoFRuVggiE1ev0tyTedS/re227Yw/lXSz/JdmEt/1UKldBHEgU3qgHev6M5xgTkS ERNoUteuMbkQh89Kncfech63vhLcldk0o8wbLpOHK3C91SVkM/jri5zfDUzI3l7lN28q 0PGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=hqHO2GEYl7GxbzESdMYs5ztGHyZiF6bQIqtKeXOQESU=; fh=mA7hbESg/ihMkEnrB1KS665ZW0wCWqfiZSznSnEj3W8=; b=Mkq+WsnvOLLD4LgDQx7RBav78MJjGc0YG9GALmm4owEx8dGvS+8lNc0caSSG2afBRM nASIrdzwT7U5iOp+KdhODnJtGBahxgPfnA27cxF/b/v4y1bvwOiQlMwIk/rkELzRByXS aMUhcBLgBy6RRJdgKm0/Tf/40X8A7j7gfMV1Jvc1xAxgzuq3t/DMusLXmDFY6uJEb8JQ m69/w1c7Af+8Bc5FqBbQI14A6En6kZ9X5O/WCB6Y7bIGDEjoL2yVWa+6u75FE6xi1VSw SkKzl5UGPW+8RPqLt+5rzHiKylV6jbvfdNwfzSI4IgznOfNG3wH/ySvRh82ENdKO4ouo tvdg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=ImpNt0Hi; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-84680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84680-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m9-20020a05620a220900b00787ba776da4si9261817qkh.773.2024.02.28.00.34.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 00:34:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=ImpNt0Hi; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-84680-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84680-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AF5921C21469 for ; Wed, 28 Feb 2024 08:34:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06EB93717B; Wed, 28 Feb 2024 08:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ImpNt0Hi" Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD392E85D for ; Wed, 28 Feb 2024 08:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709109203; cv=none; b=Hbg2UUnCMH7AGJ0jUkFsJXHzxCKdfvKWblKrwLyeIfPI4T1VOYgla+akVRawi/Kxo4SiBpCJ2PIepyhD0uUS4c5PtEOVh9nd1d2C+0HCF6gzdUHKtv9BLDT+7Cu8KGxjcrfu205ixCwv3aIkxBHSGuvjT4i7sY50ovcmUlIvBwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709109203; c=relaxed/simple; bh=Wr6oHFeer/nBk2CrajAUv1ACQwpXo37jKZZaaBfm3BU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Jftrvm829SwgHI1Ek7TvdQRNXy8QN5D1hz1jL7TqgIDkZL8IhVWlmR5/hvZqsF+N9CWFnE0/EEl8V36alKQiMv/bBzzaC1C1Aqkat7VfS85Zk1XTC1XQzS54rNL7/ej4OeHwNai1gErlIgUyLYtIFOVZY/LrZeiG4u0BVIO4iYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ImpNt0Hi; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a3122b70439so646795466b.3 for ; Wed, 28 Feb 2024 00:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1709109200; x=1709714000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hqHO2GEYl7GxbzESdMYs5ztGHyZiF6bQIqtKeXOQESU=; b=ImpNt0HioA72dmVbpqrVPND82DcPcBgpGryo4zjMttgkfyZto8VOzU4o7wCaA36N44 450EWwwUxaWKuERAZyhlUazxpbaNBetB3bmEu/AcOd21wiAzqOWoCHkMDwaYIpSXqX4R 9aupuAPoEwqalGvNnys0N/LyZAn3zCtZUPH0/wgTxUp4KCyNiMUFgrZ3+AEipsyMqV1I FU3HjFhEEC/YdmKFsj+qRGG49D3WGbklv+ky1ueWWy/9T2jvmAFXX1qgFwtfT9/wuTKJ qXOLnZORwCl6drj3ZH1FpCkZUUbivDEnuy0zDjq5hvx5PbvuO+VwGizQeLVB10ebCaam zYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709109200; x=1709714000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hqHO2GEYl7GxbzESdMYs5ztGHyZiF6bQIqtKeXOQESU=; b=TxQ3QmCReJNVXcEO3NjuzFF05lIf3/VomZ5DDgxaFAroB1gKt9Pu4LS+LTcyk1R78f HHT6h6DIVkGm8YW88pG+0zq97eZe5zs2X4prQJnXeFWkn9i2b1vMvOy49acTZfRUPKhj TcxapZBsKWLinp1DFoFH82pyCOF1ruPnFCKGR1EzXQsjvHrbkw+y8vH7Muv14FhvHl+P 5FCQTAHfj8Ch42wnr+iCqlwYoLsP70q5jI1QPsbUkBkqnkxRzkpH0L3U7hJMW47cMPq/ AEmpzS68Fbn1hxrMfhSw1Yfo4M5S+VgqK9e450sIMsj4X4kB/tcv5FgSTjgII2Gnx9j2 e04A== X-Forwarded-Encrypted: i=1; AJvYcCVBDOMTW5GFdXzSAuhP5bXlkc3cHeD3x3vm9mGYfpIga6kp6rtq50lDyF2ldQYrWDxUlteSGv0dJ9LOfZDX8Y+RN/81dXvfIu4TiBMX X-Gm-Message-State: AOJu0YxU/gXNFejT7PKByixnxKiK8UQAJ222yKkOh+H2lnLvoyYekza+ pEyBrNz8dhBZeaqj+zbWDzztso+A4Xq17qpSmzHwQlHoKpbUl3TxgnEYPfpOEpI= X-Received: by 2002:a17:906:38c2:b0:a43:2255:2241 with SMTP id r2-20020a17090638c200b00a4322552241mr6391339ejd.53.1709109200250; Wed, 28 Feb 2024 00:33:20 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.83]) by smtp.gmail.com with ESMTPSA id qh16-20020a170906ecb000b00a432777eb77sm1593987ejb.60.2024.02.28.00.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 00:33:19 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v8 04/10] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Date: Wed, 28 Feb 2024 10:32:47 +0200 Message-Id: <20240228083253.2640997-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228083253.2640997-1-claudiu.beznea.uj@bp.renesas.com> References: <20240228083253.2640997-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792130985860518591 X-GMAIL-MSGID: 1792130985860518591 From: Claudiu Beznea pm_runtime_put() may return an error code. Check its return status. Along with it the rzg2l_wdt_set_timeout() function was updated to propagate the result of rzg2l_wdt_stop() to its caller. Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L") Signed-off-by: Claudiu Beznea --- Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none Changes in v4: - none Changes in v3: - none Changes in v2: - propagate the return code of rzg2l_wdt_stop() to it's callers drivers/watchdog/rzg2l_wdt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index d87d4f50180c..7bce093316c4 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -144,9 +144,13 @@ static int rzg2l_wdt_start(struct watchdog_device *wdev) static int rzg2l_wdt_stop(struct watchdog_device *wdev) { struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); + int ret; rzg2l_wdt_reset(priv); - pm_runtime_put(wdev->parent); + + ret = pm_runtime_put(wdev->parent); + if (ret < 0) + return ret; return 0; } @@ -163,7 +167,10 @@ static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned int time * to reset the module) so that it is updated with new timeout values. */ if (watchdog_active(wdev)) { - rzg2l_wdt_stop(wdev); + ret = rzg2l_wdt_stop(wdev); + if (ret) + return ret; + ret = rzg2l_wdt_start(wdev); }