From patchwork Tue Feb 27 23:04:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 207494 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3015745dyb; Tue, 27 Feb 2024 15:07:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXCxgWm8D6SAeehMf/KzreN1ipPkDz2lOdubYLAmKJNHcailcI8zJpNq3jynTXE2saIg9O3ZkEKnI0IQYPI/rLmwwCoIQ== X-Google-Smtp-Source: AGHT+IEDLZ3jg9SoVIE3FBekUxGmsUp7q/Q7QPXiRmyGgfpaguCi4kAPB77n1w3B+QHGWcku+JQ1 X-Received: by 2002:a05:6102:31b2:b0:472:6061:45f1 with SMTP id d18-20020a05610231b200b00472606145f1mr2351640vsh.13.1709075236558; Tue, 27 Feb 2024 15:07:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709075236; cv=pass; d=google.com; s=arc-20160816; b=UFGmwzempgeIrVjnGaIC1XRdLMbSeL3mYxI6dMMMI1vVbs8lwXs1z5gZBnq5wc8Czb q93f9LBJXxz1gDb4YKtKYdG9R1i3+yJeHdRPnOGI3XEnYyBIxQspuDntKxUQJoZ5i44Q aU1aHk5ugoRJdNK86fY4rzP7vL9eeQ4oEr7OlTwVeavbwAFMXkk5T1TyOUJxuORuTDbS GWNL3cF5sSxrVvSZbIlFPnbroiUawKENRMAnEoJwfqeKty7tfUplQJ7dxugJE2tSnVeQ NDGXvI48mVgOJbEOOPCXhgF5dJSrNZwhP7iG8NNl50ZHCbC0dhx7ekVNHI/2VmGW0WtP FfvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=qy0P0eoIU4XbXDbSBcw570en4VCa8cKPG47nuLjP76M=; fh=v+fQpqqloRxheg66y6v5BEIIh4tqlWdyRuynNr5XQWo=; b=YCqQRWMC1ELVTvaWLOvP+DgZPHTg+Y2dHufPUQv3UMhEJiCPXib9F7aYQgmp9qO/g4 7VRihtDuNi9w+2BNrahM+UwmQyzSGodJ0h7GY0XimZ04fAvgwjwSu+TL/8zS2bQ5t0+e 70T7xtuJnHaD6as/Mues3rwFWs8GzfXsh3ML2Sz+6BSka22avf3bP2oLNxdtHruxIT4l 2izI7LRFgOblYCEWAPz6DYLIM0e/RW0rc9GDbWtUj2+EyPwJqSerznhcBPvOffIVAC3+ M8+d56Lm3Ybk93xOOoyVtdbs4N4sP047MEpzHWbC3cv7KOlIkdJs9wvyt2MIbbuvDDsh LIiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=SZHfRTgi; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-84166-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84166-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id jm26-20020a056102199a00b0047265624694si269043vsb.416.2024.02.27.15.07.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 15:07:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84166-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=SZHfRTgi; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-84166-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84166-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 76F1A1C27CF2 for ; Tue, 27 Feb 2024 23:06:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 237AF56479; Tue, 27 Feb 2024 23:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SZHfRTgi" Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECDB5812A; Tue, 27 Feb 2024 23:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709075102; cv=none; b=RrNVyuX3dnoY3ls8j5mx3EZP/kNxHwIU4admSpSwivjawupR32cw6+smLQp4iVMLbQLag1HGxutSBWyclfeo2u3cE5mP6tdxmjApuj9KZT3M8dw7H9lPgUFwbDaUyYIojIP4GTodeBPdsBmN26Q6f5P943kajasDO5c8iO2Y3Jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709075102; c=relaxed/simple; bh=kmIa/7ZyXqprHqUEcR3GU7DrR4potHZgTHFoWWOaR2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rz/4RDSbThoVwbHhTuAvVjfCJACUeGQldhVJKx0IhmMBYrvQMzPu5zUzn3kBxtDunzj4pcS79c8nzdb96Uz6gMYAQCC5XQYLvgyuxt88RS3Sybv9qOitkiC/vSD7Nl0OqNUTwEAEGHs+aivbpMluw4l6Q5xSUsJbJfpYAY+bRp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SZHfRTgi; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 4A8B5240002; Tue, 27 Feb 2024 23:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709075098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qy0P0eoIU4XbXDbSBcw570en4VCa8cKPG47nuLjP76M=; b=SZHfRTgijYjEX3jiJpI9nV6GBM9BCV9lNcBt4nnks9upNXszaeDgvfyX6A0dKC2EAvwjnn ujUuQCTIW3HL9dtcW239WPcfhWSSQRFG2Un7NnkT1LX8tY38JIvqW5nSjY2sr9MI952Luc nZ/PVAlm4G7aX8yFBGPEQMDfJDOBqYC9Za1L8lkWseRMT5KmzOzY539h8m6zl4ZF6Dk28I mZu06hutJW2o1efSnqag2XZbNj02lssBCXXpZoVyKbaPFh4vvhc/pDJdFEV61HfMDiKoa7 SknrTNRRfu7z59BEWvZOXSRuTHerOWg7/fKAatZFnB6nRe30in3uT1wnc8AyQw== From: alexandre.belloni@bootlin.com To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] rtc: ds1511: let the core know when alarm are not supported Date: Wed, 28 Feb 2024 00:04:23 +0100 Message-ID: <20240227230431.1837717-8-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240227230431.1837717-1-alexandre.belloni@bootlin.com> References: <20240227230431.1837717-1-alexandre.belloni@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: alexandre.belloni@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792095275193491976 X-GMAIL-MSGID: 1792095275193491976 From: Alexandre Belloni Instead of failing function calls, let the core know alarms are not supported so it can fail early and avoid unnecessary calls. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1511.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index b0dfdda2c8fc..c81f464e6a50 100644 --- a/drivers/rtc/rtc-ds1511.c +++ b/drivers/rtc/rtc-ds1511.c @@ -188,9 +188,6 @@ static int ds1511_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) struct rtc_plat_data *pdata = dev_get_drvdata(dev); unsigned long flags; - if (pdata->irq <= 0) - return -EINVAL; - pdata->alrm_mday = alrm->time.tm_mday; pdata->alrm_hour = alrm->time.tm_hour; pdata->alrm_min = alrm->time.tm_min; @@ -219,9 +216,6 @@ static int ds1511_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) { struct rtc_plat_data *pdata = dev_get_drvdata(dev); - if (pdata->irq <= 0) - return -EINVAL; - alrm->time.tm_mday = pdata->alrm_mday < 0 ? 0 : pdata->alrm_mday; alrm->time.tm_hour = pdata->alrm_hour < 0 ? 0 : pdata->alrm_hour; alrm->time.tm_min = pdata->alrm_min < 0 ? 0 : pdata->alrm_min; @@ -253,9 +247,6 @@ static int ds1511_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) struct rtc_plat_data *pdata = dev_get_drvdata(dev); unsigned long flags; - if (pdata->irq <= 0) - return -EINVAL; - spin_lock_irqsave(&pdata->lock, flags); ds1511_rtc_alarm_enable(enabled); spin_unlock_irqrestore(&pdata->lock, flags); @@ -349,12 +340,6 @@ static int ds1511_rtc_probe(struct platform_device *pdev) pdata->rtc->ops = &ds1511_rtc_ops; - ret = devm_rtc_register_device(pdata->rtc); - if (ret) - return ret; - - devm_rtc_nvmem_register(pdata->rtc, &ds1511_nvmem_cfg); - /* * if the platform has an interrupt in mind for this device, * then by all means, set it @@ -369,6 +354,15 @@ static int ds1511_rtc_probe(struct platform_device *pdev) } } + if (pdata->irq == 0) + clear_bit(RTC_FEATURE_ALARM, pdata->rtc->features); + + ret = devm_rtc_register_device(pdata->rtc); + if (ret) + return ret; + + devm_rtc_nvmem_register(pdata->rtc, &ds1511_nvmem_cfg); + return 0; }