From patchwork Tue Feb 27 21:00:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 207426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2961543dyb; Tue, 27 Feb 2024 13:00:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUa8XOazqFIhIwlSZpvVSV9DKsecLZiTwuOTcQQYto+0v/SDyHyH4hbYwshQCNB6fCsV8mN9UWMwBUEmuTjz1T48Ugqrg== X-Google-Smtp-Source: AGHT+IHbWe0AI/5mUH4+XAC3mJWzbSQE5xe/t3lCFUa3UXOz6OdexV4ahoSKJTWcwaT+2Ci6w8e+ X-Received: by 2002:aa7:df0e:0:b0:565:f51:3b26 with SMTP id c14-20020aa7df0e000000b005650f513b26mr7903653edy.30.1709067649636; Tue, 27 Feb 2024 13:00:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067649; cv=pass; d=google.com; s=arc-20160816; b=UvAKnPL8gU8ZWUnKeAS9/93AbljvJeamHMkRar2X/7qtJqouWArlvpRWEQyjzWszAo Zx6bBNQYgRtHMPWR0fNre1E45EJUFC88wI8x3JBsHsBQ6Vqrpx2vG2wsYg8MRgB3loY8 UhH/470+6tTH2mAV2FlI8T3mY99lB1Pu+rOofXtxcF28pM9CtdZLC23PGMFV14icGf6d gedimclhGrKnxoV0yNeBx0r0eNV4Kdt2hJ8Jh/ACNY90VeUtrn9luJ2GvhRm28T6Mzw0 kN20wqizmvAnt921QpHNfpLuYjagfjLx7UPIZgR35wztfB3HdL1pkcBDLS0H3tbLT9CA qtMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=HBGsraC8xcfuBlVVXonM0asONE2oxZ0KqbeSqC/uLK4=; fh=/aA3ikCzdHUoND1NkELyjjOlZC31bXhfya5LgPc2Wj8=; b=H1yoV/0JQP+Ugac21BAnIrh5gIN4+Znbc4y/n3ur8Q+JCyb3gnvTASo0SwewYLrAsL vv4bviBBTHChWSCmrkVcCSfOZ39npCo0koCl5EbzNS0A7Bp5QECebSxuZsOwYTDoXVb9 kfPxVgPCaYYzKjRs+v0PNP4Z7XHBaQQx4DbiZ1KAg9xss6d11QBBr0lr2UBTElsCtvHJ Uf+ded4oCh6iib+t2fw2dAypz/SvPFZUxXrKNecc5JH9vOTGvbRrxpJpKQumVpA4Wvj3 mLtBQYub5MAhpbTvnxmPkg9dUxefJIkMId6gMUoztSet9qvjWO/mSNMkOi5XpRzb2/GX H9Qg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhxqhSbD; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p23-20020a056402075700b00565b4b999absi986052edy.428.2024.02.27.13.00.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:00:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhxqhSbD; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 41C6B1F247C3 for ; Tue, 27 Feb 2024 21:00:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6D1E14F970; Tue, 27 Feb 2024 21:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nhxqhSbD" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBE3513AA36 for ; Tue, 27 Feb 2024 21:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067620; cv=none; b=rQkU8Yj/21RogQ6xWqD9ZjfLMIHYmj7nVMiW4FpvrrYsj7xL+WvWNj+a6J4nKRXnBNqWmnSM1Gbk2OWsWIK6mkgV3B/tmnz8TXLJ4Hfpl1giQJ/STLcMMEJGpF+Njqa2Ekggf/LPQt3Ou+9qbJl7D0EsfunhvMXdYEZDJc9GBgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067620; c=relaxed/simple; bh=RE/r0QBlJkpfsDcdAyyvBwd5gHrITMQLec9sLSeOxDo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Ta5SXgPrniOfUXMze+a5DXyQCUB8IhV3Yyzry6AhtO2VmejP0ap2FTfS/QSyvFfpShOsEhlSbVn1JmIBgCjgVi1EBOxkWwUCo0DfAY5e91dbqsD8NOQ9H3lzO9RcXb2ht1dlQBbBuYomDLbaZVooJF1iwHZjL/kCantKbqlKW8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nhxqhSbD; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709067618; x=1740603618; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RE/r0QBlJkpfsDcdAyyvBwd5gHrITMQLec9sLSeOxDo=; b=nhxqhSbDiBp972rNAyv08Ln4t9PLnmkQgDaICHyWe3Tuye5TMSmUjS1o 6Qxr5l0faIRc18FVnVTWur+nxzsBnbXzDoOKjDZzxUvXtqo39WCg9J9GF 7TL8h2Hu5YeXD+gPErhybN/mJIsR25tXhEkz+PHrtT+bDN3JAC7p25LXi vKjXtzq+NIRshzUGUQ5NWzy5rkamGpxId/WOU1p9Vy9lS8KN+jCnE6727 20ziw6YPpQGb6BmA9sE4Dvda466O/rl3RYRe0VeeuQrsiQlpI8t8PJ8gN AUS1ttYSdneEiCeONHDRZvuKnnN8W3cZvDtIhLk8w0so9/u6aMoqCNETc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14858440" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14858440" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7150405" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:14 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Mukesh Ojha , Johannes Berg , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH 1/4] devcoredump: Add dev_coredump_put() Date: Tue, 27 Feb 2024 13:00:05 -0800 Message-ID: <20240227210008.182904-1-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087319804733261 X-GMAIL-MSGID: 1792087319804733261 This is useful for drivers that don't want to keep a coredump available after unloading. Otherwise, the coredump would only be removed after DEVCD_TIMEOUT seconds. Cc: Rodrigo Vivi Cc: Mukesh Ojha Cc: Johannes Berg Cc: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/base/devcoredump.c | 22 ++++++++++++++++++++++ include/linux/devcoredump.h | 5 +++++ 2 files changed, 27 insertions(+) diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c index 7e2d1f0d903a6..e96427411b87c 100644 --- a/drivers/base/devcoredump.c +++ b/drivers/base/devcoredump.c @@ -304,6 +304,28 @@ static ssize_t devcd_read_from_sgtable(char *buffer, loff_t offset, offset); } +/** + * dev_coredump_put - remove device coredump + * @dev: the struct device for the crashed device + * + * If giving device has a coredump this removes it from file system and free + * associated data otherwise does nothing. + * This is useful for drivers that don't want to keep a coredump + * available after unloading. + */ +void dev_coredump_put(struct device *dev) +{ + struct device *existing; + + existing = class_find_device(&devcd_class, NULL, dev, + devcd_match_failing); + if (existing) { + devcd_free(existing, NULL); + put_device(existing); + } +} +EXPORT_SYMBOL_GPL(dev_coredump_put); + /** * dev_coredumpm - create device coredump with read/free methods * @dev: the struct device for the crashed device diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h index c008169ed2c6f..c8f7eb6cc1915 100644 --- a/include/linux/devcoredump.h +++ b/include/linux/devcoredump.h @@ -63,6 +63,8 @@ void dev_coredumpm(struct device *dev, struct module *owner, void dev_coredumpsg(struct device *dev, struct scatterlist *table, size_t datalen, gfp_t gfp); + +void dev_coredump_put(struct device *dev); #else static inline void dev_coredumpv(struct device *dev, void *data, size_t datalen, gfp_t gfp) @@ -85,6 +87,9 @@ static inline void dev_coredumpsg(struct device *dev, struct scatterlist *table, { _devcd_free_sgtable(table); } +static inline void dev_coredump_put(struct device *dev) +{ +} #endif /* CONFIG_DEV_COREDUMP */ #endif /* __DEVCOREDUMP_H */