From patchwork Tue Feb 27 18:16:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 207431 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2964346dyb; Tue, 27 Feb 2024 13:05:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXQETyLEQ95u9fk5Am8NALsVda6X+gmYtVFG4hArS80r/Cqa9ondWYJ1Ji8Y4xs6ntJf2Qd1/BEXXqgOJUWc43aJaKqaQ== X-Google-Smtp-Source: AGHT+IExUSeZKFlw2qvEnFP+XJdZCnazGCJTAaZ9yOK2rs92/TqfWVcRjILdNQFcmxl4yy8DgQ2D X-Received: by 2002:a05:6870:64a6:b0:21e:8c19:f716 with SMTP id cz38-20020a05687064a600b0021e8c19f716mr12745952oab.49.1709067916355; Tue, 27 Feb 2024 13:05:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067916; cv=pass; d=google.com; s=arc-20160816; b=z5Ya36ayEavnLGswy69HkMktOMRiai2Tkli4C+yzu0j36E7aE/ljCQXQMIiqX96xBf AtEliBvIcsBwx5SBGdFW5nfGTWbF3jzw0aI0uOqHIKnnV/uAiZhhAaiIN4WIze0OaKSg X7fHDfmf84888f1/xcn9VWLkuvPQzJ0v2sotMktWkV9Xadk3aAk7a8FmHDmCI1ozuVeA 6S+k8mU9Pn4iy4IeabDdnwRrAp+YmgVui9dIKOe4OqVDppdWQO1oml0+/JW1trU0DhJn rKJNxgolOJ3dRz39h5Y3zbmodNmW+yB0JTokDdlTpVIqXMHM2Z58LHJgj2gnRQYARJrp DoIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=S26fjaDFAIJ37+8snV1yUJ/yjYua3qMKaCxClShx9iY=; fh=OvJRnOqsMTm9XoNmEwebcqh9Ud7yh1CTeKAP84ols98=; b=mNTIiul03oAb1gtJCPHrJCH2A9NoNvPchuVLBshpydEW8iu5VXFAhL0/NXV/jkQGNJ NEWZ0E9ptwyJWHlm2gAsQw6tmwCy2RO1PjBpRUyxHJOVoBMdLGhsmaLcKYpGVwpIuydc l8mmX277fdmkVT/VwNWelN3cYG+qGI1+AyoD00qY2cAT223XO+maNthQc95/6ENFDeki 0mhrQfauv/ApbhrywLdyB9E+qG3+VH4vZ8h7dHLpasmrtobtwtG0ADhdUrpnzNAgsNzB Bndzxf8olFQ+kdVjndqG2uP7MRtmxtrV3atYeOKgG4YxIjRD92E0x/XfuwLhtzl/uFaJ Xz8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HvBrCYbW; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-83810-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83810-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h8-20020ac85e08000000b0042a2e4e2341si9032267qtx.780.2024.02.27.13.05.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83810-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HvBrCYbW; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-83810-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83810-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6BA461C254D6 for ; Tue, 27 Feb 2024 18:17:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D426B14C590; Tue, 27 Feb 2024 18:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HvBrCYbW" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8401487DC for ; Tue, 27 Feb 2024 18:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709057819; cv=none; b=pCSOpecwxVYbKTQDxQGOdWBmXXJ122SXhisq5kCXllKMbnsA+UlAwMawIaF1HGJsrbyHUikFuxRutubfpoaUeao2Fs83rrOmXzznofU+oc0NHO2CO+AIaeAYLq0GN/nvl3Aq53HyJcWaSCov2ee8uPoMoS7GPHB4xU3xSqfzvsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709057819; c=relaxed/simple; bh=yc+q4KsjIiSfEwY6TeHFKJsFn5r2uXtVujdyv1Did04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nQWbGD7sBLaFrJiwIDRUh0t+p5QXeLR+qdDxjdWTdacPYJt/JlM4ig4sf4BFGhtwilWRMezMsAJvlt7p9b5rEuuhKT5R2zVesDU2e9IuJR0712xGdo8oZdwYQ6T2G+LIzbkma+LdZzMlh67EKKCWUOI9V4dvSgCr38FK6xGfQ8I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.helo=mgamail.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HvBrCYbW; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.helo=mgamail.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709057817; x=1740593817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yc+q4KsjIiSfEwY6TeHFKJsFn5r2uXtVujdyv1Did04=; b=HvBrCYbW2VVHmRB2bee0lpx1XcOFj9Re3d3deFpAvsUP1UFGsnkqptFl 8bCummoO31c8ANDVxVC9tw6/vsS/9EJ0MR4tmpE/fgAdC0NfD+y/zL6KD t2Nn8rT8tzyCZiROwLi/f16rHr/kFGozReowJi24OTwtELozV3Ct83jSx u1MZf9YQGOWASEkoyJwxmGZObpvnjI9UMB4cWX8SxrC1x7sKXSqDKHeLg 1rceeMFOKGWCyconhV+F9iu5R1sI1O3xQlyyq8Wg6URA+98QcpdpDCNYG gMreoOQlNZSoUiygBQfgmJHy4I2F1D8LpgqbgTW4gkKaroWBik6UAyIqR g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="20966060" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="20966060" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 10:16:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="937032709" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="937032709" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 27 Feb 2024 10:16:20 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 5D3F8445; Tue, 27 Feb 2024 20:16:19 +0200 (EET) From: "Kirill A. Shutemov" To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org Cc: "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , Baoquan He , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCHv8 03/16] cpu/hotplug: Add support for declaring CPU offlining not supported Date: Tue, 27 Feb 2024 20:16:03 +0200 Message-ID: <20240227181616.3032032-4-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240227181616.3032032-1-kirill.shutemov@linux.intel.com> References: <20240227181616.3032032-1-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087599864734087 X-GMAIL-MSGID: 1792087599864734087 The ACPI MADT mailbox wakeup method doesn't allow to offline CPU after it got woke up. Currently offlining hotplug is prevented based on the confidential computing attribute which is set for Intel TDX. But TDX is not the only possible user of the wake up method. The MADT wakeup can be implemented outside of a confidential computing environment. Offline support is a property of the wakeup method, not the CoCo implementation. Introduce cpu_hotplug_disable_offlining() that can be called to indicate that CPU offlining should be disabled. This function is going to replace CC_ATTR_HOTPLUG_DISABLED for ACPI MADT wakeup method. Signed-off-by: Kirill A. Shutemov Reviewed-by: Thomas Gleixner --- include/linux/cpu.h | 2 ++ kernel/cpu.c | 13 ++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/include/linux/cpu.h b/include/linux/cpu.h index dcb89c987164..aa89ef93a884 100644 --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -139,6 +139,7 @@ extern void cpus_read_lock(void); extern void cpus_read_unlock(void); extern int cpus_read_trylock(void); extern void lockdep_assert_cpus_held(void); +extern void cpu_hotplug_disable_offlining(void); extern void cpu_hotplug_disable(void); extern void cpu_hotplug_enable(void); void clear_tasks_mm_cpumask(int cpu); @@ -154,6 +155,7 @@ static inline void cpus_read_lock(void) { } static inline void cpus_read_unlock(void) { } static inline int cpus_read_trylock(void) { return true; } static inline void lockdep_assert_cpus_held(void) { } +static inline void cpu_hotplug_disable_offlining(void) { } static inline void cpu_hotplug_disable(void) { } static inline void cpu_hotplug_enable(void) { } static inline int remove_cpu(unsigned int cpu) { return -EPERM; } diff --git a/kernel/cpu.c b/kernel/cpu.c index e6ec3ba4950b..7c28a07afe8b 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -484,6 +484,8 @@ static int cpu_hotplug_disabled; DEFINE_STATIC_PERCPU_RWSEM(cpu_hotplug_lock); +static bool cpu_hotplug_offline_disabled __ro_after_init; + void cpus_read_lock(void) { percpu_down_read(&cpu_hotplug_lock); @@ -543,6 +545,14 @@ static void lockdep_release_cpus_lock(void) rwsem_release(&cpu_hotplug_lock.dep_map, _THIS_IP_); } +/* Declare CPU offlining not supported */ +void cpu_hotplug_disable_offlining(void) +{ + cpu_maps_update_begin(); + cpu_hotplug_offline_disabled = true; + cpu_maps_update_done(); +} + /* * Wait for currently running CPU hotplug operations to complete (if any) and * disable future CPU hotplug (from sysfs). The 'cpu_add_remove_lock' protects @@ -1522,7 +1532,8 @@ static int cpu_down_maps_locked(unsigned int cpu, enum cpuhp_state target) * If the platform does not support hotplug, report it explicitly to * differentiate it from a transient offlining failure. */ - if (cc_platform_has(CC_ATTR_HOTPLUG_DISABLED)) + if (cc_platform_has(CC_ATTR_HOTPLUG_DISABLED) || + cpu_hotplug_offline_disabled) return -EOPNOTSUPP; if (cpu_hotplug_disabled) return -EBUSY;