From patchwork Tue Feb 27 09:23:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 207105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2583154dyb; Tue, 27 Feb 2024 01:25:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX/ynYU29qtpe11h4g/BhKEKQL7jS/TztAxRrZ8H3yVAzX3sctDY+0jDIm1fkb4mhg7TIHppKDf+Evs/9NtB34YZhaetw== X-Google-Smtp-Source: AGHT+IHvKMT1FjdjOtH6FwjUsRBmxVUKDhNRrPI5hTfJXMvl3dbIJ4ceQXraV3x7eC6/ZX/GqdUA X-Received: by 2002:a05:6402:345a:b0:565:6e57:fa3d with SMTP id l26-20020a056402345a00b005656e57fa3dmr6453742edc.10.1709025955278; Tue, 27 Feb 2024 01:25:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709025955; cv=pass; d=google.com; s=arc-20160816; b=tiVMa+ekFifhJ07Ap3kh5YHgFsU+hBwoZasOLJyw2TLDJy+PW1/vce2C0bVbYtaJzb bkc5c5wIjgQeVOdrDJIbn63aORWe7ZMBq82DtE4uMAfixF3kNjKBqjtEqDdcGRlAdnxb D7YVjCVf1RDbUf9MZ0A6aUnHUDeQunUYZrJ4KWFDtYnWYVMruBI17yNaGdZVa72jZf7w I/48DP7RO3R8yAtVcs3v+xskJ3mf0I9mgtPLYoJCvr7WmBQxymYOgmUGYXz12G/QwPWX 7Pa+F9BHI9BDBzFzGaInWxPnJntzEiJxt2TFPA1PhK5QxnBJ/C/eDeC/9zyIjTVw3CbJ S5Vw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=d85wjCPKsPTz3Rza4pjG33gtaXBRNDc7tb5vEW/wB4s=; fh=zNuDOsvoR+8aICeqYSghaRjPRQ4KSmjT7toszJtY6lw=; b=CZ2+47lqq4I9S9f5a2ltA/7nW45Kspe2P8SPij3xBW/Y433ldErC5FyRd3r6jZh+Ea FyosqZMAj1Sabm0qhURYXbdXbDO0LKVQ/4s+C9pqPiPe6wOa2zR4ja0OZqe4+I4gLn1P jlISAVfBT4gfY5hMm7pS7DZDFmuu/sVDRbcacE7G0An82aKZ9neQO0HZoFvr4vyhdDJy dJPbZo/O2nPN/HR9X32sQ5cvyuFmNgSvLMoJponstaIgRIPBgkwFd3qTFQ/66hFQIiL7 DFCxvJJ8JUSbgrsWhbnCZtmebmRCJQ3ETWq+Z9F2ai2ltErMpZqyqbUoAw6dru0jWTOU eoDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KEuAl/gf"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82952-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82952-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t2-20020a05640203c200b00565afeb683csi569251edw.364.2024.02.27.01.25.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 01:25:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82952-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KEuAl/gf"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82952-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82952-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E0C291F23572 for ; Tue, 27 Feb 2024 09:25:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E1609137C5E; Tue, 27 Feb 2024 09:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KEuAl/gf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22230136991; Tue, 27 Feb 2024 09:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709025884; cv=none; b=GlLpbhjyIrqK80Y5HtrXPloI3dML06eUTma5c8ZIcxVPMdRv4p75BIzFAByZETqsoamtMUyzJfzl5X3Ad1gC0cNlFjXzwYSNlYKBYaPrsMkdMHwYqAZDB+LIrg/kRyk3wtwAxJ4oxqoEFvgT+/B/Pk3es/wkFQIHf522SZ8e6zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709025884; c=relaxed/simple; bh=F0A6vQO//Uj1T20JqS9Pe7m1ckUNgr/dnHmSUeV0dxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pufW9GnmUczVH+hCoGceCoKf0keerEhZ3j51SdN5a9NKqccOH4rPWRWxNyZqENJU3RJ8AqVQUwbMJjHIJnh9RZct/ON/ia0d9unS0j+o4SK28fnfNSwzpWz7o/Uyg+xM2ww5j9uh8NH98RZZlcXIjm7O1g4rVKQGQ6RvG7Ymn9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KEuAl/gf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74B94C433F1; Tue, 27 Feb 2024 09:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709025883; bh=F0A6vQO//Uj1T20JqS9Pe7m1ckUNgr/dnHmSUeV0dxo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KEuAl/gf9cnj1JeOrE0UAaHbfEXn+dDGN8VWqcB/ap3oXjl9qQwnrDFWIRPb4jvhm OrHH6d4u8OL2Y8KTT6a0FL78+cxoxLMmgPTdW6966RGkCrg96rQ21Eg4fjtXxDG51z bzrNS+FF6jvkmxKmxO82ARzxTmNARv+hZwil3c92B60lJYp40MWIYeQdJ48brnFc+J yNFdhk2xSryzqNGkCTL5laYmkFAshJATnNCMKUN9arzIoRX1OhxkAt7xth4RTFAnlE SXvDX0DWMQ4eSd1STkcbIxLx3U+g4EI7DYAQ6RSkQ9lPTdzL4fh02J9x7/lt7brXXH sb0fssCEsbEmQ== From: Roger Quadros Date: Tue, 27 Feb 2024 11:23:50 +0200 Subject: [PATCH v4 3/4] usb: dwc3-am62: Fix PHY core voltage selection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240227-for-v6-9-am62-usb-errata-3-0-v4-3-0ada8ddb0767@kernel.org> References: <20240227-for-v6-9-am62-usb-errata-3-0-v4-0-0ada8ddb0767@kernel.org> In-Reply-To: <20240227-for-v6-9-am62-usb-errata-3-0-v4-0-0ada8ddb0767@kernel.org> To: Thinh Nguyen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: nm@ti.com, r-gunasekaran@ti.com, afd@ti.com, b-liu@ti.com, srk@ti.com, francesco@dolcini.it, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Roger Quadros X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1533; i=rogerq@kernel.org; h=from:subject:message-id; bh=F0A6vQO//Uj1T20JqS9Pe7m1ckUNgr/dnHmSUeV0dxo=; b=owEBbQKS/ZANAwAIAdJaa9O+djCTAcsmYgBl3apLluERQIpayJ8M4f8TJfsGLKTWS3+iX9aoF 5FoDL7kQ0GJAjMEAAEIAB0WIQRBIWXUTJ9SeA+rEFjSWmvTvnYwkwUCZd2qSwAKCRDSWmvTvnYw k0LrEACbANZFxhPpAuN6pDPDVsOVulXzz8oEYIe683yjjBbIYpHKugkKFZ9WR/Lgbp4P9NRLQxb Obj1VuI7LEAvDptmyRKbvDMl9t3WnDUmmdYb/ednuGy7fz3H7ILBXG9khG9WRcXdZ9OSADUwdP4 QMJ6yKkOPPgOHhEDNQgtLcKCvqQ9ezdyerpazkiH+GGCDUeEcWqNIYZMfdmgmPqQoqZbKMxy3js 9kUupj0ixoDf2lTCGLQzdQKN6lIRDq9GSbcONIHV15kYiVdzsL3lqW66wK/rKSd6AWa2mziTd35 PKYdTAZ5Ihk3FaFJKOWThguVdaHhDJqtRVzQL4xuZ3OWbnKOqMGX2hnkRURcVAchlALjzIH2ATk K4YcV3USrm/C5yB3Umi4Y/CiuZczJJAdfbfoGeaumLuJcCYZjC7XhIAAmZFFvADy4qUDGP0U/tl rxeBJDLZTpYM1VLwsvjBa71+up0XSwMPKmD//MGUWVwAqyQaceB1UhyNCYKJbflysrho0d/HZSi xMqACYG64YSJJR0vmnBYZlb/VI1RomkEy8hbFd1yaUNUZ/r2gTs6xTmYGkF3SiFG1QdGwkLdiqf FkTl5YPI2HcPQeRk4/H6I69daA7pha+E4UCxZvEwhlSQK+Hgb7PL8kUG4iL0C2W4dWWIM1zP4Fw 2nPbkUVxCPctU3A== X-Developer-Key: i=rogerq@kernel.org; a=openpgp; fpr=412165D44C9F52780FAB1058D25A6BD3BE763093 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792043599770796637 X-GMAIL-MSGID: 1792043599770796637 TRM information is outdated and design team has confirmed that PHY_CORE_VOLTAGE should be 0 irrespective of VDD_CORE voltage. Signed-off-by: Roger Quadros Acked-by: Thinh Nguyen --- Changelog: v4: Added Acked-by v3: no change v2: no change v1: https://lore.kernel.org/all/20240201121220.5523-4-rogerq@kernel.org/ --- drivers/usb/dwc3/dwc3-am62.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c index ea6e29091c0c..09b1f5a1c4fb 100644 --- a/drivers/usb/dwc3/dwc3-am62.c +++ b/drivers/usb/dwc3/dwc3-am62.c @@ -97,7 +97,8 @@ #define USBSS_VBUS_STAT_SESSVALID BIT(2) #define USBSS_VBUS_STAT_VBUSVALID BIT(0) -/* Mask for PHY PLL REFCLK */ +/* USB_PHY_CTRL register bits in CTRL_MMR */ +#define PHY_CORE_VOLTAGE_MASK BIT(31) #define PHY_PLL_REFCLK_MASK GENMASK(3, 0) #define DWC3_AM62_AUTOSUSPEND_DELAY 100 @@ -162,6 +163,13 @@ static int phy_syscon_pll_refclk(struct dwc3_am62 *am62) am62->offset = args.args[0]; + /* Core voltage. PHY_CORE_VOLTAGE bit Recommended to be 0 always */ + ret = regmap_update_bits(am62->syscon, am62->offset, PHY_CORE_VOLTAGE_MASK, 0); + if (ret) { + dev_err(dev, "failed to set phy core voltage\n"); + return ret; + } + ret = regmap_update_bits(am62->syscon, am62->offset, PHY_PLL_REFCLK_MASK, am62->rate_code); if (ret) { dev_err(dev, "failed to set phy pll reference clock rate\n");