From patchwork Mon Feb 26 14:19:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 206850 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2263599dyb; Mon, 26 Feb 2024 10:38:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVpkvfrimwFaq6HKCSoFuKFxqWvJ8R7x+doogT8pDsap7ukkzIa/O3BNT3SFlyBr/d37xIrLcHJ29qCgcrSBqeb9Qei7A== X-Google-Smtp-Source: AGHT+IEEb6B1rcPeibyo8SdKeC8iwufR0SNr+7WaIvIoIgZPjxeulq1Qpm3XKzi0apTzbFFPckdy X-Received: by 2002:a17:903:2343:b0:1db:d256:9327 with SMTP id c3-20020a170903234300b001dbd2569327mr9429541plh.19.1708972712390; Mon, 26 Feb 2024 10:38:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708972712; cv=pass; d=google.com; s=arc-20160816; b=AYQIH5lkyk2RN9jFp6t5It2ft5bHytbuW1oGi9SK/gqL7KK5a5b5afLsEAWTof1/OI 53xu2US38spd5Z2JtlPiY3TimaunAnqF0buwWpnYLNEBPzLn56xrFxHvzYzjyjY/p2Cn YrDyrOgwCDjnj6h4OurvyIycnfAOfvVbvOQOlUvsrysWz3VSO1emkcfkZvJzebStn2Im xFSm+KY1HNjYr1AuLR8ho8ygL79Tj8r40f/nocxQz11qsEW88CULk/XBgHpNGOkZ3P/c hOS/s7ERnL7XBjDRtAessLFiYxwIk6LXiZp7od0bkOim2rOUIaD+0z699INWvdqDl4Hb 3LHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+an0I+W434cxFId+3/STrzSURj9YTgEiB5vzTwV2bW4=; fh=xSGBIHWd5RaiKxDKjJ9wuXs6bQZHuqbCRoo49Bl7JGU=; b=m87Cf+nDhKb8sEwI2K7h6xGdCHiqDuLw/kgwInMuZcfRRPdd20f2VEHsw3IBAUkxqE q96UrPuSfJHkzp3oFAWzyE7ICEKWf1avCWaSJJpB5vwSE2MrOZJGEXVWtdG5awg/x6C9 qdVUqWnjDMX4hd9FyhRBPtYbMWJFBEzjK9h3iNJyK/X6cJiGehVY4J4qU7dJijekvjad N8LhhE26thxJiteftbsvcccY6NNyw1weDU5gCLYH2DlCGdGWMVymyqofRHa5uivuTVKi W3+OMx5PEU+oPNmckSfaTaWGJlIrEj+sEouoEHFIaUBRIVwIphATLa34V2MyuCFjVrat MBnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P5uHZ10t; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-81606-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81606-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id iw18-20020a170903045200b001dbd81089e6si8662plb.515.2024.02.26.10.38.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 10:38:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81606-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P5uHZ10t; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-81606-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81606-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7DBE8B24023 for ; Mon, 26 Feb 2024 14:26:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EAA8812A143; Mon, 26 Feb 2024 14:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="P5uHZ10t" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91DAD129A9C; Mon, 26 Feb 2024 14:25:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708957528; cv=none; b=sxC5gMSaSxMatRBYrUygoeKRuC4VoNMvNY6umbei80PVT0b/iNSlz2tpQ1YbD9HQvKyYpew3nSoLuC0asg68vlx4GIoKwWjq4X1pdBFCQF0DoTQl+d6DlxoT0RuMl9OjsHs2vNqUJ8WSRVOPhyKaPbk8thnrMjteqBzVV0+FHQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708957528; c=relaxed/simple; bh=A8p5Npmvda1MkUKRvwcBNktCV2esnRfoVCvpbf/iEPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iI46eUKIkSAhvgDdToy2xrkWHU6dQue7yBxohPWgWrxQXdJDkwzS1IWa970qjcxqr9RBFwRAHQAlK4wuqq3tEMeqgrCDeksdpM53e6DnJHyoDC5g+hiMN/ex/R9qE8QVyp+xe4mHJ6GklH6cxM0JK/q9kb49aoUlPRtZwmoNGE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=P5uHZ10t; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708957527; x=1740493527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=A8p5Npmvda1MkUKRvwcBNktCV2esnRfoVCvpbf/iEPo=; b=P5uHZ10t7RftxGJPwQKuBrbiceU5I6w3pPLtodpHhC68LDIGRkJC8pix H9kIbRVc8+Hl0Zf0xQBxmRFM5VZwDzN3YJLAYZRG2B4uWCquAC7SXQViI TPB5p/xNGWta7HV0t+IHgPbmTpxwlti859DScu4RhsDZV5jsO2GLsug5w ksAdVLUxcFIsxZgVeqQ8AkP0c5zdbkeABzNm/EX0fs65Pd6PgD8jijSMl azcrpX+qAEiT6P3DWcReIntNGGlaxjX8Wz0At9mkXjQj436CrwcbfLVMq kWu0xfz8gzcXuRfk7IrYLNbC7KD9b3Ixo9I3DiD9J8c9Cm4VPqvs6oUWo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="3375147" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="3375147" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 06:25:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="937030141" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="937030141" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Feb 2024 06:25:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 07994144; Mon, 26 Feb 2024 16:25:15 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org Cc: Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Al Cooper , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Andi Shyti Subject: [PATCH v2 01/14] serial: core: Move struct uart_port::quirks closer to possible values Date: Mon, 26 Feb 2024 16:19:17 +0200 Message-ID: <20240226142514.1485246-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240226142514.1485246-1-andriy.shevchenko@linux.intel.com> References: <20240226142514.1485246-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791987770823213104 X-GMAIL-MSGID: 1791987770823213104 Currently it's not crystal clear what UPIO_* and UPQ_* definitions belong to. Reindent the code, so it will be easy to read and understand. No functional changes intended. Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko --- include/linux/serial_core.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 55b1f3ba48ac..2d2ec99eca93 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -467,8 +467,8 @@ struct uart_port { unsigned int fifosize; /* tx fifo size */ unsigned char x_char; /* xon/xoff char */ unsigned char regshift; /* reg offset shift */ + unsigned char iotype; /* io access style */ - unsigned char quirks; /* internal quirks */ #define UPIO_PORT (SERIAL_IO_PORT) /* 8b I/O port access */ #define UPIO_HUB6 (SERIAL_IO_HUB6) /* Hub6 ISA card */ @@ -479,7 +479,9 @@ struct uart_port { #define UPIO_MEM32BE (SERIAL_IO_MEM32BE) /* 32b big endian */ #define UPIO_MEM16 (SERIAL_IO_MEM16) /* 16b little endian */ - /* quirks must be updated while holding port mutex */ + unsigned char quirks; /* internal quirks */ + + /* internal quirks must be updated while holding port mutex */ #define UPQ_NO_TXEN_TEST BIT(0) unsigned int read_status_mask; /* driver specific */