From patchwork Mon Feb 26 12:15:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 206605 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2029236dyb; Mon, 26 Feb 2024 04:16:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVjrwtLN2SWACb7tOXfKx6Wgq2Wyjas3Vz1ShaN4tk4cnDLr8nys/7wvWIMXeZKUHBcrQiQrDNg+vmpiOlZ99e+qKzyTg== X-Google-Smtp-Source: AGHT+IEggJ9EzBXgRnpnSzFxcOGnFsNPqylxvmkjs3Tny1SlJXmNCBvIWequbw9wDGeYwLqjRDEp X-Received: by 2002:a67:cd09:0:b0:470:4712:58c with SMTP id u9-20020a67cd09000000b004704712058cmr3952714vsl.4.1708949779173; Mon, 26 Feb 2024 04:16:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708949779; cv=pass; d=google.com; s=arc-20160816; b=PAcfoSYdhBJ2uHq8YP0lp7j+A7+aaxdMq5AVbpvr9i6pZx696rZn8oSzN/UXReZvIA DxNrdy+mOK0oDM1DK23LpdAxIPfp6DMKVUM8HcRLqPzVV9AcizUdoK5psj1Oxccorebv pL0TfnECOH52m3LimfG1JLoh0suBeW0crxytQevXs5fyumnNTz62OqQ6g+i39Gd+pHP4 oe3TJ9iojOMXZ+9zYRDIVHgfkLnLkXg1ew0AYPqJnfotDBgKdC937pszs6sjhshPQnKS xaynO8cKqOFYD8PRplgOmFQaZ8rW28rzP/jZQD1Ukx35sk6Si4GLlCxLmnOOJzjtBLbE o/qQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=M/SpMyV0aHYk0YkI5VNjN4OVAy08gNiiUkrhkeRRy2k=; fh=8iIxM7S1L1tCYuAfice3nAWn6h4KsVFZx3QJc5VBQMo=; b=HMxfeuPctisWONnYkaXpFdZLPBKjdxT5ljwPGD45RehtDedMCBQQ+6x8XsKgYUR44h RAbe8ZpPwoHCLVDGBH2zaAJrp4vwWvmE9r7qF1KiU1U3euUTQIz2ZM0EIzt+mMD344sE n/WB4OmTJp7bzH4WxlTc5D8lBCloHUL/0amag8sq6YxbCpEJO9MR5iYHtuk0MnUw0NVR 0pYFz+o5TvVbHrLl+Mw9tgwQSiLoVTW0Spx4u4gPeeAeIxLT3g2eapfqjWqEbxyNWXI1 e6tlcSq8SDlj4476ok6AmXXv6/QyYEJtE+jVpEKrA1YrnnV4za1HYqKYcpAfn8YbT6f2 6QDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="BjE/PJV0"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81348-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v18-20020a056102331200b0046d22aa976esi492850vsc.143.2024.02.26.04.16.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 04:16:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="BjE/PJV0"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81348-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81348-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E94851C247B7 for ; Mon, 26 Feb 2024 12:16:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C15EF605DA; Mon, 26 Feb 2024 12:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BjE/PJV0" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A82F5604B7 for ; Mon, 26 Feb 2024 12:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708949765; cv=none; b=aPYPtnBlyu2Y85C3KidgjDSBist2Q8cEKSuZo9sKSgQjYQ/OTKwDBhHwIh60G9GyEqkxURZF6DwgQrAmr5UeJCUzUPhY9LndwQr9vekRsOHpvsvmi6bo50EG3qXjEMFwSnlkUQf90SV5BLW+hyZMsGIE37dtJsf9pTN7T6LUJp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708949765; c=relaxed/simple; bh=dIUCjHoNQgOf5LX5CDqGdhGVPI2lsfrC1oPUtvZVZCo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=siiSnrw1CXbPBtxatAx6p4pBCl+YdrPgPsqH1KLaQ1MnG6xwVPU2i4YTcJbRS79/F6wYOll9HQB4UQfsbG+Nw41/4cP0GFW02kpc3u2gSrgZNSGhe1YJU6eoDQfWWoQvFQJ9WprPENSy0cqbT5qDZf+Jr9MDqgLFZ5vdgLkGtMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BjE/PJV0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6338C433C7; Mon, 26 Feb 2024 12:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708949765; bh=dIUCjHoNQgOf5LX5CDqGdhGVPI2lsfrC1oPUtvZVZCo=; h=From:To:Cc:Subject:Date:From; b=BjE/PJV0v+5zRxcM8rFDX0y0HdQRjazPEjtTatnxIbu0sm1KaPw35w3HvJoJ0Nb4W taKWESXQeBJFOclrjZE9C+Ek2pqnYjj27AdjVVNmxyWmEYZ9++N92Fltmortj0RoqI PGPPJpF8I3P6jCd2wQWPrOSi7NsxUt9cs+SWVXCtEMahNU+mEkO8hKMiejFzbIkaRk BamAkSamVvchgalafebxbjTNkFCl3eDMhcj2F9Qfivm5MMD8kbEe78a74FeSawq/Lg QV3QbkbBR0HryGgeQGJaQYG8oU7XWB9mXGGytrRx1TobkJb0Pz6wKnLMNXiXfaAPKM nMEC7EVaSPxdQ== From: Arnd Bergmann To: Richard Weinberger , Zhihao Cheng , Arnd Bergmann Cc: kernel test robot , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ubifs: fix function comment warning Date: Mon, 26 Feb 2024 13:15:52 +0100 Message-Id: <20240226121600.1267204-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791963723726345920 X-GMAIL-MSGID: 1791963723726345920 From: Arnd Bergmann My previous fix introduced a new W=1 warning for the kerneldoc style comments: fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb' Adjust the comments to the argument names. Reported-by: Zhihao Cheng Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202402261559.cYtMOkIn-lkp@intel.com/ Fixes: ec724e534dfd ("ubifs: fix function pointer cast warnings") Signed-off-by: Arnd Bergmann --- fs/ubifs/find.c | 8 ++++---- fs/ubifs/lprops.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/find.c b/fs/ubifs/find.c index 6ebf3c04ac5f..643718906b9f 100644 --- a/fs/ubifs/find.c +++ b/fs/ubifs/find.c @@ -73,7 +73,7 @@ static int valuable(struct ubifs_info *c, const struct ubifs_lprops *lprops) * @c: the UBIFS file-system description object * @lprops: LEB properties to scan * @in_tree: whether the LEB properties are in main memory - * @data: information passed to and from the caller of the scan + * @arg: information passed to and from the caller of the scan * * This function returns a code that indicates whether the scan should continue * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree @@ -340,7 +340,7 @@ int ubifs_find_dirty_leb(struct ubifs_info *c, struct ubifs_lprops *ret_lp, * @c: the UBIFS file-system description object * @lprops: LEB properties to scan * @in_tree: whether the LEB properties are in main memory - * @data: information passed to and from the caller of the scan + * @arg: information passed to and from the caller of the scan * * This function returns a code that indicates whether the scan should continue * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree @@ -581,7 +581,7 @@ int ubifs_find_free_space(struct ubifs_info *c, int min_space, int *offs, * @c: the UBIFS file-system description object * @lprops: LEB properties to scan * @in_tree: whether the LEB properties are in main memory - * @data: information passed to and from the caller of the scan + * @arg: information passed to and from the caller of the scan * * This function returns a code that indicates whether the scan should continue * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree @@ -773,7 +773,7 @@ int ubifs_save_dirty_idx_lnums(struct ubifs_info *c) * @c: the UBIFS file-system description object * @lprops: LEB properties to scan * @in_tree: whether the LEB properties are in main memory - * @data: information passed to and from the caller of the scan + * @arg: information passed to and from the caller of the scan * * This function returns a code that indicates whether the scan should continue * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c index a11c3dab7e16..8788740ec57f 100644 --- a/fs/ubifs/lprops.c +++ b/fs/ubifs/lprops.c @@ -1005,7 +1005,7 @@ void dbg_check_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat, * @c: the UBIFS file-system description object * @lp: LEB properties to scan * @in_tree: whether the LEB properties are in main memory - * @lst: lprops statistics to update + * @arg: lprops statistics to update * * This function returns a code that indicates whether the scan should continue * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree