| Message ID | 20240226110820.2113584-1-o.rempel@pengutronix.de |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id
bq27csp1998643dyb;
Mon, 26 Feb 2024 03:08:52 -0800 (PST)
X-Forwarded-Encrypted: i=3;
AJvYcCWaZTMM3d0lsv1pG5E3kAwlTTkPDRuGfn6AXjlYSSlfBHlnn0TF/y7rkowJYNdj/RIqcbOHvYCs86np6rsZqpF+nn6H8Q==
X-Google-Smtp-Source:
AGHT+IFOg5OG7fltDu8xy1AEKosLEhEaCSzcgH9L/jjXMn4oh3Wktw4vuRjLSN+ZcMhpxJDbTq53
X-Received: by 2002:a05:620a:ec8:b0:787:84d6:8135 with SMTP id
x8-20020a05620a0ec800b0078784d68135mr5508346qkm.22.1708945731703;
Mon, 26 Feb 2024 03:08:51 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1708945731; cv=pass;
d=google.com; s=arc-20160816;
b=Q2d0Ckva+St/DkF4KLKeoutK1UoDKgJrhYiZY/qZs6wde1GRNiKh9j0L1U9HTmf9XV
T2R+rcGx3IsRy2vfpj9U2i+SkRB6EQ+kJ0RVkWnnb3N+ryUzLVd5kU529G2alCKY7m5G
vDd3gAScIRw3XV8ragwdNAYONdieTRN64+WQJ/ciFtpjCjoMEsVDTzIUIn1XW+nsZdhK
Qu2aUCHZ8E11COvzPxkUukERHwmtNX+ua5D9rHnmmHeAG5sO7zx6ZPvqgcsmeJ2ve+9J
+90sAAtok30HgZDQZK78APY6d7bNctNNflCxnYObbAfCPvN96Z9LaKbU1hk4LTWlfFdK
PCuQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:message-id:date:subject:cc:to
:from;
bh=NcDq1qWEty3GrmSdiQNAMmQGE+3xREv3uriI4WyZhVU=;
fh=NxilBuiqz+2U7sXeqs9J6pTxX3FVKueJylk5PSevRpk=;
b=diiu4wRxh9R0hPp0WsepupGFiTDvlAiM37dHBvTacOy1YC3MW7rFQcJpMuLrs59bkm
Y4rVYvg1jzmHthXMT9bkUo0nor3E2qt0SDdtsqwVcxwxATuQLITyiIyNa92xP1nfqNj5
hL28zIcUJs/Grn/k2pT9X2udP6hyx3yHRcZaFVlTvlTi5nzHwJY4XOqhiYOhz+Cr624R
HgFxKnBCMRAzYM3qnBK/cF2IZNd0Cs3WPLRICQbPqHSyliKNX0RLxyLKTVJuQwg5MXJT
mrbk79EdTrYjLszXjHZ0uCXvOFFmBJDB5pjcY3Id6dtAwRFkIdFg4VE3+DYp0rvDG1i+
tUiA==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
arc=pass (i=1 spf=pass spfdomain=pengutronix.de);
spf=pass (google.com: domain of
linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org"
Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org.
[2604:1380:45d1:ec00::1])
by mx.google.com with ESMTPS id
y11-20020ae9f40b000000b007871b8ebbd0si4712800qkl.568.2024.02.26.03.08.51
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 26 Feb 2024 03:08:51 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Authentication-Results: mx.google.com;
arc=pass (i=1 spf=pass spfdomain=pengutronix.de);
spf=pass (google.com: domain of
linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45d1:ec00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-81251-ouuuleilei=gmail.com@vger.kernel.org"
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7D0921C280EC
for <ouuuleilei@gmail.com>; Mon, 26 Feb 2024 11:08:51 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 39CBD1D543;
Mon, 26 Feb 2024 11:08:34 +0000 (UTC)
Received: from metis.whiteo.stw.pengutronix.de
(metis.whiteo.stw.pengutronix.de [185.203.201.7])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3161EB2B
for <linux-kernel@vger.kernel.org>; Mon, 26 Feb 2024 11:08:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=185.203.201.7
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1708945712; cv=none;
b=hsQ6LMLxkwArUkLheWwIw/i86Hh1GlO10SK1DOyZaHz0W6O2dwVRRqyCllFo4TD55Om44nm1vp2ypZsu0kqOfgeLB/hL0r61YGWAeO/eR0lXkW0Arb0GL+4Zd6HgngIzqU/xVWQi6bjfXu6MQOObhkzo7D39skO+yOjjBLjhO8s=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1708945712; c=relaxed/simple;
bh=qr8hL1g7sAkBTasKdRNUXXfQV4F3/3ixv1b1xAVXtwo=;
h=From:To:Cc:Subject:Date:Message-Id:MIME-Version;
b=mONTotKO4LtyWwE/jGW7gaB77tt6MMwclYg69pKUBMnfkcMhalOkXR48I0So56uFgdZi9sDewxEFkOuEsOh/MA3pjtF/sWq2y3ovEC2i91pPHCLFTpKa44fz0snocFgR0Btu85V3OPODizEBfDcV6IsXnQ11L+kJsfiWvtieiTY=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=none (p=none dis=none) header.from=pengutronix.de;
spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7
Authentication-Results: smtp.subspace.kernel.org;
dmarc=none (p=none dis=none) header.from=pengutronix.de
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=pengutronix.de
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
by metis.whiteo.stw.pengutronix.de with esmtps
(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from <ore@pengutronix.de>)
id 1reYqM-00077Z-Uo; Mon, 26 Feb 2024 12:08:22 +0100
Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de)
by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.94.2)
(envelope-from <ore@pengutronix.de>)
id 1reYqL-002yub-BQ; Mon, 26 Feb 2024 12:08:21 +0100
Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96)
(envelope-from <ore@pengutronix.de>)
id 1reYqL-008rqN-0w;
Mon, 26 Feb 2024 12:08:21 +0100
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
kernel@pengutronix.de,
linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error
Date: Mon, 26 Feb 2024 12:08:20 +0100
Message-Id: <20240226110820.2113584-1-o.rempel@pengutronix.de>
X-Mailer: git-send-email 2.39.2
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: ore@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de);
SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1791959479747193652
X-GMAIL-MSGID: 1791959479747193652
|
| Series |
[net,v1,1/1] net: lan78xx: fix "softirq work is pending" error
|
|
Commit Message
Oleksij Rempel
Feb. 26, 2024, 11:08 a.m. UTC
Disable BH around the call to napi_schedule() to avoid following
error:
NOHZ tick-stop error: local softirq work is pending, handler #08!!!
Fixes: ec4c7e12396b ("lan78xx: Introduce NAPI polling support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/usb/lan78xx.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 26 Feb 2024 12:08:20 +0100 you wrote: > Disable BH around the call to napi_schedule() to avoid following > error: > NOHZ tick-stop error: local softirq work is pending, handler #08!!! > > Fixes: ec4c7e12396b ("lan78xx: Introduce NAPI polling support") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > [...] Here is the summary with links: - [net,v1,1/1] net: lan78xx: fix "softirq work is pending" error https://git.kernel.org/netdev/net/c/e3d5d70cb483 You are awesome, thank you!
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 7d7e185d7fae..3ff430198512 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1501,7 +1501,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev) lan78xx_rx_urb_submit_all(dev); + local_bh_disable(); napi_schedule(&dev->napi); + local_bh_enable(); } return 0;