[2/2] dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants

Message ID 20240226073713.19045-2-krzysztof.kozlowski@linaro.org
State New
Headers
Series [1/2] dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: |

Commit Message

Krzysztof Kozlowski Feb. 26, 2024, 7:37 a.m. UTC
  Only few variants support PPG and store LPG per-channel data and pattern
in SDAM modules.  Disallow the nvmem for other variants to make the
binding precise.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/leds/leds-qcom-lpg.yaml          | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
  

Comments

Rob Herring Feb. 27, 2024, 3:47 a.m. UTC | #1
On Mon, 26 Feb 2024 08:37:13 +0100, Krzysztof Kozlowski wrote:
> Only few variants support PPG and store LPG per-channel data and pattern
> in SDAM modules.  Disallow the nvmem for other variants to make the
> binding precise.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/leds/leds-qcom-lpg.yaml          | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
  

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 699db7995dd5..54a428d3d46f 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -130,6 +130,26 @@  required:
 additionalProperties: false
 
 allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,pm660l-lpg
+              - qcom,pm8150b-lpg
+              - qcom,pm8150l-lpg
+              - qcom,pm8916-pwm
+              - qcom,pm8941-lpg
+              - qcom,pm8994-lpg
+              - qcom,pmc8180c-lpg
+              - qcom,pmi8994-lpg
+              - qcom,pmi8998-lpg
+              - qcom,pmk8550-pwm
+    then:
+      properties:
+        nvmem: false
+        nvmem-names: false
+
   - if:
       properties:
         compatible: