From patchwork Mon Feb 26 02:27:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 206176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1831496dyb; Sun, 25 Feb 2024 18:28:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXQULG1iq5TCGYklgQAh43396MPnsjvk0MSlLMoBuXtSEaJm6Tj+9p3rR09Zeg/CJLz9NSpuEF/03IA7HmufCH5k5sCxQ== X-Google-Smtp-Source: AGHT+IFGekwRlG3WqR5LY4TVOM0hlZMyh70BXyv3F30/dEi/8uw8nYGgxPlMbuWE3o6whmCYz7nq X-Received: by 2002:a17:90b:24c:b0:299:2807:1eb1 with SMTP id fz12-20020a17090b024c00b0029928071eb1mr3792403pjb.34.1708914528107; Sun, 25 Feb 2024 18:28:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708914528; cv=pass; d=google.com; s=arc-20160816; b=a8ZWbB6ts/Q4el/Wbwxc6QgO/vyL8bpvtOibOj4ZWTBMeUoi1exPexpJRtnF3LitDZ a8SrVcihyHgWuvIqHB4I0/un9buohgY3Vk8WaScZJYVOJS/BHwcf52Kd0K0FFZg0OB6d 9Y6xZL6PeyLUvrqQSKN+Lw8b87WMCpJVk1bwWDbj3Dkuk9x3qnJBxNZ/vk9RQOIUu7Kk bsO4rA+1KeN6eMjx6JX43X4qncWzz8Feivei7Dh65UKZM5ns/aZuIo2fbrF77L3BtNQz 8Ftfo+UTIvDzXYSwm3M6gSpKqfq27GfyM+JS02WFygMClfr5g4eQkRrG1rzcGeHpUN9K vMLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=8UIRQxSlc1BHlT1FIxTW/PhTeczKV/3fX3odMQFOFMs=; fh=cx0XWODR4Vto/MNKVPi7h0E6sxd78bJ66Je4iCezPcw=; b=dqEUvgtVudOns46Teed9NV6r2+57YXGkIGA+tm+ssZtGMNyaHNFpLXHFdX4Efbthcm NNw1KIpRFHfkc/nNsbBWzmD+ciQT9qp4UC/oR4dQPpBhAsN3gA75kvpfZIuBUaUqDs3A kIOxtRi2FG6VW2YQERrcy+gQZ8/Dwc27nQ+Xvap+ZhdGtINvAfggkY2GN0bLdoJQG3AM EK5A9ZXN632cB+NOInIwYhxFGN7Yx8Fc8TZlxi0z/qjdcyip8cqOm4tSnVN5NSyt7H1w NiZ2gkBkAT+znF2Sr9EAxV/1GuVG4uNOfc5O7y/ivUjN2ls3gHj/3sFkAxVj7ELWNWNx LVZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="XN2Tqa/8"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-80409-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80409-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r6-20020a17090aad0600b002995b3a3d71si4764909pjq.64.2024.02.25.18.28.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 18:28:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80409-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="XN2Tqa/8"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-80409-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80409-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B52D0B20E56 for ; Mon, 26 Feb 2024 02:28:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 374221BC4A; Mon, 26 Feb 2024 02:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XN2Tqa/8" Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CDD717742 for ; Mon, 26 Feb 2024 02:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708914485; cv=none; b=HpHTK584FDFm/3lFpeD9l90nNCXDsfsqZLgMjOgc8I+tK//w3ZV4w4Q3WCaxfCspTcU7TX7mIH8Rf106HQZMqP5lG8Ki4WcN8+wl2iGdYFgIWFTly3EGNjz8t+ZI+5e+lMCnkyPm4PC6zq+E3hTz3Y2MNSKQrXMzg6w4zQRgJ6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708914485; c=relaxed/simple; bh=u/LLMAwCactui0InH0azxw69mOb5zZdT0MKFe0dxyYY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FobqB26BnPNwc1XjpN2ZVkQbvuIjgqv/ovL9UIx5ZdkjO101uaL4qWyJ1dZXHNiUtsqAYjRYhoE3dTiEioWVBBxvt088ow1HZ8Mi38E3KtF3q86YG5ZS/c3SQ5hLzpxR+F5AwXXKlFSmFUmAVwjlCUCF6YMl6LrhVJzqkcc9wF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XN2Tqa/8; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d275e63590so29227401fa.2 for ; Sun, 25 Feb 2024 18:28:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708914482; x=1709519282; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8UIRQxSlc1BHlT1FIxTW/PhTeczKV/3fX3odMQFOFMs=; b=XN2Tqa/8zwMCnhvoNfs1FcIz11HAkltlEruzwc5giPt77bcgxjlUTO8cO0CvDbeVN9 wBApWDgVdVTxT1dNzLctY0jNVySgEe93XdXPBtKCjTIhIcw3PH6UbVMRc9GxBn/jqSl8 FIDXeeS7nVkGMJIkNCOLFNuLo5iSSSFPeY/Ygs80EUE5+lKi2+r00A+Y9zWl7cCYltW0 bESC4qwLi6jl+e126tx6X2iFmKzUIu5igLn8Lm70Jk85rjrvm0mRQIXqwToI+vYtTpjq wqyDXcFeyZ4BYlwpjGxnySG1Yxrf+UQg0GdYiS4TI0DDNdwjaWDWNp9ZlKvcIZAizffO f6xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708914482; x=1709519282; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UIRQxSlc1BHlT1FIxTW/PhTeczKV/3fX3odMQFOFMs=; b=kqmmNlI3C882DwwtvZtBs6mv1bSaiIi4K5VeAi2l4ZYQBqYPfFpqGj6RKrXhhdfJcA cP2S2pwgJ7P40qQ0h9JKXI8DaSyKs5GxaSnkVZe7IFeRGM1EKAQUBdsGDcvH0JhoAR8R utma8ADpHH7L6g5j242k2u8EZVAXT39iE98PhFgpL1pNWS4dwxrzjxqSCCk+nywLTuGO rO0A+T8E4po0H+cyyvC4HEAJbTHva8F/WDDiEBDT2OFHw7s8lETXM+e7Tw4IJmlyQEW7 jdPqMjCF6d+iFV6uAKwyQjpnYT0SFjix4oRsLhjw7TANCfsPcXNbgOaqdR54keBe2tuA eAKQ== X-Forwarded-Encrypted: i=1; AJvYcCXxHuKFxOiwWo9bdlxmYNg4Qmvy8IvfAz13eTUbqYob825THhZUAQbnMr8+Kn/LvvPJB9puK2NTrrKtQd37Yp93VTAYpL7Eq8dBS2Ms X-Gm-Message-State: AOJu0Ywlc7E4V9ooTbg2WM2HzBDVMKXqiIQ6llI3QuanmueQUfve9yAY vRGuhXAt6Alaeyu2vkHthOmCkzONs/OEJrLw1V+7nCfqP5wMiR+/olvuf/CvA80= X-Received: by 2002:a2e:87ce:0:b0:2d2:8a86:e5d4 with SMTP id v14-20020a2e87ce000000b002d28a86e5d4mr907780ljj.21.1708914481698; Sun, 25 Feb 2024 18:28:01 -0800 (PST) Received: from umbar.lan (dzyjmhybhls-s--zn36gy-3.rev.dnainternet.fi. [2001:14ba:a00e:a300:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id u19-20020a2e8553000000b002d11ef66881sm713092ljj.91.2024.02.25.18.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 18:28:00 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 26 Feb 2024 04:27:59 +0200 Subject: [PATCH v4 1/3] drm/msm/dpu: make "vblank timeout" more useful Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240226-fd-dpu-debug-timeout-v4-1-51eec83dde23@linaro.org> References: <20240226-fd-dpu-debug-timeout-v4-0-51eec83dde23@linaro.org> In-Reply-To: <20240226-fd-dpu-debug-timeout-v4-0-51eec83dde23@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: Steev Klimaszewski , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1113; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=u/LLMAwCactui0InH0azxw69mOb5zZdT0MKFe0dxyYY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl2/cv3wmpf4E4iBAzHWRmMIm2xXfZ9nq0MLbMk UhPkkONCbSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdv3LwAKCRCLPIo+Aiko 1cuxB/9yyz8H/zy2dEohWWy29s9WbXojtz4t+WYhhbEzbRHqJkpqoSL92QjfIFdLuv/iJWazADD tuZyzZgMYyO1Qqlod5lZXLlm7WoelkQGBZzk3xoFSpQWM16HypNWEmxwkgaqyGfos3Alp+L9T4t weBlSTgaKeo2WlkB48Rzmk8FRuaPyoQymxyixCFUUb1hy4RF4+XCm0U3wZ8H9d3bdobv4Vu76gG IplHCwPOr5aNPomk0hJuxBB6hxHgHPUB9cAuFxKwp+iu6zSXJXUsiLwzFU+9L2hLEffhsycs3aF r/Nz9q77g0+W4klVprofqOqI38IMGl7grLFd2vfRAJfyntSP X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791926760098274536 X-GMAIL-MSGID: 1791926760098274536 We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout message. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index 2aa72b578764..6058706f03e4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -480,7 +480,7 @@ static int dpu_encoder_phys_vid_wait_for_commit_done( (hw_ctl->ops.get_flush_register(hw_ctl) == 0), msecs_to_jiffies(50)); if (ret <= 0) { - DPU_ERROR("vblank timeout\n"); + DPU_ERROR("vblank timeout: %x\n", hw_ctl->ops.get_flush_register(hw_ctl)); return -ETIMEDOUT; }