From patchwork Sun Feb 25 14:27:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 206025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1599856dyb; Sun, 25 Feb 2024 06:28:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVsHIO0f4dLYyh8gTUK54ivakK71HLTXZnLTaxawOE1vuigeM4qRYv2J5PCV6jAg1vfcXS/TjKARWUkJi+BBSCsFgYC4w== X-Google-Smtp-Source: AGHT+IHPG9RTEbtm4YRmKdhE17JcoVWhqUkq3upBccvJEcq4u+KpZTFU7FbEK84px9bXtLbl/PkJ X-Received: by 2002:aa7:c999:0:b0:565:eda7:c12b with SMTP id c25-20020aa7c999000000b00565eda7c12bmr248525edt.0.1708871322486; Sun, 25 Feb 2024 06:28:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708871322; cv=pass; d=google.com; s=arc-20160816; b=f+wUyyzmRnRb9GW9yNow/VoFHKUD70gQD71n6lATsR2DECtiVSrVoMyIxUA96KSqg+ nXLnoZNERbfnjtBbto0BocvT3m7+pazRpDKn/yi6k+R77SaEzXPCA0/UX/05ojkpy/e3 7mkENb/DuC8eRkibC6eXTKvvAHDKJMxXSBiAPtcNdhjjgJ4cF5Y9AIwJF51gIgMA9kl+ e9Me4H6budNywI4xeoEJuSe1Mc/lMZXIRaGx83ZcerG0FEeeX8nfI0tefqat50NWpY4O GELwv6g/UQhTgdyghrRwyf7AscccwwSa7ED76cEG9DmoYEr11O063+Du5uax+mfNMCzn 4Z3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=qiON56UoXU0/uGWTYEp8exutI6n25nxHKy9cdV6V1e8=; fh=PiZ5V/4sGLDov5cF6A5wY5iqIfZAXRefEy8l5uZe2FU=; b=uko/3aroNTdEt2nba59rLH2WK4puTKiabtQN+dkaU4G5F1QgVgQFMXwwni8k0OBO5N Z9HFXs/+ty0VJ/QvUTEEdFrUZpsW+kjIyJO0yLjA59RPLvBSz/iH5JIN9xRhaj8rrw/W eyZK1hMiwJouuce9aXbG18UYKYhNgPapPYRpW2/6XZzEJ0V89+OupBsvxJ9BXKQnX8dZ l57ATswAbs0iBJ6E5Y66r3GsfjsR5C3tTOi3uPqaYjOY0Yvgejz2PbvV8O4PRQ/kkKQ5 fV+JnvOPfQNilS36eUWDZ0ARGzzKXWq04pkXOPX7zos/LSPEBtetWL/lGhDKDajjQtSs 2KiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DihQqm1c; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80100-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80100-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id cz7-20020a0564021ca700b00564c1ac8428si1317961edb.273.2024.02.25.06.28.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 06:28:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-80100-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DihQqm1c; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-80100-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-80100-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1C22D1F21343 for ; Sun, 25 Feb 2024 14:28:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 94577175AD; Sun, 25 Feb 2024 14:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DihQqm1c" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E923317579; Sun, 25 Feb 2024 14:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708871267; cv=none; b=i/FW5lnaTLVaea9twjxeIvTOFFHpz9d2ZRc6PPewC+pAG5hp3Ps4TNoJf5z8H9CU+c8m/a9tgzwjmXUnINCI5ejPscxKSLgI/cqDTa2fcMDwk4vWrA1wAIKDoFI5WbN/0L60mLumH+U88W1JuFf/zt6ZTIOFP++HeqH2OxLZTsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708871267; c=relaxed/simple; bh=cy3xgv+zOTeCfTawrekO50j/BQnaTUqEu6LMlwDPXkg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sthZvdpeyNhFLDh8vQdyv/tuAg31UxW2A+ZMDg7qBiOvxX9KtjHG8Zr48viSz9lKbcgjzPBuK2CT1gO9Lr1RPQZzr6gC8rZNTFZ5JcNn9gXmscFzlpvWTalOyThqwhxdewIJAmhNBxA1nkBl3lo99I0S4EfcVh4mbPkx6w9mbKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DihQqm1c; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4E28C433F1; Sun, 25 Feb 2024 14:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708871266; bh=cy3xgv+zOTeCfTawrekO50j/BQnaTUqEu6LMlwDPXkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DihQqm1cO4S4hEX3mO7srDwzf8AMPmNm9EXTEwCUb5Ft61bHiQ/1Ti6VC3WR4TSt0 C2VD+yTN7u2+bDQISJ+ctCCUE/NkwCiU0/44ISX3U/OQjEK9Oy0LczGoor0eHlMCf+ lU8DVnp61JzDLpAIiUV6x51vVmXtjtRVKMxci84kwkJ4f9vYDLyiuiPzMeRjaXH/9O BGmTIx5qtzD9+05iKnUJKA/fCGOcYlo3JMAc5hjfITNSRzZnZGz3dr649kKpmSKkeB kwSNQp00qkqbm8g+kaVgvvk5KInutdjD7x67aAoUKdFq/qY1pz9FYHXqOyCNH7A2im 907Ychz4iLJIw== From: Jonathan Cameron To: devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Rob Herring , Frank Rowand , linux-kernel@vger.kernel.org, Julia Lawall Cc: Peter Zijlstra , Andy Shevchenko , Greg Kroah-Hartman , marek.vasut@gmail.com, Jonathan Cameron Subject: [RESEND PATCH v2 3/4] of: unittest: Use for_each_child_of_node_scoped() Date: Sun, 25 Feb 2024 14:27:13 +0000 Message-ID: <20240225142714.286440-4-jic23@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240225142714.286440-1-jic23@kernel.org> References: <20240225142714.286440-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791881455840810848 X-GMAIL-MSGID: 1791881455840810848 From: Jonathan Cameron A simple example of the utility of this autocleanup approach to handling of_node_put(). In this particular case some of the nodes needed for the test are not available and the _available_ version would cause them to be skipped resulting in a test failure. Signed-off-by: Jonathan Cameron --- drivers/of/unittest.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index cfd60e35a899..d353327767b3 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -233,27 +233,22 @@ static void __init of_unittest_dynamic(void) static int __init of_unittest_check_node_linkage(struct device_node *np) { - struct device_node *child; int count = 0, rc; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { if (child->parent != np) { pr_err("Child node %pOFn links to wrong parent %pOFn\n", child, np); - rc = -EINVAL; - goto put_child; + return -EINVAL; } rc = of_unittest_check_node_linkage(child); if (rc < 0) - goto put_child; + return rc; count += rc; } return count + 1; -put_child: - of_node_put(child); - return rc; } static void __init of_unittest_check_tree_linkage(void)