diff mbox series

dax: remove SLAB_MEM_SPREAD flag usage

Message ID 20240224134728.829289-1-chengming.zhou@linux.dev
State New
Headers
Series dax: remove SLAB_MEM_SPREAD flag usage |

Commit Message

Chengming Zhou Feb. 24, 2024, 1:47 p.m. UTC 
  From: Chengming Zhou <zhouchengming@bytedance.com>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dave Jiang Feb. 27, 2024, 4:29 p.m. UTC | #1 
On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  drivers/dax/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index 54e528779877..cff0a15b7236 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -547,7 +547,7 @@ static int dax_fs_init(void)
>  
>  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
>  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +			 SLAB_ACCOUNT),
>  			init_once);
>  	if (!dax_cache)
>  		return -ENOMEM;
Chengming Zhou Feb. 28, 2024, 3:16 a.m. UTC | #2 
On 2024/2/28 00:29, Dave Jiang wrote:
> 
> 
> On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
> 
> Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete explicitly to avoid confusion
for users. Here we can just remove all its users, which has no any
functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>> ---
>>  drivers/dax/super.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
>> index 54e528779877..cff0a15b7236 100644
>> --- a/drivers/dax/super.c
>> +++ b/drivers/dax/super.c
>> @@ -547,7 +547,7 @@ static int dax_fs_init(void)
>>  
>>  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
>>  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
>> -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
>> +			 SLAB_ACCOUNT),
>>  			init_once);
>>  	if (!dax_cache)
>>  		return -ENOMEM;
Verma, Vishal L Feb. 28, 2024, 5:32 a.m. UTC | #3 
On Wed, 2024-02-28 at 11:16 +0800, Chengming Zhou wrote:
> On 2024/2/28 00:29, Dave Jiang wrote:
> > 
> > 
> > On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
> > > From: Chengming Zhou <zhouchengming@bytedance.com>
> > > 
> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > > its usage so we can delete it from slab. No functional change.
> > 
> > Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
> 
> Update changelog to make it clearer:
> 
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
> 
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
> 
> Thanks!

With the updated changelog, you can add

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

> 
> > > 
> > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> > > ---
> > >  drivers/dax/super.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> > > index 54e528779877..cff0a15b7236 100644
> > > --- a/drivers/dax/super.c
> > > +++ b/drivers/dax/super.c
> > > @@ -547,7 +547,7 @@ static int dax_fs_init(void)
> > >  
> > >  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
> > >  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> > > -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> > > +			 SLAB_ACCOUNT),
> > >  			init_once);
> > >  	if (!dax_cache)
> > >  		return -ENOMEM;
diff mbox series

Patch

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 54e528779877..cff0a15b7236 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -547,7 +547,7 @@  static int dax_fs_init(void)
 
 	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
 			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
-			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+			 SLAB_ACCOUNT),
 			init_once);
 	if (!dax_cache)
 		return -ENOMEM;