From patchwork Sat Feb 24 11:45:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 205831 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp1105616dyb; Sat, 24 Feb 2024 03:48:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVY3N8uz/XD/GdY4TJviiWK3d6Mj5nxaIuOe+TwoaDE1hNvqycU44EEcxaTBFfkU2zzDfI4RnTNiy3OTcvmLdSvpTvy2A== X-Google-Smtp-Source: AGHT+IE6T+yzQvt6/F631enrfw0Kq8GuDx4sXcSilsKz4XMB5TI+h7tFviVqcw60jcZQVtqrAm3o X-Received: by 2002:a17:906:470e:b0:a3f:eff9:7f44 with SMTP id y14-20020a170906470e00b00a3feff97f44mr1377253ejq.61.1708775328007; Sat, 24 Feb 2024 03:48:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708775327; cv=pass; d=google.com; s=arc-20160816; b=Acsxf4FbDBZ5KmOxeEbLWvb67iMeqCq17YuLyP3M7inyKgaU5oFILQJgdYVJkw43h3 Bth695L2nW/mMKyyR4GkHMWNfTC9VfT+WcENiOt1YXc+18aOfYdPBrEKS/pud5y8Busl iibhiEP5yhSRzN41PBeUZGj6rYb9Kcspk4eWrwaQ0IsCMjWAjHpAhXR5ZNzJ6uQRi9bt lAYPLt7rEykMy/kl3DZxA7zJmqc7D1CG+Tc6yfH0VABT502lCK5QKMTxSqXTd0WE+IvG Ot5tPADE7ktMNcVdDW92BID6S6n0oZVOfjgCmPy3GKHyLrB4j8s8GvgaZnJbNpRs1UJP HAtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Y492RWEJd5wja5KAvcbQOaDOMx8y5RKUhmHOdEQLHO0=; fh=HQ5KWliOAGNv4a+DFJ4mVsHelzfgE9JqLETPCZobwJA=; b=hx6JmzhaS+f4wKCB1nH72I5SlQFs8j9HzknOS+zDMLlsQBpS3vLCdjnVWGYc2cSCWO MwXpCEFPHo0wpKNZoczh7mzLvDgLYpHapThn8FXwGYWV7BJZQXZCCMgfzuaetLPqNl5g 8Suy6CVsb1wbdW5zwXnq8SlgXqxBHU0CFi2/zuAvLu5NW0kFAF+Y0Vz5zTTmCxpLhatJ uMNwDL051ar8i1M51nB9YT43Vtl5RaADD4cx/LAXZ9mbukNoiIHsxOllmOgPj8psto6y hHD3avQ4DuLFmmejf8OzP1GnNOYmbFBWOT+RE+KgYTSLrqo3s2J1cyb5C9o7oOpv+b4W elkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5AWNTxo; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-79614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79614-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id xa4-20020a170907b9c400b00a3f70bcbfdbsi464323ejc.271.2024.02.24.03.48.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 03:48:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5AWNTxo; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-79614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79614-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 938001F2267C for ; Sat, 24 Feb 2024 11:48:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2D774CE0F; Sat, 24 Feb 2024 11:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J5AWNTxo" Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F3D7481DD for ; Sat, 24 Feb 2024 11:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708775158; cv=none; b=MGuQQDQR1t2DRE3G9f0SeQ5f9tpSTJZV7+rURIUnCiS+lNg7dwePnF9l5h+ZhLX5yHbbaUV1XrxS6yJ0/+pH4Ykj3yMyNKLf6aOfkPxq/bizJNjJ9cpAmaT9K6wwFkHKGkxcVLIqOF5gRblcdL00y8actKlYjGbO37UOOGLpF8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708775158; c=relaxed/simple; bh=LM+xTq6J4+xN/3hkhq0Y8g9M/pd/4r9GnJzSkbJ03lc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q43u2acp0GBPWYU+fXoFAOc+eUkmdReU3uttBTN9Y6f6vpGIxt3dux35dYEEHCAmTst4vkNfmSEC65bMqL5ScSF4ol3h2gXMfAnYXjvu1kwlrIHpOJQh/Yslbp2uMwZ6sLWuOZ4Rs/zlMKZQNlQFq1KQHTDO4UUAcjwYzvaYA6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J5AWNTxo; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a3e85a76fa8so151274566b.1 for ; Sat, 24 Feb 2024 03:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708775155; x=1709379955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y492RWEJd5wja5KAvcbQOaDOMx8y5RKUhmHOdEQLHO0=; b=J5AWNTxop2RDkptAX2nvIAIuSz+2DOVXOtSreC06ZCmveGDTJDipw+U9NzBTkKxTnM WV35HPtCe/w093DGNEJKg22URcSJ875p+iaY61DeDJfyvpyPP+WSDqnFvBZi8r2lX/Pq 2EqSkZCJjdpv2g9IpTSZ20A3gxsmWdsdJdLbTHW1vbJkWvUsyFuhwbxRy09jBYhmkaG/ YvlWZoqRcoQnEUMxV4VEiXrIi0u7lyi2txaWn87xHmdG+3r/JtTq8znan1OXpjbujVTW /stZ1s/LbhPGQ4AEzsz7GA9Ej9P7b7arj7wVZqwH+eOxelzJYC058FpzGHmBn2T+I9sP PkyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708775155; x=1709379955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y492RWEJd5wja5KAvcbQOaDOMx8y5RKUhmHOdEQLHO0=; b=w6yNN25q9ZwaNMl4J2RMokB0zv9aIZgMJT2Tl/dPecQZ8fxIuckPlBT9W9/tUHf4jW pUlX3oKAFKmX2R0uSmJB162qNA7ntUp8Xv7bscYJovA1jhHmCmWjnav7nv1WkAiwrh6A n/6eLENtcm5HuLG+eBGLXIOg5bz1nd+2X26hYWI1xu06Jb4k/0dkxXNoBYVR0BTIHMLM BQLnrmgYjxwjvkt0F91aVB0Qd3tlMxuo9vpNfYFjpS4vrCZpgjub30gfYHnx7IQxKiNe Tfkki6omvFdVbSloaZksMZjZTa6vCR4HhbusLYMqbLd4kGE9tnyKAUi2A6h+oUHUszru hDKg== X-Gm-Message-State: AOJu0YxCHoSm0lzsqkAKcBiIaqw9pVw2v9Aqwzl9yHU2dLSwwyWKIIyG Swzs/uTX34sCfzsPUYCFJxeKlWEb9cu9kvSmbIDjHNxKVbhytZzpVcAbD0JtfeI= X-Received: by 2002:a17:906:c448:b0:a3e:9e4d:dafb with SMTP id ck8-20020a170906c44800b00a3e9e4ddafbmr1336122ejb.29.1708775155042; Sat, 24 Feb 2024 03:45:55 -0800 (PST) Received: from localhost.localdomain (82-132-212-111.dab.02.net. [82.132.212.111]) by smtp.gmail.com with ESMTPSA id jp10-20020a170906f74a00b00a3e209b225asm517826ejb.43.2024.02.24.03.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 03:45:54 -0800 (PST) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Markus Schneider-Pargmann , Srinivas Kandagatla Subject: [PATCH 11/11] nvmem: core: Print error on wrong bits DT property Date: Sat, 24 Feb 2024 11:45:16 +0000 Message-Id: <20240224114516.86365-12-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240224114516.86365-1-srinivas.kandagatla@linaro.org> References: <20240224114516.86365-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1055; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=uroTY94WYSRKwirx4GTT/pxJsWbg17Tq/2L7JU2HVts=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBl2dbM9vgaNdhVQEZmZBLe9WFY1YItaepN6vO/N t1fl0xkOKiJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZdnWzAAKCRB6of1ZxzRV N21CCACZw7dzFNz2c+Re7cGe52bU1nOZIU1SflLg8Nayn7PrEGrDbAhu5rvye+voYX/rxJ53GV3 VcGABSvqlIh/vAYBlmCAJGFGmR+7eZsj7GTmzREqhNFX3/Sa0dYavhxqwV7PCuIS7f3kXzHmTQB SsK6F9l739Ev+3AYMjz0WdemRzIL7rKA8uABZLQFGweCG19Ugy2JNper9Sv0128qunofkyjPmXQ x+I+zEb7dX1o6umTUV8pOtsl0v96d3hmnInsLc15nL6KuVPfZD0Zxmljp0MVNKggmkY3MrxuBue XogfKiIuhwL/vLLaNNfV4X3ahVjqhM0d8xNcuN4aaD0wGi/K X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791780798221313398 X-GMAIL-MSGID: 1791780798221313398 From: Markus Schneider-Pargmann The algorithms in nvmem core are built with the constraint that bit_offset < 8. If bit_offset is greater the results are wrong. Print an error if the devicetree 'bits' property is outside of the valid range and abort parsing. Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 980123fb4dde..a9832b5a608e 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -806,6 +806,11 @@ static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_nod if (addr && len == (2 * sizeof(u32))) { info.bit_offset = be32_to_cpup(addr++); info.nbits = be32_to_cpup(addr); + if (info.bit_offset >= BITS_PER_BYTE || info.nbits < 1) { + dev_err(dev, "nvmem: invalid bits on %pOF\n", child); + of_node_put(child); + return -EINVAL; + } } info.np = of_node_get(child);