Message ID | 20240224052436.3552333-1-saravanak@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp999306dyb; Fri, 23 Feb 2024 21:25:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVjipViqzGLWoleItZzTgnXqU3jsd9yfGZM8kPC4jZOXgRa0CNx6e+0m52wqo8azAA6/DUbBeRQlYFKqDLQK7yxVf0P/g== X-Google-Smtp-Source: AGHT+IFDLOIpeW9UnEG6qDeI472qzD3zuPxEVGXq5gy4OqNv6huPsi+jbO6gHScQQw8dgnabp3Hu X-Received: by 2002:a17:90b:124d:b0:299:32ee:a426 with SMTP id gx13-20020a17090b124d00b0029932eea426mr1416018pjb.32.1708752330845; Fri, 23 Feb 2024 21:25:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708752330; cv=pass; d=google.com; s=arc-20160816; b=qt4OZp0AD1rJ8lV3mdke7JRqmR6Eho1IsjzSlDNtr9iF3VPTLBdA2iIfkcgCxDTT8c W3MnR+EEGcteas4hJ9Mj7tY28z27QlrXMktgQHhP00ez7eDFEpR49/QUpxsnqKN3Ztuy FDXrRxSUaT1FENbeuuQ5iTQc7xBBcY6K+k60NdQyQSA7qHCvvD79Q0Nph5WWK0hpp+T2 PCBHOhXR3YVC+TYpdnJrr2q/ibqW5/LCKKcA0c/PSfkvf7Ag0TTk6hasXSOT2nL4h1o5 JOpUDDBRxxcZo9MG2ygtlKNxJxHvOqkPC555H5C2d5m2ez7aUZzE4Z+P9kwdm1cQ28hn NIbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:date:dkim-signature; bh=NmM7cCBUfnsEzWOUWxpGwPzttTnkh5grF+m9vEmGQ0Y=; fh=FqgWhfLD7twtFHSr04S0Xg0owWJmHCjvUJ3QLXHVI6k=; b=nwrmYYNmSQfzgxnIhZCp/avFVEy2F0KCpeGbgXAbcd1Dm8RTnk/0pQxICxid/9dp42 X8KK4M0ffBRlBqoWdjSH8+EGHIDxgfBXmZ9TNW9YMA3JhD/1vBy4WJ3myJ8fnw/5Ksjq Hmy+iWsXgv9Z7QioYh3B7xZkTCJSo1Spi6DjVDaTsNjELyJPTuSz/2w8+dIlJ9KdWDBA WsEq+5UnqaAoCJAoIvCcdjg43RGl+QcDiMVHJ5ZNUVdDQofo4xt+FMJsy0kNtPHrv2IC jlkSvltR9f3M4wC+7SJwcbJbdr0QuPGtfoZTuDOQNUvVEz/EwHE/6ga/6Y0a6jOss3WD i15g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=d8y47D9g; arc=pass (i=1 spf=pass spfdomain=flex--saravanak.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id pw17-20020a17090b279100b0029a89310424si460446pjb.161.2024.02.23.21.25.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 21:25:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=d8y47D9g; arc=pass (i=1 spf=pass spfdomain=flex--saravanak.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79473-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9C61E28382A for <ouuuleilei@gmail.com>; Sat, 24 Feb 2024 05:25:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37FE317597; Sat, 24 Feb 2024 05:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d8y47D9g" Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31DF1FAA for <linux-kernel@vger.kernel.org>; Sat, 24 Feb 2024 05:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708752319; cv=none; b=Omwn4/Y74FK87RVxfJT9bDNqO+NhkvwJXp7u/qSG63nn3FOcPRjFn096AqvDg+bhOQRnfMPf8eOR6ZICIkRqPe7vWcjAa9w783aJ9nadNokojfzaPPp09/xaSPOL8mW+IPpEDm8LMkcIm3ql2kbT1EVvk4xNzrRgVDFdBFUfZRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708752319; c=relaxed/simple; bh=QUVWQXF4RnbcTmcdlBVlHaewtgXiBHCNt2bTtC2kEk4=; h=Date:Message-Id:Mime-Version:Subject:From:To:Cc:Content-Type; b=l5Fbp1LJCVpG+f+d5jqi8BowB7gTsVvztUjuPj/1DYjFuTj4a+Xjp91v8TA8sygw6oTCziRCQrhCPFXHwt6p4yPWRfmgT0Y2n4AZXP6rV0F3V4HVYdNapWX78HyO3MnnElwAf1ZFgQjAooiZPiT3mOTTZxu3IlRBGXPpjbJprJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=d8y47D9g; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--saravanak.bounces.google.com Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5ee22efe5eeso27489517b3.3 for <linux-kernel@vger.kernel.org>; Fri, 23 Feb 2024 21:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708752278; x=1709357078; darn=vger.kernel.org; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=NmM7cCBUfnsEzWOUWxpGwPzttTnkh5grF+m9vEmGQ0Y=; b=d8y47D9g19pxlwzf3UZp5qNEWdXp+nZZas5JoZkAfClrGXIGtrAYXV8pNLdm2nxAj3 8IrVgVOoBUKWbvv8Vmd2al8w2TZZBOJiZtoX5LYY0hDn5JlcebyBGB2Kq8NAo8HFk3Ym S+7Zf4O5Y/xJv39jJ0eZg8IFxAniSKd5YsRHURy61xLKG6y0y0v/tHlM9+7J9w06Yb6F kz29u8V3udFhKs0A1NlvQXNltcPcj3ig+AMgpdd6iLozBLvxTIS5a4wlwj5cu0I9JJma jLCLa3zW18s/HmCvQb3jbpGCthe+sZ/OalBeFr0cWPu0vp5GoV0SArPTRXinJvFDGX2j +Ahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708752278; x=1709357078; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NmM7cCBUfnsEzWOUWxpGwPzttTnkh5grF+m9vEmGQ0Y=; b=LVu8U00J4E6l5unVhg7JftD5Oj+Q/IMfgssH/h1tknpUYuqH/k86MfrGLR1cVweDRM XKv8I8er0tob3BfOmGKKOL+2iGTO7hx3IVS5nzdslYfmOckpmXs8zgZFxNMaCjIVrcyM F0Q4yIS9lyNDyzksuMGE62MLxiaux0YjpKoKJA03AUvkRCQZ98d73LJ5Ygw/krlbkA8M 5Oi5MIez2mWHAd+umKxvBte5CIp4sHY+yek1cOXIiCTxajRKe2CB8gmR98jiCFZZ5avo UpqMf86hEGAfVStT7E9f2NYC24t5pa+VwB+nQ4wvo7xWKYEZnr1UU/RULT9LVtwtV1tw 7z2w== X-Forwarded-Encrypted: i=1; AJvYcCX4rq317mc3FIC0848Xc2f2RemqNBikbASZUpSNWa0HkccSNRwg2kZEtToNdQYJOQ3H0BDp+fTKKaVHp4lJkd0fbJrET7LqEJlqE+r4 X-Gm-Message-State: AOJu0Yypt6a7UulJFdzxGMlPrlnkaZRQzWby7RJGcU1AB6nDxS1TbG4e kTyZYFeNzqDUofc/Aq8peiR2yYvAo4X+nPqcR+UT/s4EDo0yzVqNKDv9OrYRP10klXRbj4t536n kmtMPnhJtjpSQUA== X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:935f:fca4:5a22:7b7]) (user=saravanak job=sendgmr) by 2002:a05:690c:338b:b0:608:c3f4:1fb9 with SMTP id fl11-20020a05690c338b00b00608c3f41fb9mr363187ywb.3.1708752278758; Fri, 23 Feb 2024 21:24:38 -0800 (PST) Date: Fri, 23 Feb 2024 21:24:35 -0800 Message-Id: <20240224052436.3552333-1-saravanak@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Subject: [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing From: Saravana Kannan <saravanak@google.com> To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Saravana Kannan <saravanak@google.com> Cc: " =?utf-8?q?Herv=C3=A9_Codina?= " <herve.codina@bootlin.com>, Luca Ceresoli <luca.ceresoli@bootlin.com>, kernel-team@android.com, Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791756684007854499 X-GMAIL-MSGID: 1791756684007854499 |
Series |
of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing
|
|
Commit Message
Saravana Kannan
Feb. 24, 2024, 5:24 a.m. UTC
Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve
finding the supplier of a remote-endpoint property") due to a last minute
incorrect edit of "index !=0" into "!index". This patch fixes it to be
"index > 0" to match the comment right next to it.
Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/
Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property")
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
Using Link: instead of Closes: because Luca reported two separate issues.
Sorry about introducing a stupid bug in an -rcX Rob.
-Saravana
drivers/of/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan <saravanak@google.com> wrote: > > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. Greg, this needs to land in the stable branches once Rob picks it up for the next 6.8-rc. -Saravana > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > Using Link: instead of Closes: because Luca reported two separate issues. > > Sorry about introducing a stupid bug in an -rcX Rob. > > -Saravana > > drivers/of/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index b71267c6667c..fa8cd33be131 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np, > int index) > { > /* Return NULL for index > 0 to signify end of remote-endpoints. */ > - if (!index || strcmp(prop_name, "remote-endpoint")) > + if (index > 0 || strcmp(prop_name, "remote-endpoint")) > return NULL; > > return of_graph_get_remote_port_parent(np); > -- > 2.44.0.rc0.258.g7320e95886-goog >
On Fri, 23 Feb 2024 21:24:35 -0800 Saravana Kannan <saravanak@google.com> wrote: > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Hi Saravana, On Fri, 23 Feb 2024 21:24:35 -0800 Saravana Kannan <saravanak@google.com> wrote: > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > Using Link: instead of Closes: because Luca reported two separate issues. > > Sorry about introducing a stupid bug in an -rcX Rob. > Reviewed-by: Herve Codina <herve.codina@bootlin.com> Best regards, Hervé
On Fri, Feb 23, 2024 at 11:29 PM Saravana Kannan <saravanak@google.com> wrote: > > On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan <saravanak@googlecom> wrote: > > > > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > > finding the supplier of a remote-endpoint property") due to a last minute > > incorrect edit of "index !=0" into "!index". This patch fixes it to be > > "index > 0" to match the comment right next to it. > > Greg, this needs to land in the stable branches once Rob picks it up > for the next 6.8-rc. Uh, what? Only if I ignore this patch until 6.8 is released. Otherwise, the bug and fix are both landing in 6.8. Rob
Hi Saravana, On Sat, Feb 24, 2024 at 6:25 AM Saravana Kannan <saravanak@google.com> wrote: > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> Thanks for your patch! > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np, > int index) > { > /* Return NULL for index > 0 to signify end of remote-endpoints. */ > - if (!index || strcmp(prop_name, "remote-endpoint")) > + if (index > 0 || strcmp(prop_name, "remote-endpoint")) > return NULL; > > return of_graph_get_remote_port_parent(np); > -- > 2.44.0.rc0.258.g7320e95886-goog After this, the "Fixed dependency cycle" messages I reported to be gone in [1] are back. In fact, they are slightly different, and there are now even more of them: -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef7000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef6000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef5000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef4000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef3000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef2000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef1000/ports/port@1/endpoint@0 -platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef0000/ports/port@1/endpoint@0 -platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef3000/ports/port@1/endpoint@2 -platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef2000/ports/port@1/endpoint@2 -platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef1000/ports/port@1/endpoint@2 -platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef0000/ports/port@1/endpoint@2 -platform fead0000.hdmi: Fixed dependency cycle(s) with /soc/sound@ec500000/ports/port@1/endpoint -platform feae0000.hdmi: Fixed dependency cycle(s) with /soc/sound@ec500000/ports/port@2/endpoint -platform feb00000.display: Fixed dependency cycle(s) with /soc/hdmi@feae0000/ports/port@0/endpoint -platform feb00000.display: Fixed dependency cycle(s) with /soc/hdmi@fead0000/ports/port@0/endpoint -platform hdmi0-out: Fixed dependency cycle(s) with /soc/hdmi@fead0000/ports/port@1/endpoint -platform hdmi1-out: Fixed dependency cycle(s) with /soc/hdmi@feae0000/ports/port@1/endpoint -platform vga-encoder: Fixed dependency cycle(s) with /vga/port/endpoint -platform vga-encoder: Fixed dependency cycle(s) with /soc/display@feb00000/ports/port@0/endpoint +platform e6ef0000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef0000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef1000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef1000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef2000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef2000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef3000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef3000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef4000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef5000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef6000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef7000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform ec500000.sound: Fixed dependency cycle(s) with /soc/hdmi@feae0000 +platform ec500000.sound: Fixed dependency cycle(s) with /soc/hdmi@fead0000 +platform ec500000.sound: Fixed dependency cycle(s) with /soc/i2c@e6510000/codec@10 +platform e6ef7000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef6000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef5000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef4000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef3000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef2000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef1000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform e6ef0000.video: Fixed dependency cycle(s) with /soc/csi2@fea80000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef7000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef6000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef5000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef4000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef3000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef2000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef1000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef0000 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +platform e6ef3000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef2000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef1000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform e6ef0000.video: Fixed dependency cycle(s) with /soc/csi2@feaa0000 +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef3000 +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef2000 +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef1000 +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/video@e6ef0000 +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +platform ec500000.sound: Fixed dependency cycle(s) with /soc/hdmi@fead0000 +platform fead0000.hdmi: Fixed dependency cycle(s) with /soc/sound@ec500000 +platform fead0000.hdmi: Fixed dependency cycle(s) with /soc/display@feb00000 +platform ec500000.sound: Fixed dependency cycle(s) with /soc/hdmi@feae0000 +platform feae0000.hdmi: Fixed dependency cycle(s) with /soc/sound@ec500000 +platform feae0000.hdmi: Fixed dependency cycle(s) with /soc/display@feb00000 +platform feae0000.hdmi: Fixed dependency cycle(s) with /soc/display@feb00000 +platform fead0000.hdmi: Fixed dependency cycle(s) with /soc/display@feb00000 +platform feb00000.display: Fixed dependency cycle(s) with /soc/hdmi@feae0000 +platform feb00000.display: Fixed dependency cycle(s) with /soc/hdmi@fead0000 +platform cvbs-in: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +platform hdmi-in: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +platform fead0000.hdmi: Fixed dependency cycle(s) with /hdmi0-out +platform hdmi0-out: Fixed dependency cycle(s) with /soc/hdmi@fead0000 +platform feae0000.hdmi: Fixed dependency cycle(s) with /hdmi1-out +platform hdmi1-out: Fixed dependency cycle(s) with /soc/hdmi@feae0000 +platform vga: Fixed dependency cycle(s) with /vga-encoder +platform feb00000.display: Fixed dependency cycle(s) with /vga-encoder +platform vga-encoder: Fixed dependency cycle(s) with /vga +platform vga-encoder: Fixed dependency cycle(s) with /soc/display@feb00000 -i2c 2-0010: Fixed dependency cycle(s) with /soc/sound@ec500000/ports/port@0/endpoint +platform ec500000.sound: Fixed dependency cycle(s) with /soc/i2c@e6510000/codec@10 -i2c 4-0070: Fixed dependency cycle(s) with /soc/csi2@fea80000/ports/port@0/endpoint -i2c 4-0070: Fixed dependency cycle(s) with /soc/csi2@feaa0000/ports/port@0/endpoint -i2c 4-0070: Fixed dependency cycle(s) with /hdmi-in/port/endpoint -i2c 4-0070: Fixed dependency cycle(s) with /cvbs-in/port/endpoint +platform feaa0000.csi2: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +platform fea80000.csi2: Fixed dependency cycle(s) with /soc/i2c@e66d8000/video-receiver@70 +i2c 4-0070: Fixed dependency cycle(s) with /soc/csi2@fea80000 +i2c 4-0070: Fixed dependency cycle(s) with /soc/csi2@feaa0000 I guess all of that is expected? [1] https://lore.kernel.org/all/CAMuHMdVon3mdivZQ0O6D4+va0nGBrUQbDp23bEq661QD=4t7+g@mail.gmail.com/ Gr{oetje,eeting}s, Geert
On Fri, 23 Feb 2024 21:24:35 -0800, Saravana Kannan wrote: > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > Using Link: instead of Closes: because Luca reported two separate issues. > > Sorry about introducing a stupid bug in an -rcX Rob. > > -Saravana > > drivers/of/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks!
diff --git a/drivers/of/property.c b/drivers/of/property.c index b71267c6667c..fa8cd33be131 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np, int index) { /* Return NULL for index > 0 to signify end of remote-endpoints. */ - if (!index || strcmp(prop_name, "remote-endpoint")) + if (index > 0 || strcmp(prop_name, "remote-endpoint")) return NULL; return of_graph_get_remote_port_parent(np);