From patchwork Fri Feb 23 21:00:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pawel Dembicki X-Patchwork-Id: 205680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp842506dyb; Fri, 23 Feb 2024 13:02:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXUsgCQvHzOQxqEdec9eg+S6KWzEfR4kVxzshajj2aGrupwxB0kLea2SMe/8o887VVkA8CP+7KuwFlxlVQai75ad6XLHQ== X-Google-Smtp-Source: AGHT+IEfeQRDOJwlYw7ev8LBxR3vb/eMpKwAJgRiD2NjUBMqYvQggJVfvKDcOyAT2LnbdklhD0dJ X-Received: by 2002:a17:906:289b:b0:a3f:d797:42ec with SMTP id o27-20020a170906289b00b00a3fd79742ecmr737149ejd.53.1708722163939; Fri, 23 Feb 2024 13:02:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708722163; cv=pass; d=google.com; s=arc-20160816; b=q9s0UryuvpqUia/RUHfgxjTjYC0CJLKrfSbN4LPoGG6ayeqIM7iq+gypg4CIMBDyq0 Yrn790cUf0q7yS1B3cEnSfQRznvgm4344DP3i7BLOMHNWc5Vte7h46IWjQLZiCuYYzso hyI1cA1GtukZ7yIH9gB5Z4KdG4VSH4IJrE1u4UPRjfuekAvkEuB4efww1Dm3ACeOnXKi O5qfilF7i+SDM3aTdU2WS/iPKeqtKpE0YjEhg0tu0ubDLbsmSb/krLPfD3QxdyirBudW aOeQzXfTaoWOofvR5zpLHAYQkSufjBi/5mlc00R6/fWsMD/Y2SuCDak8/jyy9LGExH50 tnJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=kegIZxvQ3V5ErtuAqBTi6g+zqDh2Ar8Wl8I510MU1cI=; fh=NcFs1KvAiROHUfEnvcRTSCnSzsKV5ryoJcD999kihL4=; b=GjiZwPpqwJeDXScREXRyADUxWLu4GrdHnD3Dk1K8aIZaWKqIxAOb+91yeY10LM/I5M qpsRjHEeKfVR+r3m4QR0bRHEEHm3+hrmlygrK/LL5+n3gzaPW1QDFaF0SdBPdG9Qxj/y 9q7ljXHWcOH3AyAwtQZ2Z5iac35pGr+K2EIo4IgBF0uzxvMEVcnV5erDFoTxMxhMCAHX 6mB7gnmKLp7HQ31aLuirfBWlBmw/0OEF/GXa8d0HYBH2xpXa5mTCdYRCrdwWulq0Hr+a w81OFdG55c5x60FM9fgYgzTMjGFB0LmXmS1ZnxonZEsiz+u1TP0gH7+iK0DTNZZt2KvR MSuA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=KfKZKgPN; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-79162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id di14-20020a170906730e00b00a3f851fb768si1595694ejc.581.2024.02.23.13.02.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 13:02:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=KfKZKgPN; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-79162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79162-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8EAA31F22DF8 for ; Fri, 23 Feb 2024 21:02:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46F7F149381; Fri, 23 Feb 2024 21:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KfKZKgPN" Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2EFE149396; Fri, 23 Feb 2024 21:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708722119; cv=none; b=K49Z3bt9RhlsoHXTMrka4dDGufLseT3wLxwUL02m/ELYsXBYdKHwe1nlV9SBgDF5P9fkKf2iUWCmbi8EWJ5YGzuD5JL5rYEHsZjj0LdgM11xF6MY1OcmheanIE+++sAoSasXUUkOaUPEAjg4B+H3XVX/M1Ac2CUQP/z+Xw3YGug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708722119; c=relaxed/simple; bh=YzSS2jEc2yrsg0NpWculskSZdP/jfRB/wDseRYqsnQY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LzASsB/+gTtupduUxA99jpfZ8tL7r20lJwmLbNgu9okV9pU24w2kA2fXnLuF7yyvr/zbRfK8YRM3igKXWY6pm4Op/Agvigufzl39HaGKrKIC2dDkje0O92CBwZrRcKUk6TfDl62nu6NVfpzliDOgK/ztEhF3hzcg8ZKmkUXc+TM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KfKZKgPN; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-512c2e8c6cfso1563064e87.1; Fri, 23 Feb 2024 13:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708722116; x=1709326916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kegIZxvQ3V5ErtuAqBTi6g+zqDh2Ar8Wl8I510MU1cI=; b=KfKZKgPNVQpc5bk9gznxBwZ8RuF9ki4tAzdxZW5js68e+FQ9dqr87CyrEjovVW3XbV mkjQcVZaXQhDpfXgRQ+a0vsXY2zAum1Ozgl5pRhrMu7cHYkmU+i/bKnVbnvbJatY8rfp pEq2i9npa4p37gz43fgm5Fbt/P+dQ0KlR4TaAv0r7tNuLMShv7ofRRz7ktzmFPhSXGXV 0HRTcB5x5boFkWN2nS9FYfxumU+f2ORGJjmEbHtibIIvZRByeh7RXwtfS4H33/EX1Yj4 VNcXYoNgDfMurN+w0jmePHS2omrM+m3UTPwGniPwlbsnRRh36wekkyxSR+KJekJW4HeR DAPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708722116; x=1709326916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kegIZxvQ3V5ErtuAqBTi6g+zqDh2Ar8Wl8I510MU1cI=; b=nHXXWZc7z2TuHaeRQ5hI/eyguZIALPDPVujGIha5sWDkJr9hEncAnTGX0yXNT+EOb9 NSP4TuiS57kIYJPwYDAOB+OJW35XFQtTHQM5GPlny9GeEm1r0X11XVdFBTu3G82V1JEj VzVjcVsZjZ6RGfV7nWiqDCD2k3ErKuC9PhWWxaz1ek3IFED8Iy8LxT+JJ9rp5awcoN1q A7JgXmqPDpJVnLGNFfUPJ2kc0kjGbcYoQj7HPMJXn0puJnR5j2f3h+0LocdM65sXz/jv 44BTV5YRqZYjNZY+nkvDdNKwVrHTSajB7w0mqxtL8QuGO/dqH488N6MZ8onbxogMaR9G 8vag== X-Forwarded-Encrypted: i=1; AJvYcCXub1jtOL5w9oeJ0sHO8JGWQVRernOuDTg+VEIVlXBFe3qZyYg2EKBt2uRcgHwgAjrEVSJKdzQ5iY7l+fvqoawYDZJZ/yKQgjhMJQ74 X-Gm-Message-State: AOJu0Yxj2qSSxvEqMsm4WbckrHaUprIUWxfS4sbHb+72Wzy2NyAMv/nH l42iOCkVp5exa3B6H6PK6cTgA13W+yjF3gAc5Z67JUJsvuh2ylNw+yhio9WKpbw= X-Received: by 2002:a05:6512:242:b0:512:b935:c542 with SMTP id b2-20020a056512024200b00512b935c542mr634057lfo.59.1708722115443; Fri, 23 Feb 2024 13:01:55 -0800 (PST) Received: from WBEC325.dom.lan ([185.188.71.122]) by smtp.gmail.com with ESMTPSA id st11-20020a170907c08b00b00a3e559aaff9sm6185424ejc.29.2024.02.23.13.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 13:01:55 -0800 (PST) From: Pawel Dembicki To: netdev@vger.kernel.org Cc: linus.walleij@linaro.org, Pawel Dembicki , Russell King , Florian Fainelli , Vladimir Oltean , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org Subject: [PATCH net-next v5 03/16] net: dsa: vsc73xx: use macros for rgmii recognition Date: Fri, 23 Feb 2024 22:00:33 +0100 Message-Id: <20240223210049.3197486-4-paweldembicki@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240223210049.3197486-1-paweldembicki@gmail.com> References: <20240223210049.3197486-1-paweldembicki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791725051866694436 X-GMAIL-MSGID: 1791725051866694436 It's preparation for future use. At this moment, the RGMII port is used only for a connection to the MAC interface, but in the future, someone could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro allows for the proper recognition of all RGMII modes. Suggested-by: Russell King Signed-off-by: Pawel Dembicki Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean --- v5: - added 'Reviewed-by' only v4: - introduced patch drivers/net/dsa/vitesse-vsc73xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index cb2e7e256279..8ed8fc997d6d 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -807,7 +807,7 @@ static void vsc73xx_phylink_mac_link_up(struct dsa_switch *ds, int port, else val = VSC73XX_MAC_CFG_TX_IPG_100_10M; - if (interface == PHY_INTERFACE_MODE_RGMII) + if (phy_interface_mode_is_rgmii(interface)) val |= VSC73XX_MAC_CFG_CLK_SEL_1000M; else val |= VSC73XX_MAC_CFG_CLK_SEL_EXT;