From patchwork Fri Feb 23 19:49:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205713 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp873211dyb; Fri, 23 Feb 2024 14:20:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXMxbPsuK8Pq7GYGIgze1Ni/zUthVvu8vTAWIRqukTzfHmqnwKTj6kV6YBrijVEqm6u3qL/AYymBNUhDKsgJzHIpn79/w== X-Google-Smtp-Source: AGHT+IFpbuUxYYJBPBbDYXRHwTm5tuhZmuZU70KFWBiM8n6OBqV27TZuoY7NrAlbBp07vRtPTOrR X-Received: by 2002:a05:6808:7d1:b0:3c1:333e:683b with SMTP id f17-20020a05680807d100b003c1333e683bmr1082924oij.20.1708726813072; Fri, 23 Feb 2024 14:20:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708726813; cv=pass; d=google.com; s=arc-20160816; b=L+ffHya45JWCpTAlTt4hDeUqkPZ/WBcTGD8iuXDIOkFCyFzPt2kRFWmByJ0YMO3HWY XmCpyA+0xOjlzqsIMoaF1b/1qyvZ7aVxopmgrlY0vzpVmTU53o8qFjVxBbrK0ibNEkct OKmqLGItjX9H9toKIzXVl9tq8QPHw3s1ffQOz7ifLkvDGGjNad0r3VRirGZUqrZu6oon ymTiS5U5TgprwYaMDXZ13GYaLBmcVY6mD8HWpCyBoVTcuiBPkd7EptN2tWTebBG1VzQE F9FpxwCiEMJgflax/Y1EvUbq2yHVpNsG714JvBXensmvB2qlXKHMM9z0PHg3gqauyfdK xc/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xs4DPqOsc9+azMllpOXEorAGBCeNZM8TxqMCW4v36RI=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=Fj+gOGa/QduvXRUJpRLOApLxLffFgLFEwpV7CdtA0DgjK1AsTABOHonfpGP8HH4EI2 bDeD2c+XOQ3qRskke0e18HHr9F2pKpS41/MFvMNIrqF6HTJsOPkcInNb42Ht0FR8oaz1 +QuPFgFZdNHszzMTEj4z/Xc+Fzo35wn+GdK3LBJoQ6duEagrGtlDaJ9aFDr+yHtbc6oM yJuzGIaiDutpn3LMOLocpUDqG2X1nGLrJJLGtqjwDYnNosT7t603j709eBq9ndRCcCG/ kfdJ9jF2rI/IMzT2bBnuQe0UqcassYoIq+hk6gpCp/NQHyq9pRHo7b2aLeQGfKjO8kPU +XmQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DdTrt5gM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j5-20020ac86645000000b0042e67816152si1490530qtp.87.2024.02.23.14.20.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 14:20:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DdTrt5gM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4D7401C24C3B for ; Fri, 23 Feb 2024 19:53:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AA4913DBA8; Fri, 23 Feb 2024 19:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DdTrt5gM" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9B114CAA5 for ; Fri, 23 Feb 2024 19:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; cv=none; b=FGl4hk7nPBkJq0dTkXte0D3E1B9abpjOhS8clo2dJgt+eG72hn3AXazLtZScNDzQ8AfWGyh/iQF8N2swVHn7sEvGABjMaYwUydJ4YUl/mcT2SgqsDr1JI9nihxYhY6d9ilgq86I4of6QQqylkaweQTp+kPcNE9Oaw7pkyvReDuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; c=relaxed/simple; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jN+oLCjiGpKxYQsW/TPGb0X0o2uXBIgkbhaiAznubnXURm5r/Cq6u2kP8t7sopAVFHGKORkrnJBZI0OlPmQ48LWnDxTprlUZZSUtWLD5lU9/69apgNrCSG3i/Qe5jN3Cf+d8KDcQE9lHsV+f6VlRKdV+DjfmVnILLyvWR5GEZBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DdTrt5gM; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717883; x=1740253883; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; b=DdTrt5gM5sUZoK6aLgExcHZIltaDXOTr4XYtJpAEvggWx1bkTOplL1e+ oFRzVjj0y8Hu2EdRRrEGieFe4RpC3oq+WkMkA1O4MOLGgY8nd1Qu3AlCZ 3mKMm0+1j5YPJfgBEp/LilaRaqffaqiFWI0kYbRFK3D75boxieJUBtytu rWizjc7iSyba5JX83Hxw5vC9gGFVIQEudd7NBWdY1cqywPCKa84uHV9da cReRjV3wEZGy6OLIiUCvtSBJTdXMMuUAhyHsBrzNAwwwbILQ+B/Hyz8zp Hrppo9OLgLYuWWWCxXKsJ1p86NAKO+kSLxhH1fOWsXH81mN5BNB33o2nn A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837340" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837340" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025656" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025656" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C7BAB8D2; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 5/6] mfd: kempld: Drop duplicate NULL check in ->exit() Date: Fri, 23 Feb 2024 21:49:54 +0200 Message-ID: <20240223195113.880121-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791729926719782228 X-GMAIL-MSGID: 1791729926719782228 Since platform_device_unregister() is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index c3bc61dcd098..30b8408c094e 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -895,9 +895,7 @@ static int __init kempld_init(void) static void __exit kempld_exit(void) { - if (kempld_pdev) - platform_device_unregister(kempld_pdev); - + platform_device_unregister(kempld_pdev); platform_driver_unregister(&kempld_driver); }