From patchwork Fri Feb 23 19:49:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp873242dyb; Fri, 23 Feb 2024 14:20:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/A2Z4WqjDQIj2h2rbq/qYOfMFd1jUvByUwqIvOQimDZLwxAE3IEfUbbaN2czoUxCMvAUI+q5C7ZvDNJResCvqZrEJcg== X-Google-Smtp-Source: AGHT+IEgch4aAwTu84ewPLy+psB5z2n7+m4HItIIEwqkpAieaHeYn+5qacWT7ILjKdaS+0IQm1kG X-Received: by 2002:a17:902:6e10:b0:1dc:212d:a9f8 with SMTP id u16-20020a1709026e1000b001dc212da9f8mr978123plk.64.1708726817945; Fri, 23 Feb 2024 14:20:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708726817; cv=pass; d=google.com; s=arc-20160816; b=c3j7IOK46drTOk7qtVzBnQT1k/BuoXqJYY4YQMLoO+0ZXSC4g+FJA7du/oP1CTFJuc EbJMoM4lgf1rc1GasYJ8nN8F6AEbvEACd+UuzpRVTvyNdS6Y3lq5PisH5S9+mcQrT8MT 2KVSTR7o4ZVU+KZ7ORX5qjQvA0zYRtuo3SEMl/UEStl/xLLly7LjaIbcyobjG+214YAv uEhgpNRBMwGiGgbQGQlfKN8p5v9D5le7pfcmseZBMVn8z+KwxOqxK8Cy/ZZ3ZYdsanG5 g5ZrWx9W4b4BST9kbMgPHOH1tVyM4FJlJ+gUml7pFLFv0+4t9F2nf4AuD13WRYxHM46/ YRAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2n7bXGhf8LSHpeYMWjyjxT74Q5SKgslx2/rx8thjvrM=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=RulE5PeRo2NeswOiaUN8CnGmjwllMKuAcxQlg6Ua8U7hrKQWodhf7C1r/4/4JdwyhB uPk0XV2sHV2bMQRVJkaips1lfLStmf/ya/M5uSaAC30ap97UgYyBylXRi+h+ylqEKcuK nKb5l4u/CkN6B78KlHKkwbbtJwbhPozA3UStjVR+M2y5K7rV1foCqoIzvSLuzwZzq547 Caa6idUa3/MsPx9D/1eSLaDMI8b3ImaSXLV5/AzdBBcPIGqQuuyxcGnvFwZ58B60jiz3 s7SP1hPNzxg0pxEyalm8daIAPMeS2h1iKK1WkQ4Gb1MtZ6rmIFurxhrbJ9VieH08IwS7 velg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hAb3t4HU; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p23-20020a1709027ed700b001dbf5a95ef3si9907058plb.417.2024.02.23.14.20.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 14:20:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hAb3t4HU; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC113289945 for ; Fri, 23 Feb 2024 19:53:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2BE714DFD8; Fri, 23 Feb 2024 19:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hAb3t4HU" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02391493B4 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=AVs3wfUisDXS2lVc7IhvIYd2HV0CHh7I/5qu/9pewDreE11wLKyRkJW9DwhhefSnQhN9j2oJI7UQdpDmiGS53SWf9XRjf0/Ll0TAQ6e0RwyGFVoEgtXCWnuArbJxXyLZxatwN1XNdln8ZMMX9/eymr5bHmw0YMLFvVsXrnZLaAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maaweI5YbJDzr8Tiipzdrz0X98zWYyAEe6oQeYXbmA7rVnxYuo1dHc5CCXQTSCDt1kUEXZ10Ax8EF14+mES3rc2W4vofZ/g7a9HXg10GA0Utb69BltyXHao+WzCLAv6NAMW1XQ0KibhKVrONhL7mY+3CRM47Ul9MEgFsg3ZfUB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hAb3t4HU; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; b=hAb3t4HUBUl3zBlB/a7OjwUDRIEVS57tTUQSTyoyUYkHicJiD5sW+QMJ vlqoYr6aMmoAkClKqd0jVSUxwTgoCgJTEApLJuA0ApZyyvHj4IgjagnLI ou3ZpndePmqRA0/boK4gJcFPK/JYhVFPtHnvYHhwve3QmVg8tl2rZzNf7 ruIXNF5Ty5XD2cpK7KfrKA0ctK0kXf52U3q5Q0qg45k60NsZuwWk1W4z3 tJ1TjA0jsLk6otoCsmtNcH+Sed28VTdera68ZIVquohZ8K190hkv24fkZ yu8++u9VXTVX6ygYir6dbO+Fz0Rq+di5tOepU3LtXaDyJtbwVoKborM3G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837328" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837328" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025653" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025653" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AF78479A; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 3/6] mfd: kempld: Simplify device registration Date: Fri, 23 Feb 2024 21:49:52 +0200 Message-ID: <20240223195113.880121-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791729931776909330 X-GMAIL-MSGID: 1791729931776909330 Use platform_device_register_full() instead of open coding this function. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e8ac30528085..e207a62d6577 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -6,6 +6,7 @@ * Author: Michael Brunner */ +#include #include #include #include @@ -131,28 +132,20 @@ static struct platform_device *kempld_pdev; static int kempld_create_platform_device(const struct dmi_system_id *id) { const struct kempld_platform_data *pdata = id->driver_data; - int ret; + const struct platform_device_info pdevinfo = { + .name = "kempld", + .id = PLATFORM_DEVID_NONE, + .res = pdata->ioresource, + .num_res = 1, + .data = pdata, + .size_data = sizeof(*pdata), + }; - kempld_pdev = platform_device_alloc("kempld", -1); - if (!kempld_pdev) - return -ENOMEM; - - ret = platform_device_add_data(kempld_pdev, pdata, sizeof(*pdata)); - if (ret) - goto err; - - ret = platform_device_add_resources(kempld_pdev, pdata->ioresource, 1); - if (ret) - goto err; - - ret = platform_device_add(kempld_pdev); - if (ret) - goto err; + kempld_pdev = platform_device_register_full(&pdevinfo); + if (IS_ERR(kempld_pdev)) + return PTR_ERR(kempld_pdev); return 0; -err: - platform_device_put(kempld_pdev); - return ret; } /** @@ -424,7 +417,7 @@ static int kempld_probe(struct platform_device *pdev) struct resource *ioport; int ret; - if (kempld_pdev == NULL) { + if (IS_ERR_OR_NULL(kempld_pdev)) { /* * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device.