From patchwork Fri Feb 23 15:21:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205464 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656095dyb; Fri, 23 Feb 2024 07:27:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVsiOGc/NLzIjpL7nxZf5dT3zR0urPE1nTmEqI7bIPrTb1+T7aEGIseER1GeFeG9q3A7wYw6xvhk4jm+Hcqb2RcZv+T/A== X-Google-Smtp-Source: AGHT+IGfV2beiAiWRaCDc/GtTt6si6wu/KcuyxwOqBm9Gg57nU2pc9lMuPIRf+71WGNgK20kJV1U X-Received: by 2002:a17:902:8495:b0:1dc:d12:e21b with SMTP id c21-20020a170902849500b001dc0d12e21bmr130702plo.7.1708702032037; Fri, 23 Feb 2024 07:27:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702032; cv=pass; d=google.com; s=arc-20160816; b=JWdQ61qjx/rXjJTqOOvvJfOrz94iuLkD3B1F/AKShNj1QPKhCnUTQY8Yfu0geRxFU/ VKqro2RG99V+gkHrIaR6VeW+Irvcnc4ydLCB4jIsT+LPiPM5W8ZkD2GUpAOGsyM2IiyV hir5rCAc2G6duMP3vKuYtO27p0IZXv7S3k+hBvQNGwtbOdzuoYuPxhuc0zvO51kXpPU4 zfMA2Cf26D2HK4v4g7NIIoMMp9Oy4YFXiLPHwx1FszqhkM9l7FEfEyy4PUYgwKMNGoHf To6tz1rO24xi6mJfUa9MaAwsVoDOfn4vmoA3i7BEul4sZ429HkSW9vH9ke4HvcQGb34L hODw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=29Itx7Ra7wIjlmG86RpangRSLn5Qh754cPCeJ0/9imU=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=0+SFBBqnpI6200KhPmIUGQoR0eoqdSOfZvYkU4Tt4+GPn1di/e4mzpfgdAxXgFQZpS nL57sAz3xxF95DODJYKhOnC8gpy5Zj9f6zFzPoakGv83+RvgsKQjwHIX4n7HcPaQ+9Sj NswGUQrZ/Uv0QhPpNGmFvO0GujysdCDFnCyExHvNAp9hj7JRQLoUYWSFsYhRik6W++GJ uvDqBskuilPqHb1wFn5k7s2eqL9MekXETpopudXHoIQCojOYdlD2+JU7A0Ko/G2PztPO cLjTLi5feWvKmuh4SAL0ZGL3sOKSO1aBS0coV5xFGNq8Ktb6YVlNCR/2SAT6Tvu5EF1E qawg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gOvQbWkD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l4-20020a170902f68400b001db3592bb36si11055456plg.279.2024.02.23.07.27.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gOvQbWkD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC162283272 for ; Fri, 23 Feb 2024 15:26:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D1A684A3A; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOvQbWkD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271788288A; Fri, 23 Feb 2024 15:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; cv=none; b=fLt0eeRFhyWL6okvqf+x8tEEPxALMJl833mYOFR03MpwRjVuvH2XUqt5F3/fm2asleScPQ0+Yy0fAK7tHw+BBDYi5G7/fXPXME5JCJtPfUH/f46AcWdUJ2Chj0GeeKrsN00LBzrqUwA/emGJL8+3tPeIhyxd2MbbUq11bejFt5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; c=relaxed/simple; bh=CrZ5ilwQu4dqM9fOfVslL0lVToxLm2aDUIvFF2TgBD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o4NuPQ19IIF8P/Cr6s8B09hDVkMqrDoDhJJk2ZrgqByh5vD0jde5uYsXor4bBxGks0UARS/Dwz2LvIBpHfdVH69d6iYFVdLTHZ6YkSl2ld3sBnlo2EDTNIq5E+z6Ptqoq234OLTyXJqt92iKMFAiQDm2aERnWsyldNmWgm0nLOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gOvQbWkD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A192DC43141; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=CrZ5ilwQu4dqM9fOfVslL0lVToxLm2aDUIvFF2TgBD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gOvQbWkDRnfkrzZuP2H2k7hnyQfaBAfjbnY8Kc6FcUaAA+StKmWwvUHaCKr5LoRzy EVmK6oz5NpmMom+vxhAhKxmFE1P23Z2zvWndfXUuGWrq3uwibD0igZDeqBUZO33w75 4ais53pwKx+xXyT4gc8mcKwIf4tjym4sv0E0Dkv2ufGjup2thhi4HwBWE241Vif/4N LgdEhOTWlLxAH3atanshZYLIUCinr9KN6PDpsRvAez0HHjmxAYFemvRWkZJkSMt4xA l9ucolIypeabofmj8tspxb+Da+dGW5dockGI7mIeS5uYdTWAGjI0KZVKkUfZqUd5YQ LyyfMQBlLr8cA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fl-29ue; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for modem and Wi-Fi Date: Fri, 23 Feb 2024 16:21:21 +0100 Message-ID: <20240223152124.20042-10-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703941969137009 X-GMAIL-MSGID: 1791703941969137009 There are indications that ASPM L0s is not working very well on this machine so disable it also for the modem and Wi-Fi controllers for now. This specifically avoids having the modem and Wi-Fi controllers bounce in an out of L0s when not used (the modem still bounces in and out of L1) as well as intermittent Correctable errors on the Wi-Fi link when not used. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index 7e94a68d5d9f..8fc0380f65a0 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -546,6 +546,8 @@ &pcie2a_phy { }; &pcie3a { + aspm-no-l0s; + perst-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; @@ -566,6 +568,7 @@ &pcie3a_phy { &pcie4 { max-link-speed = <2>; + aspm-no-l0s; perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>;