From patchwork Thu Feb 22 10:31:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsOpbWllIERhdXRoZXJpYmVz?= X-Patchwork-Id: 204675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:aa16:b0:108:e6aa:91d0 with SMTP id by22csp161569dyb; Thu, 22 Feb 2024 02:33:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWe08uqWyMT4QiBRhKWaV2GkfCp/zbeSrl9A2FIsbTqF/cJ97BkqHwqGsd6DjVb8r5UkP7KASqqFv19OvbyxM1HSHAQIQ== X-Google-Smtp-Source: AGHT+IEKXA1WCFtWuVXzFA6kfp676DDnSB+VHGOyRBfrTkObJdwxLf0Kv1HUuZ8D6L9AFdfipmRh X-Received: by 2002:aa7:cf11:0:b0:565:21a8:1e35 with SMTP id a17-20020aa7cf11000000b0056521a81e35mr1597123edy.3.1708597986530; Thu, 22 Feb 2024 02:33:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708597986; cv=pass; d=google.com; s=arc-20160816; b=rATKMJa/vb8R/KJJ3CNA76ldicXFyOn1yPO8iivkaimgYE8O/gd1v6xft629V7sPIb jOcqAf+X6/UfjxgHAfveW++EElTnGLnpTAqWoL3ENLOJAo+D5txD8Qu7VlP6mDuBP2BS H16s0WaQHhyLW4Og56rMOtP9Xtcm7QU7N54nGixIFVLxMYFtIIHh3oQ+0YUmfEKMXWEa XfJcbB68JAn/wXqO0dvqhYWEmn1Y8wsFMTe7ECCjgEy+YYDPdSZ/ADstkVkoubrnTxmt SCuATG2jS0KYwfH8mhJ28bw9uJAttd4d8qwd37w6+6zVFv6msf+OJ9ndtto6Iml3pN7m ThZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=7j152Eq5lSDHkvM0B06uWbtq1OGz2o/iHiAPq8//XBw=; fh=NV4JY3TRCs9o+gW717PVoUKK/H/wDO8M32W8z62HLwY=; b=cOjz9wI4msBMKM6b5xkzU6xd/hNnDyK2WQD2/ydyEeDb8tudvia0k/Icu1SFtwHcA1 z72jP6UmfUiAMYLpDZbgEK63QC9bLZ9+vhcvprckblQIV0LHaj4nwCW5NXgrsrnWAd9w CrEsVutZT0b4cii+4ZVKd3CK8Vw8BAhMUe01vB8dsPThsXMCZGD91HbaHsFCNNhkxzci 9wrfWsokZvjzFyNaOZ0pFQ7ZlM9lJ3eUlR1/JA4F6Yhtk0V/8CjTyY5mHFGCrV+bvG+x Lu5CLCsYD9Ywz88epwkWA/ZrybRPy30SRmM7Rx8BT8vwwdKjKJ9UjOS01apUGS7q8fT0 jFHQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="N8pQdRn/"; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-76339-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76339-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y2-20020a50e602000000b00564f24d9353si1465913edm.19.2024.02.22.02.33.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 02:33:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76339-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="N8pQdRn/"; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-76339-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76339-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E33D81F245B4 for ; Thu, 22 Feb 2024 10:32:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 671E645C10; Thu, 22 Feb 2024 10:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="N8pQdRn/" Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E803F9EF; Thu, 22 Feb 2024 10:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708597891; cv=none; b=olKKAmiex/ga8/KRODBj1uDVQ3FfKEEuwCFZedyP78TU7R4UHDL/izP7vovlzf8vuD0z5D1R31UEWSAUKq1Xmpl2XNRRzurTTYgL34d+zIiEPEZ54/0UcCDAsTGWEdYw8TbY/ADOGVGdiLFDYJ0+d1ztjeo88mxyB7hIGGnqkLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708597891; c=relaxed/simple; bh=6e8t3ifHPLtPmBHbfdKNgpyW1ydO5nrnXft3+pBt3j8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=kp1nFbr6ZoBb2Wznun1Hl3Nv35Gf4Fb+zAaqDuf4J+jOpl9O5uQxGwcNPKYaU6zYIb1Y3j3l5iN39FArGiJU2KbTJfwEJjMi559yWWjX5ADSObwwYwg4JxVMLdJ53s5E6cOu/bplBDw+GmL2fQ+8kA58O9zyElBuFE03YTVkAL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=N8pQdRn/; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 4A74BFF802; Thu, 22 Feb 2024 10:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708597888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7j152Eq5lSDHkvM0B06uWbtq1OGz2o/iHiAPq8//XBw=; b=N8pQdRn/TolXDmnev8WosBnFCkiIHNQwA8OhF5TnqmBlQ4BMTSIEghWdSNjMe8LwWQLEdu sqNTehKHDa4mq/pFhWf5IOTO0JlaL2AgAZebPk/9UYettCMLur9OSkvWEo2ehN7EnKvAsn 4BIqwMMoS/aoYJQFTaPPIJ1ofgpq+7aZ0E0GsQIppVyberN98r/FUxfN9lbsRKcj0YBDCF fEYEu7+oqEZsfU5KxtD64AyMzJEDiNRYWGs0ugdiPegFf4FkSDEfh7ylaBle8F4DiXdMx9 j4nlYmt1FCWVXQCOdMLYuQuTxCL3Fd+jrjMVgkoMkX4g0ocJ8jg2gJbE0N8w5A== From: =?utf-8?b?SsOpcsOpbWllIERhdXRoZXJpYmVz?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King , Andrew Davis Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , =?utf-8?q?Miqu=C3=A8l_Rayn?= =?utf-8?q?al?= , Yen-Mei Goh , Maxime Chevallier , =?utf-8?b?SsOpcsOpbWll?= =?utf-8?b?IERhdXRoZXJpYmVz?= Subject: [PATCH net-next 3/3] net: phy: dp83826: support configuring RMII master/slave operation mode Date: Thu, 22 Feb 2024 11:31:17 +0100 Message-Id: <20240222103117.526955-4-jeremie.dautheribes@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240222103117.526955-1-jeremie.dautheribes@bootlin.com> References: <20240222103117.526955-1-jeremie.dautheribes@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: jeremie.dautheribes@bootlin.com X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791594842442313754 X-GMAIL-MSGID: 1791594842442313754 The TI DP83826 PHY can operate between two RMII modes: - master mode (PHY operates from a 25MHz clock reference) - slave mode (PHY operates from a 50MHz clock reference) By default, the operation mode is configured by hardware straps. Add support to configure the operation mode from within the driver. Signed-off-by: Jérémie Dautheribes --- drivers/net/phy/dp83822.c | 43 ++++++++++++++++++++++++++++++++++----- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index 2d8275e59dcc..edc39ae4c241 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -101,6 +101,7 @@ /* RCSR bits */ #define DP83822_RMII_MODE_EN BIT(5) +#define DP83822_RMII_MODE_SEL BIT(7) #define DP83822_RGMII_MODE_EN BIT(9) #define DP83822_RX_CLK_SHIFT BIT(12) #define DP83822_TX_CLK_SHIFT BIT(11) @@ -495,21 +496,53 @@ static int dp83822_config_init(struct phy_device *phydev) return dp8382x_disable_wol(phydev); } +static int dp83826_config_rmii_mode(struct phy_device *phydev) +{ + struct device *dev = &phydev->mdio.dev; + const char *of_val; + int ret; + + if (!device_property_read_string(dev, "ti,rmii-mode", &of_val)) { + if (strcmp(of_val, "master") == 0) { + ret = phy_clear_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_RCSR, + DP83822_RMII_MODE_SEL); + } else if (strcmp(of_val, "slave") == 0) { + ret = phy_set_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_RCSR, + DP83822_RMII_MODE_SEL); + } else { + phydev_err(phydev, "Invalid value for ti,rmii-mode property (%s)\n", + of_val); + ret = -EINVAL; + } + + if (ret) + return ret; + } + + return 0; +} + static int dp83826_config_init(struct phy_device *phydev) { struct dp83822_private *dp83822 = phydev->priv; u16 val, mask; int ret; - if (phydev->interface == PHY_INTERFACE_MODE_RMII) + if (phydev->interface == PHY_INTERFACE_MODE_RMII) { ret = phy_set_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_RCSR, DP83822_RMII_MODE_EN); - else + if (ret) + return ret; + + ret = dp83826_config_rmii_mode(phydev); + if (ret) + return ret; + } else { ret = phy_clear_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_RCSR, DP83822_RMII_MODE_EN); - - if (ret) - return ret; + if (ret) + return ret; + } if (dp83822->cfg_dac_minus != DP83826_CFG_DAC_MINUS_DEFAULT) { val = FIELD_PREP(DP83826_VOD_CFG1_MINUS_MDI_MASK, dp83822->cfg_dac_minus) |