From patchwork Thu Feb 22 09:22:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 204634 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:aa16:b0:108:e6aa:91d0 with SMTP id by22csp133072dyb; Thu, 22 Feb 2024 01:23:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVjtrY7JZd12HfCEkyUsS8uqEgsUMdpLaOOuBrMRYSoM09cwqILfgu4NajvHlGqbTNTtw6QXndsnjsJFv2TTLbjRGiJ2A== X-Google-Smtp-Source: AGHT+IEmMMiTkGY37AF493pwhstsYAWTqf23TQQj0FG56APMzc6/FUFDgfuTzeTI/5XYHasKaoNs X-Received: by 2002:a05:6402:1656:b0:564:7007:e14a with SMTP id s22-20020a056402165600b005647007e14amr7605073edx.6.1708593825818; Thu, 22 Feb 2024 01:23:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708593825; cv=pass; d=google.com; s=arc-20160816; b=mkZXbNot/IaGF7QH1mlTUqgNwWz30SaBCY1Bm5KLrRKBP+n5bpmsqbOLJe4k3NJypu 8BiybUKvtHW5/LqqaY5YAtq122P14o3AZ7PoSPXZE0DLM1+4ActarppXzrWpFsZpk0IG QEcDAXWjSOVq3lmPqWhdAXaqvE8aMtmbnMTZaWldD0X9hGA2asuhuJSdy44+xZz9/3BZ O0uy0AkMuvSQ/ykbCDyQdKeY66N6rXD9XEtepfvsizpzvFC15G+GOtBIEM81RWBPmRFC 41YDOyosowFZd8uWP3dfGWUxib7RPQF61sTrM4AP3ZVznUoO2UlprQVdYQcq29XdIR86 9qaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from; bh=mBVGE3oq6L4FTwSx0yXLnJzxWxQWt32Z6YBwwNSN8Lo=; fh=mzA9NCJw0RTHkzOWmkgDF6mTAW7l5j//L5ineSKIwXU=; b=YnA/tbYEM4XeDeTeYRwcSJjb4G6rLl5NHUFGOMIg8kBbc6dEqqukthuEj56sA0GxCc 4jaOOS3jc3BNB/qVs+FeKT9n5cS2OOejB9hjo7hmBQYd7rA8BhYNr8hzfa5TP7UcMmb6 c9xrJ4WvzIju+QequDqqnkRihEvxALN28SBfGBdhC9e11JUEr6qmM2JwZXnzOsi5z0dV fLF2b8A3J/rguZ6FrQ8UfViIHtuIl/sdoaaVg3mgY9RFaYq84XdLBTErmyWf4XRwz+DX hdsE4jWQIJQ7qPpaXM0CUVLG6b+9JNVciAChVweX5s4bPmsUe6edbKAcVIo+fGyJppXR kRfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=unisoc.com); spf=pass (google.com: domain of linux-kernel+bounces-76211-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76211-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t21-20020aa7d715000000b005640a717b42si5033679edq.170.2024.02.22.01.23.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 01:23:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76211-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=unisoc.com); spf=pass (google.com: domain of linux-kernel+bounces-76211-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76211-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6CE511F24A7C for ; Thu, 22 Feb 2024 09:23:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF93F381A0; Thu, 22 Feb 2024 09:23:01 +0000 (UTC) Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD64376FA; Thu, 22 Feb 2024 09:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=222.66.158.135 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708593780; cv=none; b=UpXqGiQ+p7rQMLvGwJFT4aalbBqj2vhsmSFKCfUrwFIXZfJMEOQ5VEVFfTTZvJkZ3qmYLoSLThsX++e699Dc5jPd1gD/aj9ApIMIy2oL5GjKsgZf8yFzOcfyPu2qBwIE4EtZsXgj/WbEiXy/6AVGPTAvCWbLPvcRJy0FHhXz6ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708593780; c=relaxed/simple; bh=Y9MCsGargnZMdYbvCa0RXPzvIXitJU5Yea7omJUm5oc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Oz9IU/6AG92nfJdjC59l/b9VIZ2eZKKmCe+0OunesMfdjVCAhbnH7c2QJXg/PIad61OZLsliJj+gjeZ1x+KAfWArWpPb+XQwV0PiQWCaU65i74UY7wdr8Z2S9hGUxNplezvN8yhG01980GrlaaAb6M6R///vrd0L/Ub3iy9aEgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com; spf=pass smtp.mailfrom=unisoc.com; arc=none smtp.client-ip=222.66.158.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unisoc.com Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 41M9MOXf042231; Thu, 22 Feb 2024 17:22:24 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4TgSMH4w5yz2KL7sp; Thu, 22 Feb 2024 17:21:47 +0800 (CST) Received: from bj03382pcu01.spreadtrum.com (10.0.73.40) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 22 Feb 2024 17:22:22 +0800 From: "zhaoyang.huang" To: Vincent Guittot , Jens Axboe , , , Zhaoyang Huang , Subject: [PATCHv2 1/2] sched: introduce helper function to calculate distribution over sched class Date: Thu, 22 Feb 2024 17:22:19 +0800 Message-ID: <20240222092220.642294-1-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 41M9MOXf042231 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791590479743945531 X-GMAIL-MSGID: 1791590479743945531 From: Zhaoyang Huang As RT, DL, IRQ time could be deemed as lost time of CFS's task, some timing value want to know the distribution of how these spread approximately by using utilization account value (nivcsw is not enough sometimes). This commit would like to introduce a helper function to achieve this goal. eg. Effective part of A = Total_time * cpu_util_cfs / cpu_util Timing value A (should be a process last for several TICKs or statistics of a repeadted process) Timing start | | preempted by RT, DL or IRQ |\ | This period time is nonvoluntary CPU give up, need to know how long |/ sched in again | | | Timing end Signed-off-by: Zhaoyang Huang --- change of v2: using two parameter to pass se_prop and rq_prop out --- --- include/linux/sched.h | 3 +++ kernel/sched/core.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/include/linux/sched.h b/include/linux/sched.h index 77f01ac385f7..d6d5914fad10 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -2318,6 +2318,9 @@ static inline bool owner_on_cpu(struct task_struct *owner) /* Returns effective CPU energy utilization, as seen by the scheduler */ unsigned long sched_cpu_util(int cpu); +/* Returns task's and cfs_rq's proportion among whole core */ +unsigned long cfs_prop_by_util(struct task_struct *tsk, unsigned long *se_prop, + unsigned long *rq_prop); #endif /* CONFIG_SMP */ #ifdef CONFIG_RSEQ diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 802551e0009b..b8c29dff5d37 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7494,6 +7494,41 @@ unsigned long sched_cpu_util(int cpu) { return effective_cpu_util(cpu, cpu_util_cfs(cpu), ENERGY_UTIL, NULL); } + +/* + * Calculate the approximate proportion of timing value consumed by the specified + * tsk and all cfs tasks of this core. + * The user must be aware of this is done by avg_util which is tracked by + * the geometric series of decaying the load by y^32 = 0.5 (unit is 1ms). + * That is, only the period last for at least several TICKs or the statistics + * of repeated timing value are suitable for this helper function. + * This function is actually derived from effective_cpu_util but without + * limiting the util to the core's capacity. + * se_prop and rq_prop is valid only when return value is 1 + */ +unsigned long cfs_prop_by_util(struct task_struct *tsk, unsigned long *se_prop, + unsigned long *rq_prop) +{ + unsigned int cpu = task_cpu(tsk); + struct sched_entity *se = &tsk->se; + struct rq *rq = cpu_rq(cpu); + unsigned long util, irq, max; + + if (tsk->sched_class != &fair_sched_class) + return 0; + + max = arch_scale_cpu_capacity(cpu); + irq = cpu_util_irq(rq); + + util = cpu_util_rt(rq) + cpu_util_cfs(cpu) + cpu_util_dl(rq); + util = scale_irq_capacity(util, irq, max); + util += irq; + + *se_prop = se->avg.util_avg * 100 / util; + *rq_prop = cpu_util_cfs(cpu) * 100 / util; + return 1; +} + #endif /* CONFIG_SMP */ /**