accel/qaic: Constify aic100_channels

Message ID 20240222-mhi-const-accel-qaic-v1-1-028db0dd9098@quicinc.com
State New
Headers
Series accel/qaic: Constify aic100_channels |

Commit Message

Jeff Johnson Feb. 23, 2024, 1:06 a.m. UTC
  MHI allows the channel configs to be const, so constify
aic100_channels to prevent runtime modification.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/accel/qaic/mhi_controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240222-mhi-const-accel-qaic-3889157be7ac
  

Comments

Jeffrey Hugo Feb. 23, 2024, 3:13 p.m. UTC | #1
On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

I plan to apply to drm-misc-next before the rc6 freeze.
  
Jeffrey Hugo Feb. 23, 2024, 4:08 p.m. UTC | #2
On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Applied to drm-misc-next

-Jeff
  

Patch

diff --git a/drivers/accel/qaic/mhi_controller.c b/drivers/accel/qaic/mhi_controller.c
index cb77d048ed54..3f81d6396c85 100644
--- a/drivers/accel/qaic/mhi_controller.c
+++ b/drivers/accel/qaic/mhi_controller.c
@@ -20,7 +20,7 @@  static unsigned int mhi_timeout_ms = 2000; /* 2 sec default */
 module_param(mhi_timeout_ms, uint, 0600);
 MODULE_PARM_DESC(mhi_timeout_ms, "MHI controller timeout value");
 
-static struct mhi_channel_config aic100_channels[] = {
+static const struct mhi_channel_config aic100_channels[] = {
 	{
 		.name = "QAIC_LOOPBACK",
 		.num = 0,