From patchwork Wed Feb 21 18:31:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 204431 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1297060dyc; Wed, 21 Feb 2024 13:05:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXCPJ6X9p+MspvU2vTDojIL5mcEC7cPnzfE1wcfzG4hRsYlGzjOKsIevX7/W0YrK0HPDlVJ/ADrYiIogD/RFmuGjpLTUQ== X-Google-Smtp-Source: AGHT+IEPdQMQkEUxe/KJMaYnDEXInLIMYKt9kYgFuTklc3fLcc4fdiQqSYJCfCPzGfSuTXgoFbKi X-Received: by 2002:a0d:ec0c:0:b0:604:727c:695 with SMTP id q12-20020a0dec0c000000b00604727c0695mr15593619ywn.42.1708549525505; Wed, 21 Feb 2024 13:05:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708549525; cv=pass; d=google.com; s=arc-20160816; b=pnouUB3E4h+1cWkL3ZvYfJeZ/hPnlioBEOHcBaAxIvB/jS7b4v3hLFhA6uvtU4+ls8 HaTHfj/4N02wPMCxlgSAwHzSYGIKQzoMTfly+HN2gcAq00XMEEr/uZpEL0jLOMrRPlzT NL5lQP1zmkG2wO8MCPZDIUUroLZCFsqgkxiGS8nlTFlUjOZNTAdqXdlbAd3Omffx93ml xnuJd4VfcGNua0uIHoQlil0HbIiHxv6afNiAwRJ8YllcszeFuxuH+tSILQ93n1d5U4TG 2qSqnSajXzeOrj7c6lBBqEps3nPdZD1j51Ct2Tk264qh5PBrDjJ90W72V5uigZE/8ZBv 7AFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=wd2XFrM9onYe7J7z4B01h4NKcdyyYC3VwmTnsDif4J8=; fh=yrE9O525sLNdIXC06sJBIlRUjYfWNm6imQ0cf3A93gQ=; b=mX7rh10uiRCY7wkqe/uqjdEGAFlGW+cljFXXUMgz7ZrRUHZPquPUiw4tk8HgSbZ2sX Y5q4zSbgC4yaTgPTtg+uu2xDMRTdgUoLX5UPcxf0bCqIU2/UOIOXATGbH9UB7cykefYe eGS5B8kkWrp/0cNW1hJtL5zpFAOv7ZjE73tqkZJtprCXSXnquZcl6apd84Pc/hgDnUIi vmwK9afO5sgR8I1xU7fA+yR2A5DDPTdXw/P38wXtUInypdc7O3YaMsgM8r0nr6QJtYAo FcFGM3qtwgtk5wMmHnqZhtfALHW3iYmHvmRDRCJl+D9n4A0nEbtsiWqN9lP98RUwWsx8 2LHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WMPVGEHn; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-75315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75315-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gs1-20020a056214226100b0068c8b401467si11470658qvb.597.2024.02.21.13.05.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 13:05:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WMPVGEHn; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-75315-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75315-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E48A71C24CCE for ; Wed, 21 Feb 2024 18:38:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ABB8112A17E; Wed, 21 Feb 2024 18:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WMPVGEHn" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B39D31272DB; Wed, 21 Feb 2024 18:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708540512; cv=none; b=LV5Nk0whmWVRktIXQ0kwlpq2CyUyHotFNyC9ep+DmqY/tAlgrJGi7fHE52pPehBXXPv02OnqrwU8t/jqxhSES9stZCEExHAk0YAW44V+0OBXOgzbHygaFBQV44ZAY6i1Qf22Dg+JgrQ652WRGvsgduEiB47sRmbiGPYD8Av47DQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708540512; c=relaxed/simple; bh=I4Dp8lscp5MpgtPKkZb6GpVT2AnT2N5Frc+xmVMhCuw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h6h118kh1n1cO8cl0adoj5qqH53WnRi98Ytk5JlrKAGL9LuIR76amlqfj5rg5YsMpa/ZcoAbbybvJzyISJWmtFrfMZWOoaWYEHc+C5yNKmjggntzqRqCNm4I2oMUhYs7q/pHvAzFtTe4EbBdga2kMxxklsnXK6xYxaJQ/mHABzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WMPVGEHn; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708540510; x=1740076510; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I4Dp8lscp5MpgtPKkZb6GpVT2AnT2N5Frc+xmVMhCuw=; b=WMPVGEHnWIo36Pt/iYw5+3zdJAS0FNTDuGp/7MNa8RntnkrRmRy7XcIm gvO2G3HKzE3P90E361GY+OiFLDlcOvoTucs+18lsKFMnivujfMidLdDCl Veal/BkeeJU1Gfu6aeDcGMAXlzLg24IgH/+cWvc0PQ7lF0PRWV/LuQS42 2+RrbGZ4hM4XoWQoFs6I+08I3jZEXLcf3UvUpyFrpg2Jv8mi9Zg/MxmJW t1qoRuZelwp0W07yFtou9xHIXATK0g0AR9qO7zRVJ8yMAleIltS6382PP aort0U1NZAcgbGFOBCMI+KQtGAs1lx2OHyeEMk4sswJSvwyEBxvF7/coo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="28164890" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="28164890" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:35:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="936684760" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="936684760" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 21 Feb 2024 10:34:55 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 79F8C8D2; Wed, 21 Feb 2024 20:34:47 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Andy Shevchenko , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org Cc: Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: [PATCH v1 13/14] serial: 8250_tegra: Switch to use uart_read_port_properties() Date: Wed, 21 Feb 2024 20:31:29 +0200 Message-ID: <20240221183442.4124354-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791544026744534696 X-GMAIL-MSGID: 1791544026744534696 Since we have now a common helper to read port properties use it instead of sparse home grown solution. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_tegra.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/tty/serial/8250/8250_tegra.c b/drivers/tty/serial/8250/8250_tegra.c index ba352262df75..ce48d02dfa0d 100644 --- a/drivers/tty/serial/8250/8250_tegra.c +++ b/drivers/tty/serial/8250/8250_tegra.c @@ -57,25 +57,11 @@ static int tegra_uart_probe(struct platform_device *pdev) port = &port8250.port; spin_lock_init(&port->lock); - port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | - UPF_FIXED_TYPE; - port->iotype = UPIO_MEM32; - port->regshift = 2; + port->flags = UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | UPF_FIXED_TYPE; port->type = PORT_TEGRA; - port->irqflags |= IRQF_SHARED; port->dev = &pdev->dev; port->handle_break = tegra_uart_handle_break; - ret = of_alias_get_id(pdev->dev.of_node, "serial"); - if (ret >= 0) - port->line = ret; - - ret = platform_get_irq(pdev, 0); - if (ret < 0) - return ret; - - port->irq = ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) return -ENODEV; @@ -88,12 +74,18 @@ static int tegra_uart_probe(struct platform_device *pdev) port->mapbase = res->start; port->mapsize = resource_size(res); + ret = uart_read_port_properties(port, true); + if (ret) + return ret; + + port->iotype = UPIO_MEM32; + port->regshift = 2; + uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL); if (IS_ERR(uart->rst)) return PTR_ERR(uart->rst); - if (device_property_read_u32(&pdev->dev, "clock-frequency", - &port->uartclk)) { + if (!port->uartclk) { uart->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(uart->clk)) { dev_err(&pdev->dev, "failed to get clock!\n");