From patchwork Wed Feb 21 16:25:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tissoires X-Patchwork-Id: 204310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1147218dyc; Wed, 21 Feb 2024 08:28:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUwtT0TmmZMc1UvhSqVjA0mhxwFztR85pMI4SDrErNlbfQWbjO+L0c2xF9/jGXba+fCgpUBDaD+m8HVh7Hyy73bBrJy0g== X-Google-Smtp-Source: AGHT+IGLYO65t6vImcqnOyhtbXc/qe41Q3gFK82pqUsJEEjKgUMALs6JqTEatKkhj84eSc8FnaYF X-Received: by 2002:a05:6a00:9386:b0:6e4:6793:5c6a with SMTP id ka6-20020a056a00938600b006e467935c6amr9082989pfb.7.1708532936535; Wed, 21 Feb 2024 08:28:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708532936; cv=pass; d=google.com; s=arc-20160816; b=SvLepwsuUUF5lfPelq0uwFGux1nVGo+tuQ2P5jxeHzUo0KLBruOFZcV64GUHWJHbhE nIp5uY1+0VvWXAI39u6uzVJxcmo9N4SvZsTZ5gfnJEtxd2uAngG0Wdp5R+1Fw8oeYL3G k/FwfeWzZ17/SVU7kohRzAarJsTWCpzskDW6cg31L6dMUFHJjpj8D2p0zQLZ3Mi6Ue6A 7nhd8v3LAAnDCk49MrTLNLgIxOIYbL4QCrOBqJdXunQoZMzvhlJThk8fhnWCYBHaaU82 SNUI+HDx0kqfzkw06ktyQjz3gj1G8FTGiK3UmXtc1/ZmaX5xKvrtLOzd2DhmxgKaNkl0 u/rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=3ifGiCIeS+Es8jzLu3+Y+sD0raTcR41fBM5d9jl5uv4=; fh=hc4Y6F7QBSV+XcCZzl4ZOgjmnikSFu9Au/ny4/yLvAg=; b=kLt4NXEY8u1ySkwqJOBjK4CXN3tTzEtAEAZGEFgC25x/17YM7tq19qlvjdx2f2LBqK YfL/sBli2Ooz/edw5TptqctRSqyrxlPudob0eNOQRRGXar+/MlGK2XWx0/SR3GkjuP9N lvizhIq3osrc90mQI5cNjHzZentic5O9VmHN8mNln3IDYq86Nqnd4EtVMx1em2T1TCqq R4wJtHG44PwYy3mjsAk8kV0Q63EJbADmLp4PAiVM7uVJeYSL853kEUJ5P8KOdeAadYUP 7Yaj3XEqj5Ff3Ex01YHH0DJdVJtgu7edr+0LNMlnCGANgyVIhEhotSx3jciMBZC/kgGL 7cdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k+7u+Vmc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75109-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75109-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q11-20020a056a00088b00b006e0379f3935si8641750pfj.261.2024.02.21.08.28.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 08:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75109-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k+7u+Vmc; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75109-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75109-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4B618287966 for ; Wed, 21 Feb 2024 16:28:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5B2081AAB; Wed, 21 Feb 2024 16:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k+7u+Vmc" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC7882C71; Wed, 21 Feb 2024 16:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708532778; cv=none; b=qvzp98fBbH0HWIt4uwcoz0yGqhwhwST1i49HM0zd8zhLSSEopUMLVpLFzU7B+jTN3w5/4Ut/Ygwbdezmzu1TouY7xNJQJeowW2NydTfUcWxG+8HrQMVX+iBNnAZSyl1C4yvse+q7mBvTODJiv8UPwyJIirj9TyvYE6XE6N7yGAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708532778; c=relaxed/simple; bh=iKXM6sl1EhTTyHX8QELSkIyjx+AwhteZbGwXvEk/F2w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hJ4xkuQXAqCjDx8CrQJl9jQj33yqt842CjVycce4eCT0bJ6NzDv2NnwdrWW3S42Ldbp1AoNYoOKFkLbw6PIMd2Hr+whDEAM7Eem3K0EFF0Lmqydwg53sN85qCaDdAbEUFZPyOa2bxKYR5QPLKoz5Thwx/lkHlTT737GBichuMHw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k+7u+Vmc; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3D0C433B2; Wed, 21 Feb 2024 16:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708532777; bh=iKXM6sl1EhTTyHX8QELSkIyjx+AwhteZbGwXvEk/F2w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=k+7u+Vmc1aSkO1N/zyEpFPuR4z/WHiPvoD9MtjntyyayqqyhWl5BZ/VsPlHsW3cmO aLz5KpVCBLueqisOi8/V03xgcwm5Rdv1xxNgiNuCO1ZdaANOwggMsFNx0GqjCGT5JQ /FKCTq/7BJ+BCCrhXKslR2YoSctu+WZoa5W4pdixhFed9QGY2MEV8g0DJBSCdWG8wm UqhsUq4iQmXO1SW9qTeJ6Hkq5wIRThCIRfCaewL/B8NQ/uRuGGMLtCNOqtFV0szfwE lCOc/eIRy5lYyFiADZJyAcFNzOwNrhIww0AOfVWGoCDg8nfiKqLsrMEmLxd1tVkkn3 SFi769BRKnY0g== From: Benjamin Tissoires Date: Wed, 21 Feb 2024 17:25:28 +0100 Subject: [PATCH RFC bpf-next v3 12/16] HID: bpf: allow to inject HID event from BPF Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240221-hid-bpf-sleepable-v3-12-1fb378ca6301@kernel.org> References: <20240221-hid-bpf-sleepable-v3-0-1fb378ca6301@kernel.org> In-Reply-To: <20240221-hid-bpf-sleepable-v3-0-1fb378ca6301@kernel.org> To: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Shuah Khan Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Benjamin Tissoires X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708532719; l=4142; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=iKXM6sl1EhTTyHX8QELSkIyjx+AwhteZbGwXvEk/F2w=; b=k1H5/z0nr1x3VI9kFiBv0l9fBzI8F+Rp+KTKDdncd+7ilb3GGj8OujU3e10101TdFMnJtZ0Au F1ogARjyn+VCQ1eDT0Q94aiWoc0FaDpf9aaxH9mDMvyZlXxTMTO5K4K X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791526632206603434 X-GMAIL-MSGID: 1791526632206603434 It can be interesting to inject events from BPF as if the event were to come from the device. For example, some multitouch devices do not all the time send a proximity out event, and we might want to send it for the physical device. Compared to uhid, we can now inject events on any physical device, not just uhid virtual ones. Signed-off-by: Benjamin Tissoires --- no changes in v3 no changes in v2 --- Documentation/hid/hid-bpf.rst | 2 +- drivers/hid/bpf/hid_bpf_dispatch.c | 29 +++++++++++++++++++++++++++++ drivers/hid/hid-core.c | 1 + include/linux/hid_bpf.h | 2 ++ 4 files changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/hid/hid-bpf.rst b/Documentation/hid/hid-bpf.rst index a575004d9025..0765b3298ecf 100644 --- a/Documentation/hid/hid-bpf.rst +++ b/Documentation/hid/hid-bpf.rst @@ -179,7 +179,7 @@ Available API that can be used in syscall HID-BPF programs: ----------------------------------------------------------- .. kernel-doc:: drivers/hid/bpf/hid_bpf_dispatch.c - :functions: hid_bpf_attach_prog hid_bpf_hw_request hid_bpf_hw_output_report hid_bpf_allocate_context hid_bpf_release_context + :functions: hid_bpf_attach_prog hid_bpf_hw_request hid_bpf_hw_output_report hid_bpf_input_report hid_bpf_allocate_context hid_bpf_release_context General overview of a HID-BPF program ===================================== diff --git a/drivers/hid/bpf/hid_bpf_dispatch.c b/drivers/hid/bpf/hid_bpf_dispatch.c index a5b88b491b80..e1a650f4a626 100644 --- a/drivers/hid/bpf/hid_bpf_dispatch.c +++ b/drivers/hid/bpf/hid_bpf_dispatch.c @@ -508,6 +508,34 @@ hid_bpf_hw_output_report(struct hid_bpf_ctx *ctx, __u8 *buf, size_t buf__sz) kfree(dma_data); return ret; } + +/** + * hid_bpf_input_report - Inject a HID report in the kernel from a HID device + * + * @ctx: the HID-BPF context previously allocated in hid_bpf_allocate_context() + * @type: the type of the report (%HID_INPUT_REPORT, %HID_FEATURE_REPORT, %HID_OUTPUT_REPORT) + * @buf: a %PTR_TO_MEM buffer + * @buf__sz: the size of the data to transfer + * + * @returns %0 on success, a negative error code otherwise. + */ +__bpf_kfunc int +hid_bpf_input_report(struct hid_bpf_ctx *ctx, enum hid_report_type type, u8 *buf, + const size_t buf__sz) +{ + struct hid_device *hdev; + size_t size = buf__sz; + int ret; + + /* check arguments */ + ret = __hid_bpf_hw_check_params(ctx, buf, &size, type); + if (ret) + return ret; + + hdev = (struct hid_device *)ctx->hid; /* discard const */ + + return hid_input_report(hdev, type, buf, size, 0); +} __bpf_kfunc_end_defs(); /* @@ -542,6 +570,7 @@ BTF_ID_FLAGS(func, hid_bpf_allocate_context, KF_ACQUIRE | KF_RET_NULL) BTF_ID_FLAGS(func, hid_bpf_release_context, KF_RELEASE) BTF_ID_FLAGS(func, hid_bpf_hw_request) BTF_ID_FLAGS(func, hid_bpf_hw_output_report) +BTF_ID_FLAGS(func, hid_bpf_input_report) BTF_KFUNCS_END(hid_bpf_syscall_kfunc_ids) static const struct btf_kfunc_id_set hid_bpf_syscall_kfunc_set = { diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 1243595890ba..b1fa0378e8f4 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2975,6 +2975,7 @@ static struct hid_bpf_ops hid_ops = { .hid_get_report = hid_get_report, .hid_hw_raw_request = hid_hw_raw_request, .hid_hw_output_report = hid_hw_output_report, + .hid_input_report = hid_input_report, .owner = THIS_MODULE, .bus_type = &hid_bus_type, }; diff --git a/include/linux/hid_bpf.h b/include/linux/hid_bpf.h index 5c7ff93dc73e..17b08f500098 100644 --- a/include/linux/hid_bpf.h +++ b/include/linux/hid_bpf.h @@ -104,6 +104,8 @@ struct hid_bpf_ops { size_t len, enum hid_report_type rtype, enum hid_class_request reqtype); int (*hid_hw_output_report)(struct hid_device *hdev, __u8 *buf, size_t len); + int (*hid_input_report)(struct hid_device *hid, enum hid_report_type type, + u8 *data, u32 size, int interrupt); struct module *owner; const struct bus_type *bus_type; };