From patchwork Tue Feb 20 09:28:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 203504 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp284588dyc; Tue, 20 Feb 2024 01:30:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVXu/641fWZU8BPROWy2jAWZzA18GU+NZuY410Bmj4CUM9UEqTCaRi3CikoCyMb+MOS9H7cV2ITltYVNz64ywOCgzLBoQ== X-Google-Smtp-Source: AGHT+IFQ8itQv9IYD+lnLhWnH5knft1UxvUyHsYNFMyjbi+XQ6xiehyRiHFtYLw3XPLjt4qOaoZa X-Received: by 2002:a05:622a:82:b0:42c:6ed7:fcea with SMTP id o2-20020a05622a008200b0042c6ed7fceamr20620236qtw.55.1708421402207; Tue, 20 Feb 2024 01:30:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708421402; cv=pass; d=google.com; s=arc-20160816; b=AeJFsTtStho7huyWh2Hn4d8PBJ1ZYDfr/gn2HUOKpJFett9RvoB8fSNXHsel7Hd7ox wSd5LK1ymWm+tLLLWsRuX2ZwX7ZBf7Ap8aU+S5y5KryyUBBS00sOuGGCggetoNY0upNi TbuziT001GfABa8DvlEAjGXht3SIrQmpVuqk9FSqo5FNFpsgHyC7VslIGqh/IB9qsozY Afitrz8oqFJ+mso/iStsvoPNW6uS7bVYLQ1E5P/RIqiyJDchj1DBGVZwKgdhiPfn7+yh efvLeMwDLVVLnnC8j5rLduCPkQ6cTnwUnAcxFiAZVEzbwwiDwirYS8cTjGhZQt/n0kyx 59og== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ax1ZE8I4k8h6RXtVpZIH9zqVGy24kZQ7f04FJ2mRFzM=; fh=f+Qk32gmRfIpp2afhJLlGzKbJfZEDEbCPLrvaDIgoCg=; b=lcvtdEprxX6II7XYvPjOrohAtPZOiIYzzFGEhvHZabuMmI5Uvqxo4c+tA6NzIqoC25 95qEGm+kKjihZylAPj3zjKncVtEuCQPzKyiU80S7ni7fFwXCq+xBDkGMJmEqj7NP4aNQ zMMjbjW3BEFdI1S2UTxAaK3RnmarbCGUEKcW2DQ2jGmkVXIJni2hh/an1KIffLQVWcux 26JLlneR5DtkcJGFJma3WgJ+AFuFcP2b28zTkgHOE2MEmlI/4lqJm7dVDC8hBgZMuCUc q5nty+8MQDmKzE1Z4iwLnCqM/gkFziVSmbRc/kfsaFq8XslRyDZX4Pt4RiUfGaYKnD+J Qcig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=FNHqudLS; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-72694-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72694-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v7-20020ac87487000000b0042c6cf44f20si7591793qtq.761.2024.02.20.01.30.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 01:30:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72694-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=FNHqudLS; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-72694-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72694-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E53481C246C1 for ; Tue, 20 Feb 2024 09:30:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D365663099; Tue, 20 Feb 2024 09:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FNHqudLS" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B0D60DC4; Tue, 20 Feb 2024 09:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708421315; cv=none; b=Gz4wtKurpYQQEkB9Qz9Jd+E+rZIed1LDXK8l1v+G08haYrxdMRxyOtNvr75YZFcIgHurUCigg3nUBs+yWxQb6TFf+yf+BDo/Z5qiM4Jp/q2PoemxB/A1svSUZlMbwM/CR/O5fzwbEPJtllAYZp28XWwKPTRozAD2c2psllAJXc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708421315; c=relaxed/simple; bh=ojTTiT7sFsKLZQgcQ3xTUQAx0XjIPRDu5NRR820vWbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cycs/Xk0wabHxfkOW5AwMYzYMzEzDsQf1TiOG3Yr4E+00SIww9BvIi8FQn6E7QGlAUQuoVjHeU4hp9aGVLOWiINvhPv1ULgZ9GOo9aokcGNLMUknHXSRKMtlW/pm1nZs8lb7vH+jK4+/mLRUe8If6uVeupN/bNdC++RKtEnfdWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=FNHqudLS; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.86.18.159]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E3A214AF; Tue, 20 Feb 2024 10:28:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708421304; bh=ojTTiT7sFsKLZQgcQ3xTUQAx0XjIPRDu5NRR820vWbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FNHqudLSaF49k70GYlsIMmJOhIlAVqlyMliyANY3PDGKX7BhaKdduZcOtHmydPyKb qmYLH5rfVbtl818UdnBxBZ7TltCU+fCoTZ69/hfG9ZDUA0HRmy807W73iMUSXeIwja VRkwZWIcPBMiY6mvQc/J9Gr9ue0YvXYxm6f7PUHo= From: Umang Jain To: linux-media@vger.kernel.org Cc: Kieran Bingham , Mauro Carvalho Chehab , open list , Sakari Ailus , Umang Jain , Matthias Fend Subject: [PATCH v3 1/5] media: imx335: Set reserved register to default value Date: Tue, 20 Feb 2024 14:58:17 +0530 Message-ID: <20240220092821.1993-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240220092821.1993-1-umang.jain@ideasonboard.com> References: <20240220092821.1993-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791409680403752463 X-GMAIL-MSGID: 1791409680403752463 0x3a00 is a reserved register as per the datasheet. The driver currently sets to it 0x01 while the datasheet claims 0x00 to be the default value. On one of the setup based on i.MX8MP platform with IMX335, this register write broke the CSI-2 configuration. Setting 0x3a00 to its default value (i.e. 0x00) fixed the issue. It is not clear from the datasheet what this register write is responsible for but setting it to its default value seems the right thing to do, provided it has been found responsible to break CSI-2 configuration on one of the platform. Signed-off-by: Umang Jain Reported-by: Matthias Fend --- drivers/media/i2c/imx335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 7a37eb327ff4..3d3848a58fa7 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -249,7 +249,7 @@ static const struct imx335_reg mode_2592x1940_regs[] = { {0x3794, 0x7a}, {0x3796, 0xa1}, {0x37b0, 0x36}, - {0x3a00, 0x01}, + {0x3a00, 0x00}, }; static const struct imx335_reg raw10_framefmt_regs[] = {