Message ID | 20240220-phy-qcom-m31-regulator-fix-v1-1-7675b4a916b3@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp614154dyc; Tue, 20 Feb 2024 11:17:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXD0aquNI2Eq9rhlCmo41gpT1WXtOwvDpOzlkU28VOroGgMCNKJx8+qVicdjZi5nVMRBQh70UeJnCbbIDAyeBRVvmbUyw== X-Google-Smtp-Source: AGHT+IGnCGFGQf7UGaF74eu39ZfIf8rXh/nsDZu8VKn0tFXOFb8XF1gFBdZLMlsr7y6lkN4V0B8u X-Received: by 2002:a17:902:aa84:b0:1d9:c17b:43f3 with SMTP id d4-20020a170902aa8400b001d9c17b43f3mr14847618plr.15.1708456627322; Tue, 20 Feb 2024 11:17:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708456627; cv=pass; d=google.com; s=arc-20160816; b=RAK2Y6/Rs4FWWHPNXLh9BXWyrKFUbH7AFsL7wJd9Z0T7rSyeyBM8NfYSyTEhvBi2+B jwylKBUtmLjjM3+vRArb8Kd8nxVqMZmdXFwLW2JL9eDGIKmH2AlHtqemG6Ur9k2hiGJK EE55txI+UgxZtWsE2GnstIVCBzaGQmaBrvnYO/rtuLz7u4qIhmaTnh0N5F0+SsCI5obU ckK4vx0cJT38i+f3hvnBI8vKmxDgA6jdG2FB/J11xb1DfJcCrJ1fXVqjjsAIYgp5W0bv l0c0Jq6J992xqcgIwXeeX8nO8PhXozf4kfeS8h5IrJ30JcNPFRrT55aZL68CmqkbcW2i nn4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=GBBZEpewC9BLRC+ZISwlxkj/pUQLQpzkfsio0tQwFB0=; fh=bj69ZNL0RGDSRVVqftERu0zlnY7HFQoFTE/EFjKkkj0=; b=p7bLOH/jiUfpqro7uqVBZM35wrCALyDgvv8MCPOKe6MMe8qKk/jmT4PcwfvxcR/69Z XpmiDa8kk36cf6olFyd8R+VWkGSLDH+mY4PA6W5s/q/JQf/mBhon5S6M91JUWRw3qdF/ ml8OTxZ0uPfB75vdlefmx5ZiN69u3veWxjXBQekSXGrJGyT3LpXIt40Avp1DXCqVr+cU GGyRkFicyqSEBOIvvGEm/ejzH4ZuGoaYxCquDyEh2M2gy71ydWILeTyUX/EzrxUmNp4A hQKZk/eS0wB8X1WFHkKLFVv8zg0kLVeOmnT5hKkuGTuwEpPruN4jA68cpQEJqJkUvg4C f0HA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZoBzwloR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d8-20020a170902cec800b001d9e1ab2acbsi6956416plg.356.2024.02.20.11.17.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 11:17:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZoBzwloR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D7DE5B23BB7 for <ouuuleilei@gmail.com>; Tue, 20 Feb 2024 19:14:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C2D4A137C51; Tue, 20 Feb 2024 19:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZoBzwloR" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE196A8D0; Tue, 20 Feb 2024 19:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708456445; cv=none; b=WIKCQDqqzwxwP3Pu6wUZX8Zs1iq2os3XomiXluAuXx55IXCjplQQQwwYOfxH7ZTbLHkCVVn5VOZpGFVRHqfF1XjJhh1BaHn6eLA6EnNNplpY91Rl4yqh8Iwqib9hwMgXjQQQskDFIsN8V3vmMNOEW92h9QbjXpQj/WeQzWxD78o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708456445; c=relaxed/simple; bh=Vj/ZTfzxphIR8gVetdnx24KOvZPHcYyzRAok6VpGq0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=I/5PKr++26BocL0LrA82a1RkLWGKFf4J8CWVf7Kp62uPLsxNTvJm0kA19M1CjGcxGFm4ffPLBH4l3dEc2um6cXyfFcEAIpZrwwfc3e/nlzl/QNFpvD6Y4qfRQwkrpkNsIXGT/5plH8wV4D1V7qU77v2An6Hurell/H8DHppEMCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZoBzwloR; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41272d44adcso2418155e9.3; Tue, 20 Feb 2024 11:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708456442; x=1709061242; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=GBBZEpewC9BLRC+ZISwlxkj/pUQLQpzkfsio0tQwFB0=; b=ZoBzwloRr+1vuo9jWJat6uR7bqNKIGQ6U+lt2jAomtctCkp4C2BWBZYlfuqvNAhsva kkcRd098aFDRMxb8iRxtMNAP5+bgXsTQN6GRNmSBsiW8ZRpl55FDUC/6Jj88XfCWb76Q gNiboC9BT89MNpKAsji68chZfekZy/Nk39MRjv3orlMCa3Y+ZdPZGC27jrJGr8wKIuv+ JRjI0dtYTGdoJjVfeLszTr4KHHRRimUV7Ac5x3QL5tYqAsuQk0kBt5dBqfH3DQQp/Ehe SaM8dibDK9WuPymCeIThRXe7HllnxYEzia0C8SC5WuPU5YJIdIrGN4CFeF0zq41POb0g 4gSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708456442; x=1709061242; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GBBZEpewC9BLRC+ZISwlxkj/pUQLQpzkfsio0tQwFB0=; b=G8koPxt743Ui2wxdq3iicc2l8HRyBkjN60TH4Oy5SLY0xRfidCp34UthsyP+76Crfg CBQWgFHOHmA4iGKpjDTuTAd7rWvYi3TKLqOsCskqtlzdhrKzZ/sNufHXD2alktaejY4f SbU4laQ9oDk0XyZaFu+ArSdlB0qrOv7qB0/tRk1wfjzSgnmD8WhEJnGC8ppXgcd4OWOb NJBxNQl7m6yAlGUZLLxv3A3r9XTOplwuH9MhtpYu00UQpvCcd10OwmiSFLJWn3vmBdFU vW7m/PmLz4uqse0NkDCsSSsi+FwmuD78KRN49x71YjTBcZS1vvlyXIFn36ov8eUKCQN8 hfAg== X-Forwarded-Encrypted: i=1; AJvYcCWWpzZEKV577+wnxY1/hu1jHRbcDEdi/4UBnQZb/Vs3VHKe7iKjGf4hLXglCAHIRA+a6X1MJC/oEtgB87hJj4Y84eGxC+P3HvOlmTIM X-Gm-Message-State: AOJu0YzZdGwb5D0S4jjCbxvlQsXICoAMPkTmzTgHvuJXFD1M+nO+TPQo 3yDjiS4gBxo+oEOLiUpFbxtqzQoD1LkVPMB9Ngc06jjiaqptl91Z X-Received: by 2002:a05:600c:1391:b0:410:e41a:fc0d with SMTP id u17-20020a05600c139100b00410e41afc0dmr12504690wmf.24.1708456441861; Tue, 20 Feb 2024 11:14:01 -0800 (PST) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id i6-20020a05600c354600b004107686650esm15807564wmq.36.2024.02.20.11.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 11:14:01 -0800 (PST) From: Gabor Juhos <j4g8y7@gmail.com> Date: Tue, 20 Feb 2024 20:13:47 +0100 Subject: [PATCH] phy: qcom: m31: match requested regulator name with dt schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240220-phy-qcom-m31-regulator-fix-v1-1-7675b4a916b3@gmail.com> X-B4-Tracking: v=1; b=H4sIAOr51GUC/x3MwQ5EMBCA4VeROe8kbSnhVTZ7KAaToEyXEPHuG sfvP/wXBBKmAFVygdDOgf0coT8JNIObe0Juo8EokyljFC7DiWvjJ5xSjUL9Nrq/F+z4wLKw1ro st6rWEAeLUMzv/Pu77wdEwVPabAAAAA== To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Sricharan Ramabadhran <quic_srichara@quicinc.com>, Varadarajan Narayanan <quic_varada@quicinc.com> Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Gabor Juhos <j4g8y7@gmail.com> X-Mailer: b4 0.12.3 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791446616779147907 X-GMAIL-MSGID: 1791446616779147907 |
Series |
phy: qcom: m31: match requested regulator name with dt schema
|
|
Commit Message
Gabor Juhos
Feb. 20, 2024, 7:13 p.m. UTC
According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
supply regulator must be defined via the 'vdd-supply' property.
The driver however requests for the 'vdda-phy' regulator which
results in the following message when the driver is probed on
a IPQ5018 based board with a device tree matching to the schema:
qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
This means that the regulator specified in the device tree never
gets enabled.
Change the driver to use the 'vdd' name for the regulator as per
defined in the schema in order to ensure that the corresponding
regulator gets enabled.
Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
change-id: 20240220-phy-qcom-m31-regulator-fix-97555a4650b1
Best regards,
Comments
On Tue, Feb 20, 2024 at 08:13:47PM +0100, Gabor Juhos wrote: > According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V > supply regulator must be defined via the 'vdd-supply' property. > The driver however requests for the 'vdda-phy' regulator which > results in the following message when the driver is probed on > a IPQ5018 based board with a device tree matching to the schema: > > qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator > qcom-m31usb-phy 5b000.phy: Registered M31 USB phy > > This means that the regulator specified in the device tree never > gets enabled. > > Change the driver to use the 'vdd' name for the regulator as per > defined in the schema in order to ensure that the corresponding > regulator gets enabled. > > Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver") > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> > --- > drivers/phy/qualcomm/phy-qcom-m31.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c > index c2590579190a..9d84858ba1db 100644 > --- a/drivers/phy/qualcomm/phy-qcom-m31.c > +++ b/drivers/phy/qualcomm/phy-qcom-m31.c > @@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(qphy->phy), > "failed to create phy\n"); > > - qphy->vreg = devm_regulator_get(dev, "vdda-phy"); > + qphy->vreg = devm_regulator_get(dev, "vdd"); > if (IS_ERR(qphy->vreg)) > return dev_err_probe(dev, PTR_ERR(qphy->phy), > "failed to get vreg\n"); > > --- > base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d > change-id: 20240220-phy-qcom-m31-regulator-fix-97555a4650b1 Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>
2024. 02. 23. 12:49 keltezéssel, Varadarajan Narayanan írta: > On Tue, Feb 20, 2024 at 08:13:47PM +0100, Gabor Juhos wrote: >> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V >> supply regulator must be defined via the 'vdd-supply' property. >> The driver however requests for the 'vdda-phy' regulator which >> results in the following message when the driver is probed on >> a IPQ5018 based board with a device tree matching to the schema: >> <snip> > Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com> Thank you for the review! Regards, Gabor
diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c index c2590579190a..9d84858ba1db 100644 --- a/drivers/phy/qualcomm/phy-qcom-m31.c +++ b/drivers/phy/qualcomm/phy-qcom-m31.c @@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(qphy->phy), "failed to create phy\n"); - qphy->vreg = devm_regulator_get(dev, "vdda-phy"); + qphy->vreg = devm_regulator_get(dev, "vdd"); if (IS_ERR(qphy->vreg)) return dev_err_probe(dev, PTR_ERR(qphy->phy), "failed to get vreg\n");