[net-next,v2,3/3] Revert "net: bcmgenet: Ensure MDIO unregistration has clocks enabled"
Message ID | 20240219204053.471825-4-florian.fainelli@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp118648dyc; Mon, 19 Feb 2024 16:45:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUbHWjJrGq7pOEWEz+iqmmBmJtJPO/kX+9rsbAlD1BFU1ZNE/bVkQfVhieUhl4inhrVGMp6JyWZWl0AjFvZBo3ZNjJmyg== X-Google-Smtp-Source: AGHT+IE4uDxWuosLzRhCtMRk8uaxDEqCiSIzkAsgjuujtcMS+NO/ry3xpg3bStyAvV1n/OlJ1Su7 X-Received: by 2002:ad4:5d42:0:b0:68f:3dfa:951d with SMTP id jk2-20020ad45d42000000b0068f3dfa951dmr13269194qvb.56.1708389954020; Mon, 19 Feb 2024 16:45:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708389954; cv=pass; d=google.com; s=arc-20160816; b=dXuNGdbGGRR9zPl2KDmoikIEMsK502yBaBye1HOgJqwIy7UjiNcQAJg1ZoqnrdLLyk R4sNYWIgqzdZJKUVJwIgB5x2DWfb2xoRX5JBvxF+Npxfro5ocyJ2+df96OTCnIS1d+Y+ HFUG/oTqSpU8/PuNAMAlfobKCgeJiifTKJ0vBQBF9ozgr3N2ckgTQbb3rojfDzPo4uaf QbH4h+qJQ8YK+qBIDSyv3tzvk56XhdXxpCU2UG9Fka2ksS0ec9SCzgcQpqIVCoKmWGSj 6vwVS45atP2r0Gm1sgwxy+6JXw16nMxyKJHmdqPHROwUWLgGNtaYTI20bGpTViBb1kY4 ivAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-filter; bh=A0TlXKrkc7oaN+OEDCLZ+cP+0vqzDV2WAem3I9ZzSrs=; fh=j/OwmfJVRgCPa4uSHTSwxfS2Laf6Vp3HYivcwwufwU4=; b=Z37zZQ8eya7IwDjf6QDst0bPxS1V5xNbXpufJ5PoA+fLPk947UETvWfiY597nCIC+l exYhO2gy6UPhvKgJlZHos/30vcYTFQMcvNkVVU6K+4yJzv1dOI2dsqPobVj2DHBwnz7O mvSvUpJ80M6jtp/iB03hpRTwr91FMSexUYngd56Vd4pSboEa0cf6oqpJHFXL31fXLDQC wc4WGezTpQtwHqfnbEb5PXccFbILcQSkpyGYlYT971yzF6iALACzoYen+uKkEOF5jMtM cRPs+mqAWNrBDU4QBTkqnKtDJwYP599ODN/0O6M0IN5cfXLHl9fRuqBqRPY4kZjh+o2l PxVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=WA993cE8; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id pt1-20020a056214048100b0068efc03dfe8si7284479qvb.582.2024.02.19.16.45.53 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 16:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=WA993cE8; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71975-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3DA0E1C23D3B for <ouuuleilei@gmail.com>; Mon, 19 Feb 2024 20:42:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B96705577E; Mon, 19 Feb 2024 20:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WA993cE8" Received: from relay.smtp-ext.broadcom.com (unknown [192.19.166.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EBEA50267; Mon, 19 Feb 2024 20:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.19.166.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708375265; cv=none; b=W1yPAec7knUFOvk2WZCERNxpXiAGt3nWJ/GFNhcgZwAhYo+WY3ugt77LXoJbJVkK34ZsnYcm9OEH8MF9BURa2p7ZH0cFN8TsiSxUbEl0T0UjKATx3E3xvt8r/V5CIl7/ZSzeAWNFbQUFxKbf5ksa2hJAqC71RpxuIQKhnhLGOlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708375265; c=relaxed/simple; bh=o0TlAjqIB1czzINK/rdoqCJ5lVeAGeS7FC7bZcSamiY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ulcD1rrm2m6bgdG21j6QpFBsh3wWyHPgDoiSJwUYdlC2WSnywrjmRVat3z5DwNSAILsZbOD7PBZtqEcY2py2eGb7u2No7t5EyO2tS8lp5mOwAWsiIIYvBAclHnHM24Y4OsIFpLcXtVrzt6iu6jLwtGK8ZHWJOZpwdvLA9e6RAdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=WA993cE8; arc=none smtp.client-ip=192.19.166.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 87A5DC003B80; Mon, 19 Feb 2024 12:40:57 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 87A5DC003B80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1708375257; bh=o0TlAjqIB1czzINK/rdoqCJ5lVeAGeS7FC7bZcSamiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WA993cE8MyTCiGVAijtq+cwOqHy0emZjkb0SIvPNlCiIIBuZdvCdMA1r8ZkbShTVC y83hso+wdYgRpnjeHvDrk2GTZnrooZFm4NhgzHv+t5JX2hxSpRrEK/yRXYk03yVLLj nTgjAtB0SPJa01DIb5QkNYZ7eHSsdYRrOkVXfxFY= Received: from fainelli-desktop.igp.broadcom.net (fainelli-desktop.dhcp.broadcom.net [10.67.48.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id 0989518041CAC4; Mon, 19 Feb 2024 12:40:56 -0800 (PST) From: Florian Fainelli <florian.fainelli@broadcom.com> To: netdev@vger.kernel.org Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Jacob Keller <jacob.e.keller@intel.com>, Doug Berger <opendmb@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org (open list), Justin Chen <justin.chen@broadcom.com> Subject: [PATCH net-next v2 3/3] Revert "net: bcmgenet: Ensure MDIO unregistration has clocks enabled" Date: Mon, 19 Feb 2024 12:40:53 -0800 Message-Id: <20240219204053.471825-4-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240219204053.471825-1-florian.fainelli@broadcom.com> References: <20240219204053.471825-1-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791376704287913935 X-GMAIL-MSGID: 1791376704287913935 |
Series |
Rework GENET MDIO controller clocking
|
|
Commit Message
Florian Fainelli
Feb. 19, 2024, 8:40 p.m. UTC
This reverts commit 1b5ea7ffb7a3bdfffb4b7f40ce0d20a3372ee405 ("net: bcmgenet: Ensure MDIO unregistration has clocks enabled"). This is no longer necessary now that the MDIO bus controller has a clock that it can manage around the I/O accesses. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 7a21950da77c..9ada89355747 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -678,7 +678,5 @@ void bcmgenet_mii_exit(struct net_device *dev) if (of_phy_is_fixed_link(dn)) of_phy_deregister_fixed_link(dn); of_node_put(priv->phy_dn); - clk_prepare_enable(priv->clk); platform_device_unregister(priv->mii_pdev); - clk_disable_unprepare(priv->clk); }