Message ID | 20240219185809.286724-2-oliver.upton@linux.dev |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1475183dyc; Mon, 19 Feb 2024 10:59:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWr5Ch+qS6KZulvIaZ6Vc66yY1XhgNnxWOjyM9v6ofPtCzbHhZO5og0L3DgkZ/kfvY78a30CmZGkt500AS4j26r0+ecHQ== X-Google-Smtp-Source: AGHT+IF6ur5uSUmArFbo93UWYPloCYjFAEts9U2jOlenfbVxdRqepQ7YoMX0eOYf1jmiybRvCQMY X-Received: by 2002:a19:6502:0:b0:512:b24f:8336 with SMTP id z2-20020a196502000000b00512b24f8336mr2446193lfb.27.1708369157432; Mon, 19 Feb 2024 10:59:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708369157; cv=pass; d=google.com; s=arc-20160816; b=tMuH2HBy+x7+GA34/MLDnyyFmC2nLd9eAa+NjAZF130VLoC+1JnwcvwK8Vpo4sS24Q csfeoO68zE6k6Sr0JkxC9eZj31sD/uD+VUzWEiG0VJG6b67aH31bNtsXTD1p+e7qGhTf GfGNw8esoHmQpLAQEPNegP3h88qnC9WapDhonurYd7VkGsLy0FGBGm2nEEFGxfNlhvPl klzOX9AfkLKDrr2GPWszjEIci0gtz8A9Fa09W13J9oKJs3hAL7KNvRX+vaRImnalsubH FkWB1J9P4XO5S2XZO/jDY5pYgCwcGx+fMbiaoQ+QANcRAukLBA5SRitYobXb4TDL1fXK THvw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=malznfxmTFeYI5AQuBOcx//3J2Klq63IEw4UgO+FW8I=; fh=PoZSk4NBlSl3lK4uTZC6W+wPRyAdQQ0EuxnJHtYkfRY=; b=bGZPJbw6RwLZuvSuXQhBmZZi09/GbYgfFUWDZRjbl51xj16rhJO5N0NxcRo+5vTTfY theH25PgLlnLB8p7S9MTTDyGrkuQwSh18+9CS/cOHUo8GW+Okyaindx/cWGrZdcW1G18 a3Az1XtA9T4JI8Loxxv+a2yOkcJvHuzthP2H0soDC7BOymFg7f+0YrSsaIS9RGFFfJVS dhQA6hD5o919TET9HiaVmZ6YTU02SKCYCyXR4nu6UM2stkZGLQJEd9aU++Od7IFBM0TH OtU3rxWrWV/TzQQ2pL+dCClnbOnmzKndsAJMljonVsxxnUKONxjZOGUeovtURMsiDWvi 4c0A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TymjM0U4; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b15-20020a170906038f00b00a3eea20dc57si66243eja.129.2024.02.19.10.59.17 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 10:59:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TymjM0U4; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71847-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F2AD31F22337 for <ouuuleilei@gmail.com>; Mon, 19 Feb 2024 18:59:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1EF7B4EB53; Mon, 19 Feb 2024 18:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TymjM0U4" Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC12B482FA for <linux-kernel@vger.kernel.org>; Mon, 19 Feb 2024 18:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708369107; cv=none; b=ePrMEKKjfefBlXVD12eAYNccFWXNRVUrS/1nqRzszoBCCrE94R85eLZheAIVmx4GpkSgzyQNTMjRTTul15HH2Knq4t7koajSg9UIeGarjRHvp2pUkPtpSa3UP9hodDrnQG6MrqLBwmQo+kmdnuBStd+dIafV/9zk+YqD2fgEzRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708369107; c=relaxed/simple; bh=yXY4BKwNMqksd8A/oUnvq+Iq0aUB3gr/Y3i4+5lzsvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XEiV+Dxi6peydmR5eKuE/t/Sko1MTkGYG6mKlzR2Q3XYeY/gDQNDy63yAzdqV5nPLPoMmrFjhHtAOl9AjVvIfoZ7VtJqj4g0ooXSnNgIcOrgg6e+jP+tGm72h2WbIrnJpFJE09JgwkCu/VE11w9Z9bBS0EYNU/d7i/dC2mfkCQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TymjM0U4; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708369103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=malznfxmTFeYI5AQuBOcx//3J2Klq63IEw4UgO+FW8I=; b=TymjM0U4219Zm3uEd/Lb8NxsD72R3xzRJZRLZBjvd9XHgLBu8YMPWhynBzrl8JRv3paxch lwj9pWCJOssGT/aTbkmYfA4DY/0hoWqJyMUQMa+NXEZkMY7B5s52UXj0Q2QgC1umO8It4y kkbdXBlbN4LMCE9vFrfXl6eQVykFEc8= From: Oliver Upton <oliver.upton@linux.dev> To: Thomas Gleixner <tglx@linutronix.de> Cc: Marc Zyngier <maz@kernel.org>, Zenghui Yu <yuzenghui@huawei.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Jing Zhang <jingzhangos@google.com>, Oliver Upton <oliver.upton@linux.dev>, stable@vger.kernel.org, George Cherian <gcherian@marvell.com> Subject: [PATCH 1/3] irqchip/gic-v3-its: Do not assume vPE tables are preallocated Date: Mon, 19 Feb 2024 18:58:06 +0000 Message-ID: <20240219185809.286724-2-oliver.upton@linux.dev> In-Reply-To: <20240219185809.286724-1-oliver.upton@linux.dev> References: <20240219185809.286724-1-oliver.upton@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791354897373524293 X-GMAIL-MSGID: 1791354897373524293 |
Series |
irqchip/gic-v3-its: Fix GICv4.1 initialization after kexec
|
|
Commit Message
Oliver Upton
Feb. 19, 2024, 6:58 p.m. UTC
We go through quite a bit of trouble to make sure we pick up any preallocated LPI tables on the redistributors, as enabling LPIs is a one-way switch. There is no such restriction for vLPIs, and for GICv4.1 we expect to allocate a new vPE table at boot. This works as intended when initializing an ITS, however when setting up a redistributor in its_cpu_init_lpis() the early return for preallocated RD tables skips straight past GICv4 setup. This all comes to a head when trying to kexec into a new kernel, as the new kernel silently fails to set up GICv4, leading to a complete loss of SGIs and LPIs for KVM VMs (ouch). Slap a band-aid on the problem by ensuring its_cpu_init_lpis() always initializes GICv4 on the way out, even if the other RD tables were preallocated. Cc: stable@vger.kernel.org Fixes: 6479450f72c1 ("irqchip/gic-v4: Fix occasional VLPI drop") Reported-by: George Cherian <gcherian@marvell.com> Co-developed-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Oliver Upton <oliver.upton@linux.dev> --- I debated a bit on the fixes tag between the blamed commit and commit 5e5168461c22 ("irqchip/gic-v4.1: VPE table (aka GICR_VPROPBASER) allocation"), although it would appear GICv4 could be left in an unknown state after kexec too. drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index d097001c1e3e..0022852ce494 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3172,6 +3172,7 @@ static void its_cpu_init_lpis(void) val |= GICR_CTLR_ENABLE_LPIS; writel_relaxed(val, rbase + GICR_CTLR); +out: if (gic_rdists->has_vlpis && !gic_rdists->has_rvpeid) { void __iomem *vlpi_base = gic_data_rdist_vlpi_base(); @@ -3207,7 +3208,6 @@ static void its_cpu_init_lpis(void) /* Make sure the GIC has seen the above */ dsb(sy); -out: gic_data_rdist()->flags |= RD_LOCAL_LPI_ENABLED; pr_info("GICv3: CPU%d: using %s LPI pending table @%pa\n", smp_processor_id(),