From patchwork Mon Feb 19 11:16:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolu Lu X-Patchwork-Id: 203139 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1337878dyc; Mon, 19 Feb 2024 07:01:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/nzmUyfRVtKAtfQY7sJzSMB2xIUgeGq6tJCivI4ZtYP8B2HSQbw1MOL7rEYdsrvbrGxQrCFjNm7LK6S+jHQrcPXEIAw== X-Google-Smtp-Source: AGHT+IHrjslxlf+LHL0ir/CtSSZlPStdrNgnpJ4tqVBmVXmd2eFrNKHPNJiCadC0lximZw+2UvnI X-Received: by 2002:a17:906:7d48:b0:a3e:39a7:b1e7 with SMTP id l8-20020a1709067d4800b00a3e39a7b1e7mr3643964ejp.10.1708354919288; Mon, 19 Feb 2024 07:01:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708354919; cv=pass; d=google.com; s=arc-20160816; b=iCxLEnw10Ay40/+Dk0S2HBGXCoZHCgfWv5ubfLiQoUCmkHmSmDhO9Fj7cWmePZEfae aivASc/N/N7eQRCUuoHuIB8QJ2fSxPUvt8GvQDZqXDPynQkRtJP9humMef4JAjpKqz51 IGUHHnBReJQojdQ+mASkoQBeOMoo49sAbcpqoUWvGMNMdePHX4sxiSutLd9NhMQJedJQ 9fFkEC+djI7y2I9tvZaiJWhB9Ge56Ggwfm9fAZnOUPQKWBa/FTroC+RwF7KIIrnWb+mR HpdiJUx0WmrTwtzXiYD7fCsB/zaq1NnjoLUckuLhXlpt8YKv5mgOdm72dN0wUCihXDkG CVqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=e/MZKjCq3h6+VDQ8o1GpLcuIiGyRUvcuUDITCRMc6n8=; fh=xIXrYyuim0+qQ0OPX7PXG3ceqpJb0Om6wEk3bRGARVs=; b=W8xwxLf1dlR3bpNfbGbpisxGaFJ4xf+vNgb3qMF1xOEp6sNl/A3Dl8m1Zb5ibR15Ws GuI+xgS4NszhcANy9TCQNtQ4B3L0GheWK+yzq9ugJhD09VnsBlBYXIoAHdrtCH3ePJn6 uYo9gMxK4CwglqS2DQVLrDLtczWvrD2sIJrZO38qPL1Nsm58B/sR1utYPTxRUUI1CsvA I3s7DcyHbq2WLxI2fxedDx6Hcbrm7Hm66E15qOsHzGq17fsZ8Dt2VOGGK8ehHp4zCqjU aGGYhy/6AhxMXvHzv8Fb1i81+SpSYQB/bCNYJb+LIi3s4/WdwAMrgqX43uHQRZXghBQj 3JLg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EBdJxPIP; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71194-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71194-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o2-20020a1709061b0200b00a3e848b80a5si1017622ejg.1055.2024.02.19.07.01.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 07:01:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71194-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EBdJxPIP; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71194-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71194-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 125551F23EC1 for ; Mon, 19 Feb 2024 11:24:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FB8D33CC9; Mon, 19 Feb 2024 11:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EBdJxPIP" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5C52E84D for ; Mon, 19 Feb 2024 11:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341734; cv=none; b=eRdyQLl1c8MqC1TNLs6eLQTxolCeAG6fUQpZLp0GgWbYUAO7XEUxC2b94om8j1UArCOKnQ7B4K/FBIplV3UOa2/f6XSrEJLbr6VCA9wwNk6yNvIXVlJypwfwFRsKjuRRksVJIXwr0QFRMBXnXbiz6QavRD3Gw7mdyWUrrAQZQ6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341734; c=relaxed/simple; bh=SU6KvDmjdOLfKEuiZcMfCTvca3+Q7A/X/vy1dY8kqnw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LcaJe2B+PLJKBufBwb9jOcCuUN7CEf1rgDDeP5UqLSgI2ALRQKi6FyjRt67OoNKvUThCLS9U2xz/t85fTSliCvB0yx4RDb4Zhr+meopjHc6B4JuSjXLR0CUaINOLaaV8OSNe/xcEHW6vyowQ58+fcta77w+dKBAPUqn36JG3CQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EBdJxPIP; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708341734; x=1739877734; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SU6KvDmjdOLfKEuiZcMfCTvca3+Q7A/X/vy1dY8kqnw=; b=EBdJxPIPo4sTDzacUdw5qr/UfWMp8L2qPPd9XtT08rek0PjqODxZzYL3 7/vLaUPkWXkgRbECXrUSn1Szlvr6yfQ1fh+THVGNFPF2oolA/sJTc/jw3 hvik2zTyU6v5OdHi9yVSGsoOLu53d5j2WIqVmfdKPW6dqKS58LaL+wVa0 VIZJ7MvCzs1h/soVYw8ZcER1HmzBYYQcGzWAOwUE23mwEKLtGe1gAl0Ff 0Z3oge1y3dDjSygKdPkaAaiiwe5cFUEdK6JVcoiuJCc4oKoa4C54CMkgM RLD4gTqegpMaAJJaZKTWC73lEV9PTkFPSj6ZHVF4stAhYoYRBfPfv9ZW0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="13823406" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="13823406" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 03:22:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="4826883" Received: from allen-box.sh.intel.com ([10.239.159.127]) by orviesa006.jf.intel.com with ESMTP; 19 Feb 2024 03:22:11 -0800 From: Lu Baolu To: Joerg Roedel Cc: Yi Liu , Arnd Bergmann , Kevin Tian , Joao Martins , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 09/10] iommu/vt-d: Set SSADE when attaching to a parent with dirty tracking Date: Mon, 19 Feb 2024 19:16:00 +0800 Message-Id: <20240219111601.96405-10-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240219111601.96405-1-baolu.lu@linux.intel.com> References: <20240219111601.96405-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791339967577889321 X-GMAIL-MSGID: 1791339967577889321 From: Yi Liu Should set the SSADE (Second Stage Access/Dirty bit Enable) bit of the pasid entry when attaching a device to a nested domain if its parent has already enabled dirty tracking. Fixes: 111bf85c68f6 ("iommu/vt-d: Add helper to setup pasid nested translation") Signed-off-by: Yi Liu Reviewed-by: Joao Martins Link: https://lore.kernel.org/r/20240208091414.28133-1-yi.l.liu@intel.com Signed-off-by: Lu Baolu --- drivers/iommu/intel/pasid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c index a32d7e509842..108158e2b907 100644 --- a/drivers/iommu/intel/pasid.c +++ b/drivers/iommu/intel/pasid.c @@ -657,6 +657,8 @@ int intel_pasid_setup_nested(struct intel_iommu *iommu, struct device *dev, pasid_set_domain_id(pte, did); pasid_set_address_width(pte, s2_domain->agaw); pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap)); + if (s2_domain->dirty_tracking) + pasid_set_ssade(pte); pasid_set_translation_type(pte, PASID_ENTRY_PGTT_NESTED); pasid_set_present(pte); spin_unlock(&iommu->lock);