From patchwork Mon Feb 19 10:09:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faiz Abbas X-Patchwork-Id: 202993 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1187623dyc; Mon, 19 Feb 2024 02:10:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUYc0bpGWeJutBOlYPCNvXv/isa8CIPQlBZP8OnVOMXrYJ5hMb2tp4Lm+pi9RTAIEC25jQyoYigDuV1AzuDDcb9TzuR2Q== X-Google-Smtp-Source: AGHT+IHcq2fYBt/aCL5DseX2S9l0AEFqtdhndfyZMAPpIdWKQwzDir4lDpniZZBdQ1mHwixHkJlW X-Received: by 2002:a05:6a20:2d0f:b0:19e:9da4:1a10 with SMTP id g15-20020a056a202d0f00b0019e9da41a10mr17826327pzl.21.1708337429606; Mon, 19 Feb 2024 02:10:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708337428; cv=pass; d=google.com; s=arc-20160816; b=Zypakppap+6jRrrfhGAgo4KcdNgJamNF12EA1nRyMNX/3aiZ7500mdKBwD2lOvY/G0 AstfZ5Sm0c4UTYPI4UYWiP4WizHGCh9Fg4fXB5yYlu4rWQ2KUbPrz4AjkCyBdWXo7i92 R0cDa30ikE7bHE/SsO4s3S0uG+F7cQIKZySXWndaA34jm3A9SFepcJOaPRQYw7xe9MR8 iUXMcEo5rZZxwYDv6PDtzvLKzpRfrasYxJB4shrkPV9NwxOfcuhX1A46VG01l4y0Jnay 9YpHdYmseBURZkoaqC9F6dSWSDujWaDC5d2J6K3wzqaLgiQxWNIffOP3BXrQBekt5UyM OkZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=fmIgXzPT4xJWGNhy/SbQKDjNzJ1F2ZnRTlY3Jd/lP8U=; fh=dx8DbI9TeNJJkSzHj/c+TozYIktuxUzSK1EQ7Thrsz8=; b=QTJJk2/fqjiQktLw4zKMPMoQnE67R5aGZJZ9wgFw8kTFo2KFn0X6NI49rUm3yw1VM6 yKL06b1HE6PyFhKjsV+xBwO0ce7HKCoPc4ukg98ZmrlIpmd/a7heN1vZNEbN4CX9iE0q AS733ht7msn8BvTC4JjYkh3G58104ftep0tKCDqZYrp18isJreL5znz3UkuoZjoS3MXA QrwdfVUnFYz/KuWiUl9ZD+tPNL/5nWnSpZsnrBXaV7lQS8xcUn5nKvWONDQtH3lir2zp eG64imw7snODaaJDNh6qHVYBf+3ELvjg6sy1lBCzM0VI+N/OErI11ufSody0lZvl1cnh I2Kw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-71098-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71098-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a26-20020a637f1a000000b005ceca1094c3si4148393pgd.853.2024.02.19.02.10.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 02:10:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71098-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-71098-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71098-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DB9FC281F87 for ; Mon, 19 Feb 2024 10:10:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B97B12C1A9; Mon, 19 Feb 2024 10:09:39 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C721428E22 for ; Mon, 19 Feb 2024 10:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708337378; cv=none; b=fwIWMG8KZ47XVfJb5xkI7aMwdvXBofHNP7+w3KrgY2H0UcJPAsZ1BUt/J/uJ1dJMNIgfkTTsWdJHKPKe9AfDWwwaplXSOMBoseNYYyOg0eOF8A2bQV9IHBDUxlkD+V9xRqoNluflBJwFdn1wIWefbp6wrTBI5wNoAKEGlm4Gg9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708337378; c=relaxed/simple; bh=D+5MITGSTIWZmg+eDLdAq8eiW/paDZ2Wz+SdaFAiXlc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Sr7inpt1zeWfI+4DbJnDZXKlH9gk3TyJp352562kO7YpJ1BB/ERV4s57+pwFzflVPABuMFucItDVjkJvG42bmFk4/EIDEjAWHygNo+WufUydqnW2G/Nj6qp7pWtGJP3w/RMVhUuUeMusL6Zw0zQKGBz8qikrIKCbh1Mbfc0RynU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 009491FB; Mon, 19 Feb 2024 02:10:16 -0800 (PST) Received: from a077854.blr.arm.com (a077854.arm.com [10.162.41.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 801233F762; Mon, 19 Feb 2024 02:09:33 -0800 (PST) From: Faiz Abbas To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, Faiz Abbas Subject: [PATCH 2/3] drm/arm/komeda: Move pipeline prints to after the entire pipeline has been enabled Date: Mon, 19 Feb 2024 15:39:14 +0530 Message-Id: <20240219100915.192475-3-faiz.abbas@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240219100915.192475-1-faiz.abbas@arm.com> References: <20240219100915.192475-1-faiz.abbas@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791321627209312021 X-GMAIL-MSGID: 1791321627209312021 The komeda driver prints a pretty verbose log in komeda_pipeline_dump() detailing the components of each of the two pipelines. This gets printed multiple times during boot as komeda EPROBE_DEFERs waiting for the remote bridge drivers to come up. Move this log to after this has happened indicating that the printed pipeline is actually completely up. Signed-off-by: Faiz Abbas --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 + drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index b645c5998230..92ac09dc033b 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c @@ -667,6 +667,8 @@ static int komeda_crtc_add(struct komeda_kms_dev *kms, drm_crtc_enable_color_mgmt(crtc, 0, true, KOMEDA_COLOR_LUT_SIZE); + komeda_pipeline_dump(pipe); + return 0; } diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h b/drivers/gpu/drm/arm/display/komeda/komeda_kms.h index a4048724564d..83e61c4080c2 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.h @@ -191,5 +191,6 @@ void komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc, struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev); void komeda_kms_detach(struct komeda_kms_dev *kms); void komeda_kms_shutdown(struct komeda_kms_dev *kms); +void komeda_pipeline_dump(struct komeda_pipeline *pipe); #endif /*_KOMEDA_KMS_H_*/ diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c index 4b7d94961527..4b64ed9e9df5 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c @@ -9,6 +9,7 @@ #include #include "komeda_dev.h" +#include "komeda_kms.h" #include "komeda_pipeline.h" /** komeda_pipeline_add - Add a pipeline to &komeda_dev */ @@ -246,7 +247,7 @@ static void komeda_component_dump(struct komeda_component *c) c->max_active_outputs, c->supported_outputs); } -static void komeda_pipeline_dump(struct komeda_pipeline *pipe) +void komeda_pipeline_dump(struct komeda_pipeline *pipe) { struct komeda_component *c; int id; @@ -350,7 +351,6 @@ int komeda_assemble_pipelines(struct komeda_dev *mdev) pipe = mdev->pipelines[i]; komeda_pipeline_assemble(pipe); - komeda_pipeline_dump(pipe); } return 0;