From patchwork Mon Feb 19 07:44:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 202920 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1134468dyc; Sun, 18 Feb 2024 23:47:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXvL2GNVk/OpKmLDsr6Mgin+T6oE3srMHa2aqdVYsFM42aosHUM55t6YKI+ur5ZznyCvCNpegvXHUQJMDSS/Y1alllaYw== X-Google-Smtp-Source: AGHT+IFXkTsKYpDp98I747ncuB09VW8rZv3hZzygmcrDuJYeEuGbBN59eWEKmb6hKQLoG2W9Y4q+ X-Received: by 2002:aa7:c54d:0:b0:564:46c0:29d1 with SMTP id s13-20020aa7c54d000000b0056446c029d1mr2404110edr.12.1708328859768; Sun, 18 Feb 2024 23:47:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708328859; cv=pass; d=google.com; s=arc-20160816; b=D6xq0N7mb1SY2QXe7BVkQDaR2s6Xt9gm8/tOvIhnwXAYVU2ViF+DvZo2nc7TkixeTl RNIS5144jPuIv1ixlhv/iVQAoXrDVS0yoMw/zYPns5xKFyDr89Eaxbfo/AE5V0wBWgXX S+XjH5u9281nILvF68K/t2/18ygvHKfaaj1qPHhGFyJ5xolbjEUY45JAz3dlYjUX1EOX XnC9bAteG4uHgAh6cGKssgftN0FFe7Gvzog9jAaw+TFkFk9k0PNxUQOH2d1bzMjg6aDQ jXnv4N921LY4+FaTMCg3B1m3B9k7F6DKv4RPidaG4rfTf/QAWhh04CZPg3ACBINXIRpi QFWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=mUH8Ldjjxi8it9eaRNAUP8jiOKNg7HpR2OKWq4ySMwo=; fh=YX4HbHS7wMJfdu6Xp+2MgHIyDiEardnLcvtWgzaTy/w=; b=yJebCs1Q8c1DuCh3eJucmrsGvyQu/I9SL7fgBIrad7UvRYicnzwOBFDqmJkxGzaTTB C8KvSve48vH9Xxoneb9N0m9eZWV671Hm6mGb1Pe6BK5R0J857Wa0uLSDtdiy1+pQvVbY +x0WfzawVIy3GRbD9Fif2h0XcdZo+9+Fw+DvOp4p+Ab4gXXS+nGSGgwzNZ2DzvS9fypA VGRZrnr5O3TVBdaGRzmjYf0aEW2O6tmwsP1enJ8qsMDywyVwkZhWli+cyKmvV4+OTL3D BoQjWowYTFbfDuIXi5d2NOSCsOiyNLDrnJUAQE+7rC507pG91soqixU5PtJ/a0klZeCG YvSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=i+318xeZ; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-70856-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70856-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id cz19-20020a0564021cb300b0056486da5cbcsi368469edb.476.2024.02.18.23.47.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 23:47:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70856-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=i+318xeZ; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-70856-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70856-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 64F1A1F21B97 for ; Mon, 19 Feb 2024 07:47:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DDA825542; Mon, 19 Feb 2024 07:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="i+318xeZ" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3E124A07; Mon, 19 Feb 2024 07:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328734; cv=none; b=QkbiGmrmWj9Ex9HJ+1YSbf1+wmMgTyttwJrLK9BstYywWk+JDemrz5WoLeWduphwvlB0WpVtcovSgSp3EjCh8jfww9NjgVw8osYI/Fk1gzrxdS6sXh6FLOS8361CJWp3Lz/tANG/ncMwOAodTmMYeRm2h4C2yTQeI23g/I/QM0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708328734; c=relaxed/simple; bh=dzKZXblpWESFyKaff5lcUS9bN5Ok7BHsB49SOtV2pf4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JEBhbdFk/8sbuMCIuCSucrblJaxhUw7HZdxPkixYztUexDq6iNvvyWHLUyVkPu+7sKygPoCoqODBWNiGB/qXNTa00jyTKjl3VaZsXNVY6+6ofX6wsR0oX+e3hYd7mvL3B3FsJEMsghynD4+AaF3+TTetHjFl0FdqTvyvAlgpQtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=i+318xeZ; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1708328731; bh=dzKZXblpWESFyKaff5lcUS9bN5Ok7BHsB49SOtV2pf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i+318xeZVCAfHQo/qkZ1THsv4pUzuTYZgDX0kf9h+pl/WhwL0Y6iTjJWH2Aztk3BC jcAu8Fl8znXmnyW9IC4ErxRIO/sx323cSgsvzyxSCvG5W1aVG8vAV2apMKDQsZRatk hMTEaH9nLHO7pCT2PSNtsm2xaURZzMp8g1AfTZHhT8DWm7oGPdlFKm87xNbkz4NOzR IzP40/yth7SH10vlZ4AwlNIcus0yV7eHnIJzpFZjU6Zkln5FL4JPFrH0REj6CkbPR9 VWPUypJn4zELyfF79IYryINl+BVHh5G7dr5pBGMC0xIgrz2u9/FZlhYyzjPc0BgCff 8W6GNhBNDPpIw== Received: from eugen-station.. (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B191A3782087; Mon, 19 Feb 2024 07:45:27 +0000 (UTC) From: Eugen Hristev To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@collabora.com, eugen.hristev@collabora.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, krisman@suse.de, Gabriel Krisman Bertazi , Eric Biggers Subject: [PATCH v11 5/8] f2fs: Reuse generic_ci_match for ci comparisons Date: Mon, 19 Feb 2024 09:44:54 +0200 Message-Id: <20240219074457.24578-6-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240219074457.24578-1-eugen.hristev@collabora.com> References: <20240219074457.24578-1-eugen.hristev@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791312642348495101 X-GMAIL-MSGID: 1791312642348495101 From: Gabriel Krisman Bertazi Now that ci_match is part of libfs, make f2fs reuse it instead of having a different implementation. Reviewed-by: Chao Yu Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi Signed-off-by: Eugen Hristev --- fs/f2fs/dir.c | 58 ++++----------------------------------------------- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index f5b65cf36393..7953322b9b9e 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -185,58 +185,6 @@ static struct f2fs_dir_entry *find_in_block(struct inode *dir, return f2fs_find_target_dentry(&d, fname, max_slots); } -#if IS_ENABLED(CONFIG_UNICODE) -/* - * Test whether a case-insensitive directory entry matches the filename - * being searched for. - * - * Returns 1 for a match, 0 for no match, and -errno on an error. - */ -static int f2fs_match_ci_name(const struct inode *dir, const struct qstr *name, - const u8 *de_name, u32 de_name_len) -{ - const struct super_block *sb = dir->i_sb; - const struct unicode_map *um = sb->s_encoding; - struct fscrypt_str decrypted_name = FSTR_INIT(NULL, de_name_len); - struct qstr entry = QSTR_INIT(de_name, de_name_len); - int res; - - if (IS_ENCRYPTED(dir)) { - const struct fscrypt_str encrypted_name = - FSTR_INIT((u8 *)de_name, de_name_len); - - if (WARN_ON_ONCE(!fscrypt_has_encryption_key(dir))) - return -EINVAL; - - decrypted_name.name = kmalloc(de_name_len, GFP_KERNEL); - if (!decrypted_name.name) - return -ENOMEM; - res = fscrypt_fname_disk_to_usr(dir, 0, 0, &encrypted_name, - &decrypted_name); - if (res < 0) - goto out; - entry.name = decrypted_name.name; - entry.len = decrypted_name.len; - } - - res = utf8_strncasecmp_folded(um, name, &entry); - /* - * In strict mode, ignore invalid names. In non-strict mode, - * fall back to treating them as opaque byte sequences. - */ - if (res < 0 && !sb_has_strict_encoding(sb)) { - res = name->len == entry.len && - memcmp(name->name, entry.name, name->len) == 0; - } else { - /* utf8_strncasecmp_folded returns 0 on match */ - res = (res == 0); - } -out: - kfree(decrypted_name.name); - return res; -} -#endif /* CONFIG_UNICODE */ - static inline int f2fs_match_name(const struct inode *dir, const struct f2fs_filename *fname, const u8 *de_name, u32 de_name_len) @@ -245,8 +193,10 @@ static inline int f2fs_match_name(const struct inode *dir, #if IS_ENABLED(CONFIG_UNICODE) if (fname->cf_name.name) - return f2fs_match_ci_name(dir, &fname->cf_name, - de_name, de_name_len); + return generic_ci_match(dir, fname->usr_fname, + &fname->cf_name, + de_name, de_name_len); + #endif f.usr_fname = fname->usr_fname; f.disk_name = fname->disk_name;