diff mbox series

siox: constify the struct device_type usage

Message ID 20240219-device_cleanup-siox-v1-1-eb32ca2b0113@marliere.net
State New
Headers
Series siox: constify the struct device_type usage |

Commit Message

Ricardo B. Marliere Feb. 19, 2024, 7:49 p.m. UTC 
  Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the
siox_device_type and siox_master_type variables to be constant structures
as well, placing it into read-only memory which can not be modified at
runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/siox/siox-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
change-id: 20240219-device_cleanup-siox-82890e4378d0

Best regards,

Comments

Thorsten Scherer Feb. 27, 2024, 5:23 a.m. UTC | #1 
Hello,

On Mon, Feb 19, 2024 at 04:49:30PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> siox_device_type and siox_master_type variables to be constant structures
> as well, placing it into read-only memory which can not be modified at
> runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>

@gregkh: Could you please pick up this patch?  There already is another
patch [1] from Ricardo.  I wonder if this one flew under you radar or
if I did something wrong...

Thanks to you both.

Best regards
Thorsten

[1] 20240219-device_cleanup-siox-v1-1-eb32ca2b0113@marliere.net
diff mbox series

Patch

diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index 561408583b2b..8eca20c2ea9c 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -498,7 +498,7 @@  static void siox_device_release(struct device *dev)
 	kfree(sdevice);
 }
 
-static struct device_type siox_device_type = {
+static const struct device_type siox_device_type = {
 	.groups = siox_device_groups,
 	.release = siox_device_release,
 };
@@ -676,7 +676,7 @@  static void siox_master_release(struct device *dev)
 	kfree(smaster);
 }
 
-static struct device_type siox_master_type = {
+static const struct device_type siox_master_type = {
 	.groups = siox_master_groups,
 	.release = siox_master_release,
 };