diff mbox series

[04/12] net: vxlan: constify the struct device_type usage

Message ID 20240217-device_cleanup-net-v1-4-1eb31fb689f7@marliere.net
State New
Headers
Series net: constify struct device_type usage |

Commit Message

Ricardo B. Marliere Feb. 17, 2024, 8:13 p.m. UTC 
  Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the vxlan_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/vxlan/vxlan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guillaume Nault Feb. 19, 2024, 11:43 a.m. UTC | #1 
On Sat, Feb 17, 2024 at 05:13:26PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the vxlan_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.

Reviewed-by: Guillaume Nault <gnault@redhat.com>

Note: To help maintainers (and potentially reviewers) work please
write in the subject prefix which tree you're targetting. For this
series, it should be "[PATCH net-next xx/yy]".
Ricardo B. Marliere Feb. 19, 2024, 11:49 a.m. UTC | #2 
Hi Guillaume,

On 19 Feb 12:43, Guillaume Nault wrote:
> On Sat, Feb 17, 2024 at 05:13:26PM -0300, Ricardo B. Marliere wrote:
> > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> > core can properly handle constant struct device_type. Move the vxlan_type
> > variable to be a constant structure as well, placing it into read-only
> > memory which can not be modified at runtime.
> 
> Reviewed-by: Guillaume Nault <gnault@redhat.com>
> 
> Note: To help maintainers (and potentially reviewers) work please
> write in the subject prefix which tree you're targetting. For this
> series, it should be "[PATCH net-next xx/yy]".

Makes sense, will keep this in mind next time!

Thanks for reviewing,
-	Ricardo.
diff mbox series

Patch

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 705a6fd6ab6c..386cbe4d3327 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -3254,7 +3254,7 @@  static const struct net_device_ops vxlan_netdev_raw_ops = {
 };
 
 /* Info for udev, that this is a virtual tunnel endpoint */
-static struct device_type vxlan_type = {
+static const struct device_type vxlan_type = {
 	.name = "vxlan",
 };