From patchwork Fri Feb 16 18:42:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 202366 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp790749dyb; Fri, 16 Feb 2024 13:16:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU96QFggXRHl5qVh2IXYLXmFzVHChZqXrCBorlplHFMden8YfgkzDT7Iy4jQfgyV0p15jEErKJQwQZKvXxw9drYbi+lXg== X-Google-Smtp-Source: AGHT+IFWIrMjtiaH1TAL3zqbRJ5yYjP+XbbXFwRmJ+EsAEgdoOevBydtA3YBqMDxsb7kzXhhTUG5 X-Received: by 2002:a05:6870:f611:b0:21a:2e98:75ec with SMTP id ek17-20020a056870f61100b0021a2e9875ecmr6345933oab.48.1708118179702; Fri, 16 Feb 2024 13:16:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708118179; cv=pass; d=google.com; s=arc-20160816; b=wQUOpffpVQgT0+/+kbgeNMh66M2sc/oYaRC90WDuGTPeLTxa+vW4UEkbuYVTJAa96l hxF68kBSQP3xUk7jeWgGxsiDoK0vXmyQcntUouhR8AOKo/5kqZJ4Zf9/4m5gmehsV6yp Sipx+EIfEV00BaevrzMcCRclbON1lsVhoWSpsr/4Cjh4VDGU+A56p1pllBuI1VLDjGq4 L6BbbIn4q8CxJv751rvPG6kdB86VEb0papM4Q7GUORoc7ZCzBZKQcOYDwnlIHF7IWwu7 iy0dwKt/3U85w+fj+g+hhw8A18dP9ojqHepivw2CIKEUPhtgH9wFK3RZar8MXw6sQHUr dhVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-filter; bh=SAnn149WPcRSWlF7+qZT0uD2dxJItI8EU6I6anRlq8E=; fh=qrdLH5V6S6EHhdSAR+OVGwuqNaPW77Tf5cttX4TmYBA=; b=U1AbJJjaag5DApwqigQ/KkBILcnhwgnjaWYdQgkoHNYE9kPoWr+yvoGrVxkDGWjddD pkl0TNG82v5qf9oTWje/hoRLCyUOH/Vbw/VH8QmJzjiHCaQySksz/iQTsU/MH1ueX5HA cK3bjHq0dT7QmZCazTsocWChjKpAwEfvHp9M9eD8gYuQZmxwaT/O5nph06shb9b+TmUe J2x2/N4G1EKkWFjpeIwfBShzsrhMcHy/BQEdl4fKkvux/SoVZ9vdWwOdKiHJMcIyTuqx 9vfSyTMdKxub0JF1IZR+07e/ST9AO76LqeVohYX+rHntLgxoIZr81dh7lVlKMsQKbfBo w1Nw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b="Kosdvd/0"; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-69195-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69195-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j19-20020a05620a411300b00785a436c916si958854qko.59.2024.02.16.13.16.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 13:16:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69195-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b="Kosdvd/0"; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-69195-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69195-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7666A1C2313D for ; Fri, 16 Feb 2024 18:46:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4B3414A0A7; Fri, 16 Feb 2024 18:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Kosdvd/0" Received: from relay.smtp-ext.broadcom.com (unknown [192.19.166.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7448212BEA5; Fri, 16 Feb 2024 18:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.19.166.231 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708108973; cv=none; b=pyrV7aETUWV/Vh7Mx0zZGITxZEGqpGBJbmHiEnaKDp4exn/9cQi3/5YyKrN93CD2NdMVFActXz09HayTx7EFWUCeVz1M0CLb2I4z795mqhe1dH/qnmWJhUIIsfCWzZ0Jzpe/3+axfus+dkyK1x1g4K6FgTPjg0s4hIWyp4Swjhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708108973; c=relaxed/simple; bh=aYVN0ClhfDjP4lyRugwKQwrba9nObMXNir2vK77i6h8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IGtzpAADf8xzhyfgh/t/NgIIMe3EBAWueffYQyjB2NLPTcrLUYRevkb/GbMhXyKs7nAukcuBirbcaN8tjURRe9gBgZxtZwP823GzwD3Db+ISgiBBWNM1I4AT7wHsw7kCXC6DMjFuCs2gtIEH3Aa+atfZQBUG7NqdYvy70QwLDeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Kosdvd/0; arc=none smtp.client-ip=192.19.166.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 5A595C001649; Fri, 16 Feb 2024 10:42:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 5A595C001649 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1708108964; bh=aYVN0ClhfDjP4lyRugwKQwrba9nObMXNir2vK77i6h8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kosdvd/0aXFCgAb/wSbT4QkgQzw0O6+P4UZsh6g9NqKv1Z3YpNL4exLRaPQE3MhHI AJ0JF7oK6feH+Bu4GhKHVOZ8LprE/GpSoOXMo6LCv/KbjCFow+ss96vYdEu77rdeTQ z14x9A9PeTWqUgTG0+jmbk6rf8c12n1gWXecUhhM= Received: from fainelli-desktop.igp.broadcom.net (fainelli-desktop.dhcp.broadcom.net [10.67.48.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id D2D7518041CAC6; Fri, 16 Feb 2024 10:42:42 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Doug Berger , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , linux-kernel@vger.kernel.org (open list), Justin Chen Subject: [PATCH net-next 3/3] Revert "net: bcmgenet: Ensure MDIO unregistration has clocks enabled" Date: Fri, 16 Feb 2024 10:42:37 -0800 Message-Id: <20240216184237.259954-4-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240216184237.259954-1-florian.fainelli@broadcom.com> References: <20240216184237.259954-1-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791091728142580991 X-GMAIL-MSGID: 1791091728142580991 This reverts commit eac0aac07f6af47b8ba57c8064bf04ed6df73d1d ("net: bcmgenet: Ensure MDIO unregistration has clocks enabled"). This is no longer necessary now that the MDIO bus controller has a clock that it can manage around the I/O accesses. Signed-off-by: Florian Fainelli Reviewed-by: Jacob Keller --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 7a21950da77c..9ada89355747 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -678,7 +678,5 @@ void bcmgenet_mii_exit(struct net_device *dev) if (of_phy_is_fixed_link(dn)) of_phy_deregister_fixed_link(dn); of_node_put(priv->phy_dn); - clk_prepare_enable(priv->clk); platform_device_unregister(priv->mii_pdev); - clk_disable_unprepare(priv->clk); }