From patchwork Fri Feb 16 18:31:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 202310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp711879dyb; Fri, 16 Feb 2024 10:41:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUmFRIRdU0yFGorcqb518+8lIoUpSkUJI9CLZBriuUBsYaGLhBK1K5EAEe2NYl/Ei0MFP2BkLgN7AnW2v43m1IOtguEhw== X-Google-Smtp-Source: AGHT+IGItboS8UgxJ8+lWgd9RQCpxmDLWtESsgmb/MFyr5WDO1m3N6iDGv0DPn88ZnHQ4jm2B6VK X-Received: by 2002:aa7:ca4d:0:b0:561:9ca7:bd34 with SMTP id j13-20020aa7ca4d000000b005619ca7bd34mr4505277edt.32.1708108897166; Fri, 16 Feb 2024 10:41:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708108897; cv=pass; d=google.com; s=arc-20160816; b=u8GLaWlM8P7bLD0t3QBMnzVMASXyrEPvqE33ypZiirfRbW78U0qQ3pPhKeAkZa/j1A id5wRXypcQQn9xZGx8tw0AXx+nI4QYxx1YBKRP9lCpSbloneq/ScZ32hNVJvA/y0yqdu dOBu1t3YeyRPDHo/oyX+foYKOQiSCdY0mfn716shgl6xgu06H/GZXMz30tkyEtiJ+X6W 2+cIa1dAZiaDxVdLOGkCLQVVizf+uToWTSlofDOGhj41ossU+H+A15Xr0yI4m4BDgx7M fnXHFShGQwmXY6aX/q9JhBe+hpTCE3FEfyQ+zIv63/s+GBVkm1wXnoFUAq4ihV/45/FA 2sEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NIgRVY95Czz2uvDMLBT/P8lHA/YSLsxu7WXMaEzsDZ8=; fh=ZNwPNAR7NMo1z5wvX3GodXZOLclCanONi8hVdvkp3FU=; b=hNvfb0lL0Ipe8MAbMZbzdOJhO8DcpuLooegqnr1MKClsssAIxLJBoRVd0503iNv06r f3rt+HrYWgXPKyHezQPImDd1aj3z1MzTlESzd1rXgvVniFQrvF5BXNs0q5eh5JEinexE ZPk9G7Kh0F3VQtKoE6ThyeqUEfkA89/RwsGUkmce3FZk3kFxYoXLioRkPmz+izlFWed8 u410tKVuNptvryQFPI0vetOPcxYJ7R6C0vaAM+nrNKG6HGE26mlfwIK6qb0Dq164Qy7h EvR3/j1o6LMpXy1Gfw3x1sxefNYdIT96kD5+m4S8q26wVurN6RybFmzuj2R5qpWPX18Y lDsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=glu0DniM; arc=pass (i=1 spf=pass spfdomain=joelfernandes.org dkim=pass dkdomain=joelfernandes.org); spf=pass (google.com: domain of linux-kernel+bounces-69166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69166-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u20-20020aa7d894000000b0056215e37846si196187edq.67.2024.02.16.10.41.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 10:41:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=glu0DniM; arc=pass (i=1 spf=pass spfdomain=joelfernandes.org dkim=pass dkdomain=joelfernandes.org); spf=pass (google.com: domain of linux-kernel+bounces-69166-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69166-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E32A91F23B29 for ; Fri, 16 Feb 2024 18:33:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D7F6137C42; Fri, 16 Feb 2024 18:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="glu0DniM" Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557F11369A7 for ; Fri, 16 Feb 2024 18:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708108312; cv=none; b=lB1tCzJHCRIdnRfbuugMuw0ogXOmQZgZA3eDAdOmw9ApUgoMWp+ENyYuvPGrZ1blpz3HptOFt8vppNataLoZNCTq0QS87rXWupFRHj5RUINha0sVULNoopctIZJSEFcNOo8kXlvvZ1FqCYhHKIVRjMNpJH6UyBikFCXI5/Izkkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708108312; c=relaxed/simple; bh=G1fDd4qTQBCk+lDij0THy4jcCMe3hYb5TF5caIUyaxo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lCw0lztQUgbD1qbjH9R4TYO6sAaNryf7dDjLN1A/RPBiyt3BO+e+bu6ZBB90Q0TFFjSSPQR2+dvZtUr3egvPFAmTi5BDg5YXOOogK5QupyApptMV5lGhUJt2FI2TcDWxYdnaJeFi7eZm6K7KOl5E36Y6M/rQ/Fh/lMcjh0aclrg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org; spf=pass smtp.mailfrom=joelfernandes.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b=glu0DniM; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=joelfernandes.org Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-68f3fdcb59aso1160786d6.3 for ; Fri, 16 Feb 2024 10:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1708108309; x=1708713109; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NIgRVY95Czz2uvDMLBT/P8lHA/YSLsxu7WXMaEzsDZ8=; b=glu0DniM+b37P/XLwgGTJaGXenX6CGg6rvtGC/nmjfmDD3KmB/ymPgiB3AujHkbPN2 iWchfmbPBdW+m2Jq4fMtIckhxoiqE74kSFdzJap7CsyZzH3WtvTLoTRl45Grmalfr0Ue 71S50n1jDEc4dNzLFN6xTY6Uwpb5iJYVBef4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708108309; x=1708713109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NIgRVY95Czz2uvDMLBT/P8lHA/YSLsxu7WXMaEzsDZ8=; b=BJweHer2GKKudEKUDO7gyKeeUy6NnkIAj5lAvoYIzGChma85J9qdofHJXA38bDM+qU XPM5JsuPkGNnKrV6rFyR4ft5YvUhvZPZTGsSqKcLEG7FU02fSPDyYD6cu19Gy5PmQs2u 4uuJ0BqfKdndPXw1dIkaJaHulZFl/pTc3AnIbht1LIXLinpksw+P0AW0a0JDljUeQyGX FTNZRUWCgTOu755uS4U4ccBqqBdB4K2joUMRNfJ+qPsGfE3Ijk60Nv6fdF0TqI/caw5P aDvrgBPOz5d6T29zJ7K6tkcLUndlHDkkK/BvM+4HUWgIaq2F84tJ3QIfU8hM0SirNJ3b YZWw== X-Gm-Message-State: AOJu0Yzf3Y6mh5/sAGvRZrd6+2Y8A0mAbM8RtEq2+6C5YpNe6CytUCR3 GQycpH44J3aOQFTwJ5e1jQgKacrGz3YxtFOGmOZtyjibxolJ9bjDdpQmwTqXfaWU5CSRtHAdhbq h X-Received: by 2002:a0c:f38d:0:b0:68f:1e7c:5f46 with SMTP id i13-20020a0cf38d000000b0068f1e7c5f46mr4945535qvk.45.1708108309141; Fri, 16 Feb 2024 10:31:49 -0800 (PST) Received: from joelbox2.. (c-98-249-43-138.hsd1.va.comcast.net. [98.249.43.138]) by smtp.gmail.com with ESMTPSA id nd13-20020a056214420d00b0068cdadb5e7esm159722qvb.31.2024.02.16.10.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 10:31:48 -0800 (PST) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider Cc: Suleiman Souhlal , Youssef Esmat , David Vernet , Thomas Gleixner , "Paul E . McKenney" , joseph.salisbury@canonical.com, Luca Abeni , Tommaso Cucinotta , Vineeth Pillai , Shuah Khan , Phil Auld Subject: [PATCH 06/10] sched: server: Don't start hrtick for DL server tasks Date: Fri, 16 Feb 2024 13:31:04 -0500 Message-Id: <20240216183108.1564958-7-joel@joelfernandes.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240216183108.1564958-1-joel@joelfernandes.org> References: <20240216183108.1564958-1-joel@joelfernandes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791081994583330065 X-GMAIL-MSGID: 1791081994583330065 From: Suleiman Souhlal Otherwise, we might start it even for tasks in a sched class that should have it off. Signed-off-by: Suleiman Souhlal --- kernel/sched/deadline.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 8fafe3f8b59c..5adfc15803c3 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2325,11 +2325,12 @@ static struct task_struct *pick_next_task_dl(struct rq *rq) if (!p) return p; - if (!p->dl_server) + if (!p->dl_server) { set_next_task_dl(rq, p, true); - if (hrtick_enabled(rq)) - start_hrtick_dl(rq, &p->dl); + if (hrtick_enabled(rq)) + start_hrtick_dl(rq, &p->dl); + } return p; }