From patchwork Fri Feb 16 17:04:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 202246 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:c619:b0:108:e6aa:91d0 with SMTP id hn25csp651732dyb; Fri, 16 Feb 2024 09:06:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXGVfLWtEmshuVrdjjGIAu/gX80f+gpRInpvSNIziV+9A5jfV/zvlGtC+kvm+DnWMHhH+aIrcYi1L9WTgBbZguxpaSu8A== X-Google-Smtp-Source: AGHT+IFBVTF24YKMJTYA0jr2dDpvEM2nUmCoYpy7CnT3n5X7r7RAo4bc5bMvso/UVpsWeVLrF+Fl X-Received: by 2002:a05:6a00:1c90:b0:6e0:935c:ff6d with SMTP id y16-20020a056a001c9000b006e0935cff6dmr6679925pfw.17.1708103162074; Fri, 16 Feb 2024 09:06:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708103162; cv=pass; d=google.com; s=arc-20160816; b=HFUrnLiYLKeRWtmqRM3S8aF4+B/DLQUUWGlKR9cJ7a+lWdIdxrU9iNIg9pdlCaktXq 5pt45m/bHPh8gpQDJI42YPKnSV71VXB45R7z2wWBaDwAjqjjlX9IYf3uf4CIBRL9I0Th mD8Dv+im/WWEG4RO1sNDFawQN3va+xLBUEdilf2zxBXnXYHPmPohdPpsCzH3tDfdrv3Q tCjWClVxXDOe1jm3OmDBSxdTHAlQazBTGLiiT4HiJtNTJdyTaNXhnvlkyvSHBFSb8vXz uEu2RbwR/LFSfS1/RCcX44yj+bTA/0l1OyihO7uLVTDqEICZeyypXrll47mjjsppToe7 gKsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=WD56Myi2ma1dKYxOJWeOyvZTZc0rVPwnTQ4cjyMsISI=; fh=vJ0CYzlC3FzFcxY+JvdHzizIe8XjzG5USPt1Sa6qsGI=; b=oWKx9xECXkvNdKHmgoeFCmAIk17Kt6lgNkxq7/raGjKeJkzVbMkKJY2ZxEoH2tsW0x EljhccLwdxuKcPhY6O//oO+nPcMsVCiKcCbz+zx/+4EwXQlfM1L8oQ6i0yJ6kLz9sn9i svEO53ZxsNwHr3M8vvfMwaE4on7MTctjkgav+K6IIQn0+HPfprH7iw4X+A+rMsE/CP05 GAeE/uXPciQ1iHOfSbzP6Ze9tyyndyDX6ww28TlXCzdq5sfkmRAI5q+iCNhugtW5GArS s8XtDe5QDpeq06H/7+8R9Tmq9UBeegjXmemK852jaA9vnHXU85WOHdQQ8jLl5Id/qgxi EUEg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sent.com header.s=fm1 header.b=KeWgkpLH; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=nA9WCOef; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-69013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69013-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id fd24-20020a056a002e9800b006e0949b2543si186952pfb.342.2024.02.16.09.06.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 09:06:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sent.com header.s=fm1 header.b=KeWgkpLH; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=nA9WCOef; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-69013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69013-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CEFC2285D05 for ; Fri, 16 Feb 2024 17:05:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26806132C05; Fri, 16 Feb 2024 17:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="KeWgkpLH"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nA9WCOef" Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F191E130E27 for ; Fri, 16 Feb 2024 17:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103091; cv=none; b=FgRWZsKlHf4aiS4RGtHb3CsBFFtePAtOndqY5lMRLJYS5pjj5ASQc6j2/t0NMfx2fR993r4E6pcPfanphjuL7nFQgdV5Wfl4NnlA9nmPBr5qJ9grygFo55MQQoSlD3BJNlJHUj7ndODGclpgEqQ3YNnStYRkNuaGH4M4sX/gC7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103091; c=relaxed/simple; bh=AZRPic9i3EQrfTrEUZCLdsDgVGaWankE3PcrdXSA2IE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aW5d9cXhfmBNks5KearoDHitcxkmGiiVJuxbtKUHL55StgOUnkBFf4xva3r7ecxgrQIbWuhiDZ/spfCgfBF3QJuX+lTuB0qAl2Br065gmVFJ+YmrQwWFuZOK4oK8IvtwkjBw7xaKQKZztaklT6NY2CZy9Yz4W6buZ+g4ilMH74Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com; spf=pass smtp.mailfrom=sent.com; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b=KeWgkpLH; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=nA9WCOef; arc=none smtp.client-ip=66.111.4.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sent.com Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C12E75C0032; Fri, 16 Feb 2024 12:04:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 16 Feb 2024 12:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm1; t= 1708103087; x=1708189487; bh=WD56Myi2ma1dKYxOJWeOyvZTZc0rVPwnTQ4 cjyMsISI=; b=KeWgkpLHvEgib+nAV2iSIRK1oPhtFJyIarQ2y/xOs5yYd/BGSPz uimtlyTVya0vqRic9W7BfgqjjY/LiexKL75iLtAUb85dLjtGN25wGGAlDaLiQk6c WUFjKBSoUHSGYwyDxL4/B5/EZlmvfLjjqnqSzLtGWJ+zhHfTU9pGWlFeGmNhlSj/ Zcfc0IBHI4hlVFRbnFLGfZ0xDWKz4kJqM74Go/BaWahS+1feW0dSN8W5DCijwwNS Rm3mPzCcdqxQnCZ0Xk42Mq4B9po52QwbtXkezGK10XmaF8hxeNF9oNzD6UZswpm6 OwwYof0mMUOaovwZeY/Arq5YQqj5aH3ZgHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1708103087; x=1708189487; bh=WD56Myi2ma1dKYxOJWeOyvZTZc0rVPwnTQ4 cjyMsISI=; b=nA9WCOef4yROrcXUY6gTn/Rl5akvLP8BE1kABzdgqYYdWRfoOUS 7TwaSNJI/uFo5/U1YOQLzow4T/pS8+OLFS/o/s8lNY5EUzoupMI5myGgUovIa2jX yuKRRDYn5DRzsNd4V3HE0f/RUaNIui4QMdOQ8DRjp1Ql3NXakxOmuoEdVuafF5xq BAfsVpiMWNsQv+2T59MPucgsAzhdTXWgw0TkXbMOhWsYMqYwkBg9zQJol2c/63N+ H76UfoGN4mLp/0SyxB+hnvOHXyY5Vo/hVfm1nQfsVqqSTCPUbyc4pPw7YEFFPbJ1 wLEKWg5SZdqRFHjWVTzTj+rxP1oKJmEUGzQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfrhggtgfgsehtkeertdertdejnecuhfhrohhmpegkihcu jggrnhcuoeiiihdrhigrnhesshgvnhhtrdgtohhmqeenucggtffrrghtthgvrhhnpeejke etkeffleelkeduffdtfedvtdejjeeutdeutdetgeejgfevtdefudejkeeiveenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiiihdrhigrnhessh gvnhhtrdgtohhm X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Feb 2024 12:04:47 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v6 1/4] mm/page_alloc: remove unused fpi_flags in free_pages_prepare() Date: Fri, 16 Feb 2024 12:04:29 -0500 Message-ID: <20240216170432.1268753-2-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240216170432.1268753-1-zi.yan@sent.com> References: <20240216170432.1268753-1-zi.yan@sent.com> Reply-To: Zi Yan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791075981089637935 X-GMAIL-MSGID: 1791075981089637935 From: Zi Yan fpi_flags is only passed to should_skip_kasan_poison() but ignored by the function. Remove the unused parameter. Signed-off-by: Zi Yan Reviewed-by: Vlastimil Babka Reviewed-by: David Hildenbrand --- mm/page_alloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7ae4b74c9e5c..70c1ed3addf3 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1061,7 +1061,7 @@ static int free_tail_page_prepare(struct page *head_page, struct page *page) * on-demand allocation and then freed again before the deferred pages * initialization is done, but this is not likely to happen. */ -static inline bool should_skip_kasan_poison(struct page *page, fpi_t fpi_flags) +static inline bool should_skip_kasan_poison(struct page *page) { if (IS_ENABLED(CONFIG_KASAN_GENERIC)) return deferred_pages_enabled(); @@ -1081,10 +1081,10 @@ static void kernel_init_pages(struct page *page, int numpages) } static __always_inline bool free_pages_prepare(struct page *page, - unsigned int order, fpi_t fpi_flags) + unsigned int order) { int bad = 0; - bool skip_kasan_poison = should_skip_kasan_poison(page, fpi_flags); + bool skip_kasan_poison = should_skip_kasan_poison(page); bool init = want_init_on_free(); bool compound = PageCompound(page); @@ -1266,7 +1266,7 @@ static void __free_pages_ok(struct page *page, unsigned int order, unsigned long pfn = page_to_pfn(page); struct zone *zone = page_zone(page); - if (!free_pages_prepare(page, order, fpi_flags)) + if (!free_pages_prepare(page, order)) return; /* @@ -2379,7 +2379,7 @@ static bool free_unref_page_prepare(struct page *page, unsigned long pfn, { int migratetype; - if (!free_pages_prepare(page, order, FPI_NONE)) + if (!free_pages_prepare(page, order)) return false; migratetype = get_pfnblock_migratetype(page, pfn);